From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011034.outbound.protection.outlook.com [52.101.52.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B1FA3655C3 for ; Fri, 26 Jun 2026 16:43:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.34 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782492200; cv=fail; b=Fo9aaROeHGoZ+58A6Y9DJ/lupusb+0jtj2gJRnqxN2+JgMi/EcSXGr1MoRXylrac/kMNhVsXyFTeTkwcic6xQkDhtSrEKxEJQH+L95K5fY7vZ0apsIFcDuuXfOS2cjZdF7NJ7cIl6MHbWZsdPaDKKblSCJy5jAyemJsechTWmpw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782492200; c=relaxed/simple; bh=+Bp1tTo4WBBV/eMHJN4u64lY/pxfVzswdlMh8nhUy84=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=rvGYzJ5kWp4UojGngRE4IubOiEpOwlIXDBb5AhxVmHisNKZy1X320jAv4l9OgJkXWWuhZ8As+JnuekQ0RLUdrqqy591Wvcf3DfX/InBb73CR1mzjqj5vKEH/NkvSCtGDDpjOenfgih7DQMHy3jItkHWpnTe0ulDvrPdjLqjzfQ0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=mmHFA1N+; arc=fail smtp.client-ip=52.101.52.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="mmHFA1N+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qMwODhPpSxKcaYTIfiTaNP7LA0kSSAmLshJ0o6ZRdWWf1NL0nFRCeAtU7VgjteAs8huyAWlHwdDq6oxfQhmS1GNE2d9zFX9in2kjPqyUNMzgpM2Bd/DXAzxemqqrtbf9xopwzpPF3gsVMUr5ZsTkpigcGOwaqvbxOMzE9g/UIcMQ6C20ByJgB5mBAKwwm+puPPDPhh/OV6+rOlC6CxMjZClm11dwiExARWMq2rYTZUP3dXb61lU10ndT3sxfehvc2jeA0aERYeNq2QPbJKK+WwAGKWiolCuipCiVMRBLHlsMKmuAEmLTzRyGnJ8nqmlfMNjd4nGjnmBpzPzlgFuTMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9gY2+6VR2V7S4I9bmKDsSE5Y4LXytlAuGMhaBiyK6Hk=; b=kt8k3mzQog5oU4mSZvvBov+FSJnvKUEPOxRjn8yVO04Pc7l2ojnDVgm1tqr4Eoc0MOelUuAc6SJ1WzACd+Ul/cv2OLU9P1qSn2hZOkrHKNpkgbAJ2AOZv+jrWBq/tXrSFQn4efYaC+b9rSH4lOPTztiIPmOIQ0Dbt9cIqfJFW9IHINYeeI0JbkFoRAAfXDsF3Nynv1HWF0eraFZcdaYMtN8NmKgTxu9lmq+YG+mkJWH/1oaEVEO9bzhpF8zztOf51ZSQqBJ/NWK3pD/5b/IVV6fFLhutD2LlwRQA7BfdjU8KW7Zvn/jzSKiskU6uOAltPEsqNVmkuNnm30SYtgmy6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9gY2+6VR2V7S4I9bmKDsSE5Y4LXytlAuGMhaBiyK6Hk=; b=mmHFA1N+pTEW+7oq8Z5XtOa0vQ1vTgMTeRoSl5tkFLLEp1UiI419IVoMY/IDWXEMZ2pxsk2jmugY/ueQtf1QVQWPqIS0zjI9ERT+6HmOnSATHbZcvd5l3b60dwh5CPbCirveSKmziU+/un/SbfiK1swN4D6+2A8q2E4Xb82MacE= Received: from MN0PR04CA0011.namprd04.prod.outlook.com (2603:10b6:208:52d::7) by PH7PR12MB7019.namprd12.prod.outlook.com (2603:10b6:510:1b9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.15; Fri, 26 Jun 2026 16:43:07 +0000 Received: from BL6PEPF00022574.namprd02.prod.outlook.com (2603:10b6:208:52d:cafe::77) by MN0PR04CA0011.outlook.office365.com (2603:10b6:208:52d::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.159.18 via Frontend Transport; Fri, 26 Jun 2026 16:43:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL6PEPF00022574.mail.protection.outlook.com (10.167.249.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Fri, 26 Jun 2026 16:43:06 +0000 Received: from [10.252.220.114] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Fri, 26 Jun 2026 11:43:01 -0500 Message-ID: <6d477d0b-1f14-4e33-958d-e6a66c647963@amd.com> Date: Fri, 26 Jun 2026 22:12:58 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm/migrate: rename page to folio leftovers To: "David Hildenbrand (Arm)" , Andrew Morton , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko CC: , , Dev Jain References: <20260626-migrate-cleanups-prep-v1-0-a95933af7619@amd.com> <20260626-migrate-cleanups-prep-v1-1-a95933af7619@amd.com> <53e834e9-2cb1-49c1-ab27-2d6b51d50fc0@kernel.org> Content-Language: en-US From: "Garg, Shivank" In-Reply-To: <53e834e9-2cb1-49c1-ab27-2d6b51d50fc0@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00022574:EE_|PH7PR12MB7019:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d6a214e-d3d7-426c-33bd-08ded3a1ffed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|23010399003|82310400026|36860700016|921020|56012099006|18002099003|22082099003|11063799006|4143699003; X-Microsoft-Antispam-Message-Info: nXp6nWDJBGA7cXb5E0WW3E3ifmS9nbe+2cqyM9XE4NlihGB9qxlR3Sir+sGLCH68dW2M/EznB+uug6JH1DmszrWdHwHfGHd1fbg2buVWyYnM9/QTjhCu7bNmaSCzI5ycqCZpOyiT8VZsEqAV63e+4rJZggOd+3Al8XrzBbvtDGC2ScNYXBqUQ/TfRyNcY3BP/pWYl4pWPAA+nAdupOCzyBGcIIujdCN9CW2X8hvUTATJWEfuEAKlNP4xd/6ByqUqTP6bEP9dUChOcsxYATm/lRkyNTxZE9c81z9rFv2SnROhqm97PzOwLGBzJR/jqDxAG54OGivbBqjGGbzybNg3s2aSdYWdkxMwnbIhnPTI4QJEAYe0/9tdkxzS/kS0gicDoBQ0dUIBFZeAPCXRneIjc0nLCDJYCQfZ9RBo7IrLCAYPDI+qu3inpf47+9dqVk1QJi9gv4Va8GqvLKiyWLOPYi/oCAOjopxBrxZ07D6s09LlDvpWKycJeCeCqRGDITcnlYv7qnmxMjHp+frmEv7W6jqHk1zyXtg+P4IkkVms/lur4IM7ZcVh4AtItET73Ueoullshz12E5eWLcBkwoUAKaBM5C/59STMMgyKx6VlB8GULRaxkPmvIhfDARmGFwRJzC0an8G6kr0koiAjxZjvdhibbkiFwy2HzGD6s2+lcnkjCQaIMshSANDupII+V9lGvEEBx744jImJrywk3soDZ/S81AKLMqi3w/6kWI+5/unWOnbs2nhkbpDFqpnRMl5l X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(23010399003)(82310400026)(36860700016)(921020)(56012099006)(18002099003)(22082099003)(11063799006)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: nSYpHncaXQEP4hU8loCQrfPY7M57+c4XoYhyrAY1Rqvt0SFaXBTjh5718bb9PSj4guH5sx4JXfrUiYrHsIFYo3v1QarNEKtirMVJIGrA8GP5GYiDsBGGIHmMH3mTNNVvJUTU5HTn5/STEVWVPrQZTGrMRxOqyV0EJEBlPR3/GFxiUuvCig+4h2Qf4Dwgn3Kx7wE15ro7loyHZVtFV2Mrn7c0GxxspCPjuGSWB+3P7UHiJsmZYNQosqxroq4AFQTmDaudvFN0kLesdY6VmFlsS3sIesVdg4RzXXFSiKiME+wOmglWAPoyAe7TYSA1ryBYG3i0DZCBTrKb0VPP8+lMRrlaC2PefcQEgFKbkAalpsg8+rjpZCpdaMOnfn7EN3z176IxrLdpSx0XqcoYs1NY9FuD9Pbuz3iqxJDDtCN+9BNF+NDx1i087LVeJSfUUxDi X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2026 16:43:06.9686 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d6a214e-d3d7-426c-33bd-08ded3a1ffed X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00022574.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7019 On 6/26/2026 9:40 PM, David Hildenbrand (Arm) wrote: > On 6/26/26 11:37, Shivank Garg wrote: >> Rename migrate_folio_undo_src()'s page_was_mapped parameter to >> folio_was_mapped, matching FOLIO_WAS_MAPPED naming. >> >> Also fix migrate_folio() kerneldoc to say "folio" instead of "page". >> >> Suggested-by: Dev Jain >> Signed-off-by: Shivank Garg >> --- >> mm/migrate.c | 11 ++++------- >> 1 file changed, 4 insertions(+), 7 deletions(-) >> >> diff --git a/mm/migrate.c b/mm/migrate.c >> index d9b23909d716..dd7dbd8d84a0 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -884,7 +884,7 @@ static int __migrate_folio(struct address_space *mapping, struct folio *dst, >> * @mapping: The address_space containing the folio. >> * @dst: The folio to migrate the data to. >> * @src: The folio containing the current data. >> - * @mode: How to migrate the page. >> + * @mode: How to migrate the folio. >> * >> * Common logic to directly migrate a single LRU folio suitable for >> * folios that do not have private data. >> @@ -1157,13 +1157,10 @@ static void __migrate_folio_extract(struct folio *dst, >> } >> >> /* Restore the source folio to the original state upon failure */ >> -static void migrate_folio_undo_src(struct folio *src, >> - int page_was_mapped, >> - struct anon_vma *anon_vma, >> - bool locked, >> - struct list_head *ret) >> +static void migrate_folio_undo_src(struct folio *src, int folio_was_mapped, >> + struct anon_vma *anon_vma, bool locked, struct list_head *ret) >> { >> - if (page_was_mapped) >> + if (folio_was_mapped) > > Why not "was_mapped" given that folio is part of the function name? > > (it's also not "folio_locked") :) > yes, makes sense. I'll use was_mapped. While here, what's your opinion on unmap_and_move_huge_page()? It also has local variable named page_was_mapped even though the function is fully folio-based. The function name and comments still have "page". Thanks, Shivank