From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CBDB3090C1 for ; Mon, 5 Jan 2026 18:00:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767636010; cv=none; b=OuE0DkvOOzx7ykqbsBdjaA3NdhfkHoUDrLbvQkvut9xaWaUtuPRJcahnU6aATWHgnwm6Vt7NHhrYSX1B8MP11hG4yF7DdpzyQhvor6BUimjG2Dd9Dcm5CT7D9xg9W6d44FUiVQ5iFeTWbjQ5nDo24iYqsCXqtPUqL8bsnreuACk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767636010; c=relaxed/simple; bh=5/19OY6eZY8CTI1TjSHvmJQ6WXrakW3nS1Hjc8j58LI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CDcmWcdxSAojb4zaEaOpWcD1Yq7oKKsdqd4hpZWZIX7lnB3pOwmGZ+TowViXax7DA0rX7PBVF0ebcnlVNsAZHDiZN27REbRUZmHbD5K1Z79AxsimbtIpJlts0iR84Z0i2h7pRy6LYTUqEn3DWgy7ln7RPbsstPvNzCt3rUjZfCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TN1IOeCF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NUAtls0Q; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TN1IOeCF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NUAtls0Q" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 605FtkL2978934 for ; Mon, 5 Jan 2026 18:00:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zZOJPN/yb0Ckwc+93wrH09JVZmpZlHivpeL60KoebF0=; b=TN1IOeCFX9A9463X tDJ5gw58saPQGS4s0wH/Ncwde2y4GhNdxoZDzfCVUm4XvhsA1QcPLG18AwKUV0WN tYCDdu7J7xQ7zaGgUBB801BZi8BRQUJhf+j2ISv0qItsWTEP/DnsghjjAngoir8d 8jMWZ/l8vTdkDEOnI4uBqvA1MK/5DBoVRgMwkjdkW9I7LLaFAcM7a8h2vYcIiokt J0Pc2cID1nmzqJAphVofDou2UstvWOL4eFE28uP6rVqq+Cs1t8kwg+aLyi8EiR9L e7i1nBSylOpCuyefBsVJGH71QBzxtNdWatIrYCBZlJeKijpyrko1TZ6+L6ZpPzdi sAWmCA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bg9fthp7d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 05 Jan 2026 18:00:07 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a0e9e0fd49so21263365ad.0 for ; Mon, 05 Jan 2026 10:00:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767636007; x=1768240807; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zZOJPN/yb0Ckwc+93wrH09JVZmpZlHivpeL60KoebF0=; b=NUAtls0QXLyQIy7Ka+NJO8GK0DrhmhEqb0QWmmJXIQ4fJdtMlxEpmdSyzitRlK/TQc F6w9KSo8cCTPIVz7tmHFnNNPpQsIoQQOjyqcyN5p725juRqDrCV2JkJ60zqztPRt4BPG qyBgfSBMQON0d5Siwrt/meKLPCLWanBftzoEfdxCUq9Nh9FM+SfnpUihS+hUK18/R9cE +MqTgvIG7u/oCbieYDc3ZriEfe3ui+CXKEzliS1vsiNHBgQnmPtJzdgVXrGnKGjJtrIC i/j/krBVtlO82rpELsx7UguZWHjR2bVFvk3NeeN628i/QwApUjVBcrBQigiEHwSQdd2f UqWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767636007; x=1768240807; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zZOJPN/yb0Ckwc+93wrH09JVZmpZlHivpeL60KoebF0=; b=mnznbm3Z3FDT1th7sL0gdUF0Sa3TzwUpzuQvuoAymirNQyH+YaRnX+2MF+i8YIOpxC dBx6eosfe0mI+f8M3Owz1GORGyy/84QWBEOUi4KLoRYnPAQKtfRR57zzjIYuk8N0ZsB/ bd9EhyIWqEp8gFQKjbFm1qwB32RO9/scrijDhrmg5aBhi/ajKatM7ffFb2Np5wsvmyqw BzWWctp0GuTOr8fBm4fm9HOONy/DmHJgHKnGiNvVZ+kl82lA7aIH++qqEq49LhVcR3d6 5KYs7gdUnG5IKlk5JyLzsknAfzQf+b/Y8AwIa4qBgJTXJDJ9EHJ+xi2W2jS6mwm+N+ed 5FIg== X-Forwarded-Encrypted: i=1; AJvYcCXpbZeE8tG4EV7rFDeqEmVCWeMM/urA0hoHkjZDgwpYDBVbLdaBQhp95zfQUEDo8rMj0Ns6yIa2dIZsLTo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7MLWe9CFZDJxbx4qR/4J2/xkql8NJ6Mb4Xdig00R00PtmyOC0 EtVwwAm66CTH7ktYUIkBxHPAsdbg+KXK5Ag3s3FkQ0selvBUfW1aWxVLKeWjIBZr0KmDlRmdyX5 muq22Nl49ubdtkHlbFcIU3olmdy1cElydp2JAqMoq/oNjZ551cDNo6tr1YfO11GCoyzE= X-Gm-Gg: AY/fxX4VwFqPMKvO2iObh1hqEdFb1VD1vDpL7heNQ1nAmyyj3gg9GCfqNFtC3EaMqYG YnpDe2LQpKOfH49iWC101N2cOoUZkE65VQkyQ6xA3lFO5doYAdBwzpmNh5Vvwyhx+4LYBrYQdkW xhbNKRMRLQu8h/Ss1rmMgtIys8y3YgfsWyZswsUJ1WkWtZilbUHezpLMGD/PkBobsBre98eiZ1M f/ifI125NSsrIAOG4CBOHo4gjzu0agsF7v2/dD/rcY7tgFHNKGUeCpixlMIvOj8Vu01QvMQSu1W BV7thZfL1BTtOdA3/LOUvh1jtudPY+gfV9b3BG9D8YL/xBjCbhwD37N7PQ9gjs+7H+02E+RhwQO /zO1bSeXpzVGYZmAxh0E9m/myAY9TWU0tQSMBQFMZhhtjlNpePw== X-Received: by 2002:a17:90b:3b4f:b0:32e:8ff9:d124 with SMTP id 98e67ed59e1d1-34f5f8b4f02mr7965a91.15.1767636005579; Mon, 05 Jan 2026 10:00:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IEXnFzNWl9jnWzXu1wXVFqUFevFHXlW2JypT3YQ0urh+Ea5xHWLmn/4yUAoYuZeO8boIXKu1Q== X-Received: by 2002:a17:90b:3b4f:b0:32e:8ff9:d124 with SMTP id 98e67ed59e1d1-34f5f8b4f02mr7929a91.15.1767636004925; Mon, 05 Jan 2026 10:00:04 -0800 (PST) Received: from [192.168.0.107] ([183.82.31.185]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f5f7b1922sm15402a91.4.2026.01.05.10.00.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jan 2026 10:00:04 -0800 (PST) Message-ID: <6d48473e-2c00-4d3a-ab9f-338761db33d2@oss.qualcomm.com> Date: Mon, 5 Jan 2026 23:30:00 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/9] remoteproc: qcom_q6v5_wcss: support m3 firmware To: mr.nuke.me@gmail.com, Konrad Dybcio , andersson@kernel.org, jeff.johnson@oss.qualcomm.com Cc: mathieu.poirier@linaro.org, krzk+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251219043425.888585-1-mr.nuke.me@gmail.com> <20251219043425.888585-7-mr.nuke.me@gmail.com> <5b9cd24e-7eae-4cbb-b013-6ef135902ae7@oss.qualcomm.com> <5116928.iIbC2pHGDl@nukework.gtech> <4e21205e-0b09-496e-9d6f-9fe2c327c13a@oss.qualcomm.com> <7d5be110-c605-4a02-8121-1c4cb2571bb8@gmail.com> Content-Language: en-US From: Vignesh Viswanathan In-Reply-To: <7d5be110-c605-4a02-8121-1c4cb2571bb8@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: PrRfiS9YevmFWv0yFDvyejpMhZXhJBvT X-Authority-Analysis: v=2.4 cv=GboaXAXL c=1 sm=1 tr=0 ts=695bfc27 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=V6Ol1F/91haf34TWKFX4Fg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=pGLkceISAAAA:8 a=SWP3IsI89bYa406iQT8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: PrRfiS9YevmFWv0yFDvyejpMhZXhJBvT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA1MDE1NiBTYWx0ZWRfX8/Pr8PaqfwEv Y3m/TapDpALv06OylZB5lfweSAlJ+AL3mfDncxFkE+eoGl3qQMFlOfpukxXFk/ijtEbjRavioue jkMwqopcnYUhh0rMmqTR/od1WYdMflVs3p30TwSQ0iE39kDp209FJQVc7J7wh1C+YasRe7hRDeq HzINeASP2MmryOy3jRUPUts01qQwt+M5r7ipM0WSUnUbE4Bxw/RzFKmktq4lM5+hbbGDFEy8RHR e9zp5/NlKE5wrhM+YRjRrNHDL9Zzgk1ZL5l2XPEbUo+auWczeGXzsE5QMaSGMX/3NGW22D/ay0u h60ZfeD4Khwv0p8wDqnzKIwPVQ80Z0TXSdAB/NRpvPrSF7MNN6GNfeLUPHFvwsEQjRICQ0jMrH4 DiRpl205WWYzz4z9NXgnu0/5ZI+mG5XU6mbPA3YEUFhkRITKThAWZqdh/gEClDFX+S+HPqK6vtS 4UJNCJrVz7plhi8qVCQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_01,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 spamscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601050156 On 1/5/2026 8:53 PM, mr.nuke.me@gmail.com wrote: > > > On 12/29/25 6:37 AM, Konrad Dybcio wrote: >> On 12/23/25 9:35 PM, Alex G. wrote: >>> On Friday, December 19, 2025 7:29:07 AM CST Konrad Dybcio wrote: >>>> On 12/19/25 5:34 AM, Alexandru Gagniuc wrote: >>>>> IPQ8074, IPQ6018, and IPQ9574 support an m3 firmware image in addtion >>>>> to the q6 firmware. The firmware releases from qcom provide both q6 >>>>> and m3 firmware for these SoCs. Support loading the m3 firmware image. >>>>> >>>>> Signed-off-by: Alexandru Gagniuc >>>>> --- >> >> [...] >> >>>>> +static int q6v5_wcss_load_aux(struct q6v5_wcss *wcss, const char >>>>> *fw_name) >>>>> +{ >>>>> +    const struct firmware *extra_fw; >>>>> +    int ret; >>>>> + >>>>> +    dev_info(wcss->dev, "loading additional firmware image %s\n", >>> fw_name); >> >> Your email client is messing up the reply context - if it happens to >> be Thunderbird, set: >> >> mailnews.wraplength = 0 >> mailnews.send_plaintext_flowed = false >> >> in the config > > Oops. >>>> >>>> I don't think this log line is useful beyond development >>> >>> Remoteproc driver prints the main (q6) fimrware name, so I thought it would be >>> prudent to print the names of any additional firmwares: >>> >>>      remoteproc remoteproc0: Booting fw image IPQ9574/q6_fw.mdt, size 8140 >>> >>>>> + >>>>> +    ret = request_firmware(&extra_fw, fw_name, wcss->dev); >>>>> +    if (ret) >>>>> +        return 0; >>>> >>>> return ret, perhaps? Unless you want to say that "it's fine if the M3 image >>>> is missing, particularly not to impose any new requirements on existing >>>> setups". But you haven't spelt that out explicitly. >>> >>> I intended to not abort when aux firmware is missing. Maybe the better way to >>> handle this is to check for "-ENOENT" in the caller instead of return 0 here. >>> >>>> You also haven't provided an explanation as to why the firmware should be >>>> loaded. Is it necessary for some functionality? Is it that case on the >>>> newly-supported IPQ9574? >>> >>> I don't have a good answer. I reasoned that since the qcom provides it [1], >>> the M3 firmware would need to be loaded. I haven't done much testing without >>> it. >> >> Well, could you please try? >> >> IIRC it was strictly necessary for ATH1xk-on-PCIe so I'm assuming it's going >> to be a necessity here as well > > I tried this without the M3 firmware, and I don't see a measurable difference in normal operation. I only tested AP mode briefly. How can I know for sure if the M3 firmware is needed or not? AFAIK, M3 Firmware is required for an underlying sub-processor which is used by the Wi-Fi subsystem. Hi Jeff, Is there any upstream facing documentation on the need for M3 Firmware ? Thanks, Vignesh > > Alex >