From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751792AbdLIVLz (ORCPT ); Sat, 9 Dec 2017 16:11:55 -0500 Received: from mout.web.de ([212.227.15.4]:61131 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbdLIVLw (ORCPT ); Sat, 9 Dec 2017 16:11:52 -0500 To: linux-serial@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] serial: bfin_uart: Delete an error message for a failed memory allocation in bfin_serial_probe() Message-ID: <6d49e768-0b26-991c-ec4a-ed9226f4da05@users.sourceforge.net> Date: Sat, 9 Dec 2017 22:11:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:zK4sRuINmgjoYdhnFDy+rxd7oPzw+17v1KpfoRLWUluTAR7vHLp k9Z/WqwqDFjfgzEBStBB6ST9bUt6H6obJOEuWVRM0c/Hk+m8UmUOPQp1LiAdMUjrqw7l6JF n61wRWI7ftC6mKH7CaicPUXK98zJmadOtBO8rp2BOXxybFNCENOz/QF35bVXtEzMO+JkBfa hSYW+dNXsYJO5RGYPj3LQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:B+yNINdnOWU=:aCaRUMg7DXBvb+GZWUYvuI T0HJcHHcIga2LjUIQcMuv4XJxSmoZ0nQbkyftQR0j2xByehF2n19leAHwg9E9aGxBqatLnVHC 1ITdy9DwQ7IhubXZFI91S1+dfxmkEK8AV7U3DPG2aCdk5X2txCvtRCANgb11UHn0Wvu8n417H zzskSrCHf0ugwX0lRZWXr1Z8SLsxd73J01VYWMZfbZUnfEpx6fo0tUMxXc2lbKb4F5f0/imHl 4sayz0mID9cimv9G64CAeyacL+h+IRVx/lpMpJdIThT/Dp15dGqalvI0ECWOK67nhVOBRQfRv NUJ41ipfNPw5iUdM5Pq1irAg51ixSW8hWoAaUe6VP+4m+lYT9VrSvTPTWNgXNup6cmeBNCxW5 GVVvPflZ9p2TYnR8yE0WxNuLnDxTGAHFFRn0tuH2iqOaVIVYDJdVh1NZtbrI9au6Ikm/p1E4e H7bznjnWaANS2aKmflX7jLKjY9B2RSxjfV3cTCTFVDUn0aE4opE+zn99Uu/cT7wved40/1upt qPX7gzSfRdb6oplgGnPJxBM+UWsdOIQtc/ODQZ7GDuTGe6xSxQmKTTDsNWyqbT9nfKY82gXu/ /f64N8gs4urG1dAe4Y4r1W3W/VvScLHr8wl3rTqh4PiUPiV7Xne4ifj3DDaWVCSL1ucwSr58b he0vDRX0Y61dIc3auS7CLJm0StqQ0CcdxKERHb531YJOexS/mn8eGy2GWnSsfTpqXD1TRLn4b kDvneKzM2yuwlCdz7advVf1w75oYRBZmpFGWaBgydXQdlbYcmwf06HNpeer8xH3JcMV0VAtKJ O76j3JGies+Choy4Bdv3ep6lNVtnDVgpydQBYbflAHCeySpRXI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 9 Dec 2017 22:05:54 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/bfin_uart.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/bfin_uart.c b/drivers/tty/serial/bfin_uart.c index 4755fa696321..558f6ebc4f01 100644 --- a/drivers/tty/serial/bfin_uart.c +++ b/drivers/tty/serial/bfin_uart.c @@ -1221,11 +1221,9 @@ static int bfin_serial_probe(struct platform_device *pdev) if (bfin_serial_ports[pdev->id] == NULL) { uart = kzalloc(sizeof(*uart), GFP_KERNEL); - if (!uart) { - dev_err(&pdev->dev, - "fail to malloc bfin_serial_port\n"); + if (!uart) return -ENOMEM; - } + bfin_serial_ports[pdev->id] = uart; #ifdef CONFIG_EARLY_PRINTK -- 2.15.1