From: Joe Perches <joe@perches.com>
To: ChunyouTang <tangchunyou@163.com>,
akpm@linux-foundation.org, colin.king@canonical.com,
david@redhat.com, xndchn@gmail.com, ebiggers@google.com,
sjpark@amazon.de
Cc: linux-kernel@vger.kernel.org, zhangwen@yulong.com,
tangchunyou@yulong.com
Subject: Re: [PATCH v2] scripts/spelling.txt: increase error-prone spell checking
Date: Wed, 20 Jan 2021 19:40:06 -0800 [thread overview]
Message-ID: <6d4b70cd1a4e82ac9669b7341c05537f8741e4b6.camel@perches.com> (raw)
In-Reply-To: <20210121032952.2537-1-tangchunyou@163.com>
On Thu, 2021-01-21 at 11:29 +0800, ChunyouTang wrote:
> From: tangchunyou <tangchunyou@yulong.com>
>
> Increase maping spelling error check
Hi again. Thank you. I appreciate the addition.
Your word choice here is slightly odd English.
When you 'increase' a spelling error check, you might better use another
word like 'improve' as 'increase' here tends to mean 'more errors' rather
than mean a new addition to the spelling correction list.
Next time, a better subject and commit message might be something like:
[PATCH] spelling.txt: Add maping -> mapping
Add an entry for maping and its mapping correction.
Signed-off-by: You <your_email@domain.tld>
cheers, Joe
> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
[]
> @@ -875,6 +875,7 @@ manger||manager
> manoeuvering||maneuvering
> manufaucturing||manufacturing
> mappping||mapping
> +maping||mapping
> matchs||matches
> mathimatical||mathematical
> mathimatic||mathematic
parent reply other threads:[~2021-01-21 4:04 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210121032952.2537-1-tangchunyou@163.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d4b70cd1a4e82ac9669b7341c05537f8741e4b6.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=david@redhat.com \
--cc=ebiggers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sjpark@amazon.de \
--cc=tangchunyou@163.com \
--cc=tangchunyou@yulong.com \
--cc=xndchn@gmail.com \
--cc=zhangwen@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®