From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=113.46.200.224 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792573540; b=DPuTFl5/7JdYnTkNOVQPMswzZp8zcxI8a4ACZKDBtiGnaznS+Inq9DGvU94543Ax2PH0 SnQbq0uUNc9QQWO0GWWjHohd2k9A6tetJMLIlWxfPQdTAr3qPsL6OUq6fv9+X6o6l23Z9 EgwOMzk2OggIxLUqK6KNYqedDo+o11lelKTIudEPIfS/4fpmOcHI1TbcXMIH8/Kt4/2xF u49OIqO9p3eCuCvA4Xis3fTQCnxRndpij7GcRUIOdN5QRT8y49xdXHJtKQQIBlouzcOQU gGyCA1mZBat7vCl8XewirITiJYoBCFGaouWXNWnaXboOqrMtGsPkOcxlpjt1idIJX/g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792573540; h=DMARC-Filter:dkim-signature:Received:Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:CC:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Originating-IP: X-ClientProxiedBy; bh=qly2ZXVqJU8mRHFencdxpDDot1stjgFFpJM+J90ArtI=; b=3XMjQA+gCJdNOLlfTymWN5nJrV/w7JGy87io8Jh4CEVSthqP7vvjqhdbc8nxbCu5EQBO pWxIrtmbMK1o2v/PpYk/tULILRH4GoEjI5CdApqy4tkZxCkix3KLEVJ4glnhR0RwYu5Wp Vc6fzcdGH9J5QsYtnwTzhVzHmkHb+lWjSB+g3N3qx4H/dOZwuRHbzgoUqrfebfB8jDTgw BlviWajxfr9yvSjQrsB5VtuxNJRn7ITyxpMFu7vWKeW0eXhDwzB3lD0Ru06TzJfqufHyW eC0BShkOLwDM0MQ3sJkSh0mJyuwkrnshmFTKjWRc433iOcZCpdzgy8rUXMiFM2CrISA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256 header.s=dkim header.b=VNIuT+eZ; arc=none smtp.remote-ip=113.46.200.224 Received: from canpmsgout09.his.huawei.com (canpmsgout09.his.huawei.com [113.46.200.224]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19B88606A31F; Wed, 21 Oct 2026 09:05:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 19B88606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256 header.s=dkim header.b=VNIuT+eZ dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=qly2ZXVqJU8mRHFencdxpDDot1stjgFFpJM+J90ArtI=; b=VNIuT+eZ75BYq5bEgDxPMwxDJad0LsRd2qh8O5xIl6lSkVcMxoMw0iYMTpsMxZj6Jahuezyk/ yCYxoyiTPQ7Vzfr1pjBJxOpwsIQj3XOgI1W9mckRnRaKJwL0kZrJRME/xKwgmPeH9Mbs9PUKvqW U5k8YRQq520iy9kJHkZbWqo= Received: from mail.maildlp.com (unknown [172.19.163.15]) by canpmsgout09.his.huawei.com (SkyGuard) with ESMTPS id 4j8jks5JQPz1cySH; Wed, 21 Oct 2026 16:54:13 +0800 (CST) Received: from kwepemk200008.china.huawei.com (unknown [7.202.194.74]) by mail.maildlp.com (Postfix) with ESMTPS id 682B34058E; Wed, 21 Oct 2026 17:05:33 +0800 (CST) Received: from [10.67.110.68] (10.67.110.68) by kwepemk200008.china.huawei.com (7.202.194.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Wed, 21 Oct 2026 17:05:32 +0800 Message-ID: <6d4ba1c2-b672-465b-9683-0aa1ad8dee73@huawei.com> Date: Wed, 21 Oct 2026 17:05:31 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/8] riscv: build crash_mem ranges from memblock instead of resource tree To: Wandun Chen , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20261021083011.2170525-1-chenwandun1@gmail.com> <20261021083011.2170525-2-chenwandun1@gmail.com> From: Jinjie Ruan In-Reply-To: <20261021083011.2170525-2-chenwandun1@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemk200008.china.huawei.com (7.202.194.74) 在 2026/10/21 16:30, Wandun Chen 写道: > From: Wandun Chen > > Replace walk_system_ram_res() with for_each_mem_range(). A later patch > introduces MEMBLOCK_NODUMP in memblock, the reserved-memory regions > marked with MEMBLOCK_NODUMP can be excluded from the vmcore by walking > memblock. > > for_each_mem_range() iterates memblock.memory, which is freed after > init unless ARCH_KEEP_MEMBLOCK is selected. riscv needs ARCH_KEEP_MEMBLOCK > to filter reserved memory from the vmcore, so extend its condition > (ACPI || KEXEC) with CRASH_DUMP. arm64 and loongarch already select > ARCH_KEEP_MEMBLOCK unconditionally. > > Signed-off-by: Wandun Chen > Tested-by: Meijing Zhao > Acked-by: Baoquan He > --- > arch/riscv/Kconfig | 2 +- > arch/riscv/kernel/machine_kexec_file.c | 31 ++++++++++---------------- > 2 files changed, 13 insertions(+), 20 deletions(-) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index e7891a2a89da..e21d0bab77ee 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -58,7 +58,7 @@ config RISCV > select ARCH_HAS_UBSAN > select ARCH_HAS_VDSO_ARCH_DATA > select ARCH_HAVE_NMI_SAFE_CMPXCHG > - select ARCH_KEEP_MEMBLOCK if ACPI || KEXEC > + select ARCH_KEEP_MEMBLOCK if ACPI || KEXEC || CRASH_DUMP > select ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE if 64BIT && MMU > select ARCH_OPTIONAL_KERNEL_RWX if ARCH_HAS_STRICT_KERNEL_RWX > select ARCH_OPTIONAL_KERNEL_RWX_DEFAULT > diff --git a/arch/riscv/kernel/machine_kexec_file.c b/arch/riscv/kernel/machine_kexec_file.c > index 26cd2a8bd0cd..808e872f4063 100644 > --- a/arch/riscv/kernel/machine_kexec_file.c > +++ b/arch/riscv/kernel/machine_kexec_file.c > @@ -37,39 +37,32 @@ int arch_kimage_file_post_load_cleanup(struct kimage *image) > } > > #ifdef CONFIG_CRASH_DUMP > -static int get_nr_ram_ranges_callback(struct resource *res, void *arg) > -{ > - unsigned int *nr_ranges = arg; > - > - (*nr_ranges)++; > - return 0; > -} > - > unsigned int arch_get_system_nr_ranges(void) > { > unsigned int nr_ranges = 2 + crashk_cma_cnt; /* For exclusion of crashkernel region */ > + u64 i; > + phys_addr_t start, end; The kernel prefers the reverse Christmas tree layout for local variables. > > - walk_system_ram_res(0, -1, &nr_ranges, get_nr_ram_ranges_callback); > + for_each_mem_range(i, &start, &end) > + nr_ranges++; > > return nr_ranges; > } > > -static int prepare_elf64_ram_headers_callback(struct resource *res, void *arg) > +int arch_crash_populate_cmem(struct crash_mem *cmem) > { > - struct crash_mem *cmem = arg; > + u64 i; > + phys_addr_t start, end; > > - cmem->ranges[cmem->nr_ranges].start = res->start; > - cmem->ranges[cmem->nr_ranges].end = res->end; > - cmem->nr_ranges++; > + for_each_mem_range(i, &start, &end) { > + cmem->ranges[cmem->nr_ranges].start = start; > + cmem->ranges[cmem->nr_ranges].end = end - 1; > + cmem->nr_ranges++; > + } > > return 0; > } > > -int arch_crash_populate_cmem(struct crash_mem *cmem) > -{ > - return walk_system_ram_res(0, -1, cmem, prepare_elf64_ram_headers_callback); > -} > - > static char *setup_kdump_cmdline(struct kimage *image, char *cmdline, > unsigned long cmdline_len) > { -- Best regards, Jinjie