From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0CE5523A for ; Wed, 17 Sep 2025 07:00:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758092444; cv=none; b=YoEahaCavoKrk3w0TbBoV23+yjT1DxOpHNYQ3+pMtcfUYVicfBJPWtnHa5QOF8/7AIUNVTvmYmtr+EU4BmSkXdGFtFljivIEH/SPQ2I8JI60PY6VR1bx00IhcyfzaGmcq6LW8twW/8W0yMU9SwqRFBMKYI+bhsFjTPD50rXORU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758092444; c=relaxed/simple; bh=o2Bqk1wUDIIpQVjPSN1ePzphntDJiQGEafDEVWV03hE=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=VXS/Targ0VCnWcYBpIRK/Lr6Oq+YDMwM2bWYrEEXXUJ0Xjx8JIRF6D81kw05Qa4xN8PqmYINiB7AEiLoai5hyxjLtVJV+R6WlpPJthLtu0MZUon2zyezw/5fyS3fdb0L2Jj3gcBmFaR2dK8tulsak/UrUBZxy+5tHqS2kfZyGKo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zB1iwpXa; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zB1iwpXa" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3ea7af25f8aso1188623f8f.0 for ; Wed, 17 Sep 2025 00:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758092440; x=1758697240; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=6A9uNx1+mps+BdZiLl551t3BtT+GzBC5veNKQdOvG0I=; b=zB1iwpXat0IbSYqm66JVBFMsTyJqN3c9sPtONJ6hw10JrGtzYiI9aRomdC1+PcbegD JZJToQilM89DlwKVPa4dGkp0MoRNnWFmotsB59IS8YkfYuxfpyguR6Gh25TdI7jt+2hP 4Rb8upXf+OBqoCqU90bDlWq2Cl+7Dv8G0SnIJpvci9E9FBiIQSLmt9bKbWraTEy4VFXR TnlvZqP5Xb0LTnDXZGWO05XnSeh5t8N8pRsKUykvsb9fjw5mW1i48pEfc0587JBVG1rz /+Q2j3aKQbPc3orIpi96PYtbJcph0J4ah7ppuG6rUcpnEaL+NFj//uKfJo68f45TaGjs Ui+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758092440; x=1758697240; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6A9uNx1+mps+BdZiLl551t3BtT+GzBC5veNKQdOvG0I=; b=Nu+t25yjiK+CWZOvblPETQIW5Yjhe7dn+4+ZKRk+e7r0J6boh0+LFfot7TrwAXEdlQ T8Y9owjhFJwGCkTz8M6noXpfoLNFokLIfYpPtkrOR6F/u2httmwVIR+fQQ23KPMRjlLf W8aNi5oAxX75DEhm4NXdcPV0wtFVYh/KfEEYyxAT8ucuojCc95GHop37/5Ov9MQgpVRA GHhxEIDaLZUcnKc7dQn2ueMHDfLCAfaoEdr6OTIrYXa1RTfQ8e4rxmwY0b44ZGFIiL+p Dk6/k/28AHZd+XzAk5gGWab0oFUnQ6jidF/aRpehXfu0faBuMlJd3oMPk8aNP/pqEjnK iWCA== X-Forwarded-Encrypted: i=1; AJvYcCWvSkZk7K0x2f37oqvovxwCs2Oya7m3R0Com6G+3j2AEhWLrul8EUFQepyAwqv0v9rTGNfig3XhIpfInVc=@vger.kernel.org X-Gm-Message-State: AOJu0YxpX1QR87S79c5plkSCTYSVGln8gSaTazQLsvh32/9Evx64E6nQ szINIJfAbaZOnkJAwbirHSm9P2DHGbjSf64wBuygDpdYR/ZgMsVLdB+59PObv0hf/6U= X-Gm-Gg: ASbGncswitaDNxqijkdUl8qnYBN/MiczXku00PpNaAabmhgZ/ho96ndV61OVUDNxJYr LaONok2TQHKR+aUDCffGP84Qpp5hLXzG2MbATLOUUQRMk6xTm5iIuRk/1ekDKqjbD3lAyH+WLch nRXxTl2XmR6BFjkfisaE2SiK7zaggs2p6w5PeodGkSdaKVUegju8OlRGg6doABJW7c1bCaKiBUz rDz2poF46WiKXeElvDcjjKV1r4RytJ+cteoV1Dp7VeCO4wMXsmpi1BZevmAdAQYQ8jrgL1C3pFp YjpnD/6WXmAr9hsQWaQB6wMMVn8xq6dhDSDxPpdCgi5iKgEs1QMrKifibAW74Txre9NpkihKgyD bJHDkCYgfCnpCJKz6eHTW0FLvEsDmhENqiJ0IrUlZVGSQUXuZ3Uchb2O5+3Kf/izOpQLZZJ3d2R 977CjeQ7r05A== X-Google-Smtp-Source: AGHT+IHFVA3VzBNPdHqWXiN9GjHITIJj4HsMCOuzc7U1O93FWbBFOPDyIbTjWxGMsr2FMozK4GF3lQ== X-Received: by 2002:a05:6000:2012:b0:3eb:2313:ec03 with SMTP id ffacd0b85a97d-3ecdf9d1628mr968681f8f.27.1758092438446; Wed, 17 Sep 2025 00:00:38 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:96b6:27e6:6a4b:3879? ([2a01:e0a:3d9:2080:96b6:27e6:6a4b:3879]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-462d525fdb2sm1290975e9.13.2025.09.17.00.00.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Sep 2025 00:00:37 -0700 (PDT) Message-ID: <6d5009cf-9332-4c0f-acf3-baa6a0be3f0d@linaro.org> Date: Wed, 17 Sep 2025 09:00:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Neil Armstrong Subject: Re: [PATCH] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp: do not reference whole usb-switch.yaml From: Neil Armstrong To: Rob Herring Cc: Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250902-topic-sm8x50-fix-qmp-usb43dp-usb-switch-v1-1-5b4a51c8c5a8@linaro.org> <20250905175533.GA1000951-robh@kernel.org> <56ddc607-f30b-410b-af54-e2d9afc06540@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <56ddc607-f30b-410b-af54-e2d9afc06540@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 08/09/2025 09:33, Neil Armstrong wrote: > On 05/09/2025 19:55, Rob Herring wrote: >> On Tue, Sep 02, 2025 at 06:10:05PM +0200, Neil Armstrong wrote: >>> Both bindings describe a different layout of the ports properties, >>> leading to errors when validating DT using this PHY bindings as >>> reported by Rob Herring. >>> >>> Reported-by: Rob Herring >>> Closes: https://lore.kernel.org/all/175462129176.394940.16810637795278334342.robh@kernel.org/ >>> Fixes: 3bad7fe22796 ("dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp: Reference usb-switch.yaml to allow mode-switch") >>> Signed-off-by: Neil Armstrong >>> --- >>>   .../devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml    | 8 +++++--- >>>   1 file changed, 5 insertions(+), 3 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml >>> index c8bc512df08b5694c8599f475de78679a4438449..5005514d7c3a1e4a8893883497fd204bc04e12be 100644 >>> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml >>> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml >>> @@ -73,8 +73,11 @@ properties: >>>       description: >>>         See include/dt-bindings/phy/phy-qcom-qmp.h >>> -  mode-switch: true >>> -  orientation-switch: true >>> +  mode-switch: >>> +    $ref: /schemas/usb/usb-switch.yaml#properties/mode-switch >>> + >>> +  orientation-switch: >>> +    $ref: /schemas/usb/usb-switch.yaml#properties/orientation-switch >> >> This is a pattern we try to avoid with references at a property level. I >> prefer you make port and ports not required in usb-switch.yaml. > > Sure but the ports definitions will still collide in this case. > > The other problem here is the difference in ports definition, > port@0 and port@1 are not the same. > > qcom,sc8280xp-qmp-usb43dp-phy.yaml: >   ports: >     $ref: /schemas/graph.yaml#/properties/ports >     properties: >       port@0: >         $ref: /schemas/graph.yaml#/properties/port >         description: Output endpoint of the PHY > >       port@1: >         $ref: /schemas/graph.yaml#/properties/port >         description: Incoming endpoint from the USB controller > >       port@2: >         $ref: /schemas/graph.yaml#/properties/port >         description: Incoming endpoint from the DisplayPort controller > > usb-switch.yaml: >   ports: >     $ref: /schemas/graph.yaml#/properties/ports >     properties: >       port@0: >         $ref: /schemas/graph.yaml#/properties/port >         description: >           Super Speed (SS) Output endpoint to the Type-C connector > >       port@1: >         $ref: /schemas/graph.yaml#/$defs/port-base >         description: >           Super Speed (SS) Input endpoint from the Super-Speed PHY Do you have any advice how to solve this ? Requires is not the problem, the problem is to have the port definitions in usb-switch.yaml Neil > > Neil > >> >> Rob >