From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBADC2FC0E for ; Thu, 17 Aug 2023 10:30:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349785AbjHQKaA (ORCPT ); Thu, 17 Aug 2023 06:30:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243667AbjHQK3j (ORCPT ); Thu, 17 Aug 2023 06:29:39 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DDC32D54; Thu, 17 Aug 2023 03:29:38 -0700 (PDT) Received: from [192.168.88.20] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5BDB2497; Thu, 17 Aug 2023 12:28:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1692268102; bh=6t44jZbV72pjMZfcadFePl+MnE7XEaDfJ7ot64scjQo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bn87AhZaQEb2SRNlqE7cMGIc3hfOxut76mah7mCTgwui0BZcVj/6i+X1DUibb3b86 xLi1awt7rQoGhEA+ceCbZ10TJkujNFK9/mNLjia1cICBn7Qp5YPFjUI0aMVU0tv4UO nt2K5NorZOlYDZ5zapWwyWI0Xwy7MvsxLhuiE4Pw= Message-ID: <6d552603-a8ae-44db-2598-46017d047566@ideasonboard.com> Date: Thu, 17 Aug 2023 13:29:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] i2c: Make I2C_ATR invisible Content-Language: en-US To: Luca Ceresoli , Geert Uytterhoeven Cc: Wolfram Sang , Sakari Ailus , Andy Shevchenko , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <588d302477cb7e6b30b52ee6448807324c57b88a.1692113321.git.geert+renesas@glider.be> <20230817094512.38b3d45b@booty> From: Tomi Valkeinen In-Reply-To: <20230817094512.38b3d45b@booty> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/08/2023 10:45, Luca Ceresoli wrote: > Hi Geert, > > On Tue, 15 Aug 2023 17:29:11 +0200 > Geert Uytterhoeven wrote: > >> I2C Address Translator (ATR) support is not a stand-alone driver, but a >> library. All of its users select I2C_ATR. Hence there is no need for >> the user to enable this symbol manually, except when compile-testing. >> >> Fixes: a076a860acae77bb ("media: i2c: add I2C Address Translator (ATR) support") >> Signed-off-by: Geert Uytterhoeven >> --- >> Do we care yet about out-of-tree drivers that need this functionality? >> --- >> drivers/i2c/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig >> index c6d1a345ea6d8aee..9388823bb0bb960c 100644 >> --- a/drivers/i2c/Kconfig >> +++ b/drivers/i2c/Kconfig >> @@ -72,7 +72,7 @@ config I2C_MUX >> source "drivers/i2c/muxes/Kconfig" >> >> config I2C_ATR >> - tristate "I2C Address Translator (ATR) support" >> + tristate "I2C Address Translator (ATR) support" if COMPILE_TEST > > Either as-is, or with an anonymous tristate: > > Reviewed-by: Luca Ceresoli Yes, I'm also fine either way: Reviewed-by: Tomi Valkeinen Tomi