From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946268AbcHRJ7n (ORCPT ); Thu, 18 Aug 2016 05:59:43 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:48926 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753483AbcHRJ7k (ORCPT ); Thu, 18 Aug 2016 05:59:40 -0400 Subject: Re: [PATCH 1/9] microblaze: irqchip: Move intc driver to irqchip To: Jason Cooper References: <1471269335-58747-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1471269335-58747-2-git-send-email-Zubair.Kakakhel@imgtec.com> <20160815152250.GE3353@io.lakedaemon.net> CC: , , , , , , From: Zubair Lutfullah Kakakhel Message-ID: <6d594557-f2b2-5b43-1aaa-18ec6b165b5f@imgtec.com> Date: Thu, 18 Aug 2016 10:59:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160815152250.GE3353@io.lakedaemon.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.45] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 08/15/2016 04:22 PM, Jason Cooper wrote: > Hi Zubair, > > On Mon, Aug 15, 2016 at 02:55:27PM +0100, Zubair Lutfullah Kakakhel wrote: >> The Xilinx AXI Interrupt Controller IP block is used by the MIPS >> based xilfpga platform. >> >> Move the interrupt controller code out of arch/microblaze so that >> it can be used by everyone >> >> Signed-off-by: Zubair Lutfullah Kakakhel >> --- >> arch/microblaze/Kconfig | 1 + >> arch/microblaze/kernel/Makefile | 2 +- >> drivers/irqchip/Kconfig | 4 ++++ >> drivers/irqchip/Makefile | 1 + >> arch/microblaze/kernel/intc.c => drivers/irqchip/irq-xilinx.c | 0 >> 5 files changed, 7 insertions(+), 1 deletion(-) >> rename arch/microblaze/kernel/intc.c => drivers/irqchip/irq-xilinx.c (100%) > > When you send the next version, please disable rename detection. The > driver looks pretty straight forward, but I'd like to take the > opportunity to clean up the abstraction around read and write. As well > as making it easier for everyone to review on-list. Thanks for the review. I'll send the v2 in a while. Regards, ZubairLK > > thx, > > Jason. >