From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AF303BD63D for ; Mon, 30 Mar 2026 11:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774870506; cv=none; b=tc6thlJxEfOiV7oSf+4MI8IZi2aLjqvRmTV8nLJqO2hE7wqRP4r7vHL1TlnM0WOeJJLRwAMhBk21hRJcfBRLZpJjfTg+lwBAQ1bavmqNCjRutDfOjmOs19rIWNKuar5hAfNIKZMgA6kAPC/PmdQS9Kt2u0rTCWXaa5/wsIcdQP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774870506; c=relaxed/simple; bh=ycV6YQeXVa5eh8mTB9MAC+9vMFbJHtlkRF2/yOgzqts=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e6XHwEHqsng1NFQF2FKyQf/Fjfss6RtgRJ7yembBxfyf+pYPBSGPwIUwPwJfuGmOtOiJI+t9O53V0FtosJLjq/cpZXjrgUiqnC7bu4MxIUqAGt+nXpMn5Ht8FG0smVqiD2KmJfmEkGxVbYTiiw9UU1tM7yNtcdr16DY6D82z5DQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Xh4gJrX7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bnkE8sIW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Xh4gJrX7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bnkE8sIW" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UApnht2723207 for ; Mon, 30 Mar 2026 11:35:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AD7yhFYem1/46F4xjVAzjcyJmROsEd9YlW0HID3CP4s=; b=Xh4gJrX7unDovN1t Hcy1hvQ4Gq9QsLeJrbRnJjY32V2o5ftIJ1Au/UM/hTaV0pp96z+1bRtxxsjLYvex p3fPltEsM/a2BVDIh58ydwl0hDIygLKuWicbEMV2vILPGnODSgHuJm8P+XjLBjT8 DXOsgGY73L0CJejC1Do+u3d2caqecj236nyIm/sjnYNS3m0OIhaKcxGsZ/KQ1vh8 gUMvUAPPK8KrvD96DqmejVlwQr/kKDgGUuklAf+9NczWiEga8S/zXVZc80VEncdd Z7djOQ+gFZv2q0d9D8RZqWYxTkecT/fO9iLm1SYad+1VsgT7CwCPxbU/QXi57wY8 UapRGQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7qt0g48v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 11:35:03 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cfc0719a1bso86186985a.1 for ; Mon, 30 Mar 2026 04:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774870503; x=1775475303; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AD7yhFYem1/46F4xjVAzjcyJmROsEd9YlW0HID3CP4s=; b=bnkE8sIWs3mw9k1wnROrX+0+xOXPB1ubsDE97ZlhM7aYEGJ5UG0b6Bxu+Y+jZuBNPN 5Tmn71aGxAkbHZz5TiQlTikcU9jBHAgRyaN3HLEBG0/A0cJ3VOAPGZ+eFMFNXXVLHkza ufXbsDjnIs67xFZQZdSOfSAP80gSwFMCJeVqwV2Ij0TTvBkiw+aTLdgQajPSJJRoHUTX +KkOSQ+9tJSm0JWVKnRmt6cObHlOfnTxjeVVDydyRwnUgxiQtdjuaye6eArmB007/Vhx PdL292s/KzS6KJhSWmZQqrJCsKD7kyzvgtPGxdGDDxgC8xiya6fXnXRQXuNu3/xxK2er C1lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774870503; x=1775475303; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AD7yhFYem1/46F4xjVAzjcyJmROsEd9YlW0HID3CP4s=; b=lKqf9lZuB9vra6gDr1ueHq6y8gOiOmYOGk+9Zf7qc/Vv4YyP9G+jXwQvm5Rf2vJaQD SbB//JpWW3sb1LVqRwuAX1suYYMvekBhx21i5PUMlPUi5oZqBFHqpNJQoiGikv97dDOD lwPHbJOr7fiS7OQfMLRwlOaAix2TuPEyOdPjHnlG88qOVtiUoib1G6RaZsdMUTe3baNC 69hjaBwhyzVXeADSqakLAPfJmWv1cFMa0V9107xBgMxqk+NSHyZRxan2Rw3pS9zApkLy hmZAWIjmD14Rji+u/v35mHK1moLYtv6urdUKXP9By1vSXqnVAvX4enXiQOq8aWgGi75F ZKbA== X-Forwarded-Encrypted: i=1; AJvYcCVLvwYUoSMNEZJYFXW2CzDVUkyuqcYH6uCq84xERB7Oc3QdXWQOQBt9ibvhtxn5NVOl37qQbmHiFRkLFD0=@vger.kernel.org X-Gm-Message-State: AOJu0YzcYtvYrKYV1KYEDAwZ8TMNkJCv+byXihrcNpGtm2WXUlYs9li6 99BhBVO1xwfHndtZ0PjsqndX7UoPV4Gbws7kR8oJog2cwblAPtJ91bWf7ti96trQWw/78lCAjpy kkfssbI4lE+2Dd0W7FaHeElL53jKWukW0uRvqNnagTL9VRivIuVWMVs3VCbro5ep2szU= X-Gm-Gg: ATEYQzwJnof34rc8TEOcHomTywzfMJEShm8Mpdp3oTUB0WysNA2zTbTyFwiIFrZ77m3 l/I1MwWjLEz+bYeNlImCdVl2gRK8OXI5DFub0QTbbiV+mmZkCUzOCE4GcEjPAw430ntI34y31rf Y0oidAGJ9D32WhzTD/ZSSERVFYVo7ssV2LjnMJazLvfqENxA6LX91QsWa9zin7oA/rvJ9XIkdwG 2bPC//EfKWaNhP1yfMRXcnpcj90DxZlNLXKGrIWWwvUCQ5hcz7C0gjWFK3tMCTPEWUf59rh8Urt aieRn2rwXWPP2YViIEWn+2NPNZFoV4XiQa0F6CwsYTl6D8QAciHSlar28qOAUBKZm7w73CRkWx4 6fp/CIKICqzSc2ODUavpuQaYDO843d5BBFti3LiWYLy26QP0DIiDbKlycVvb6Rc9IbJ/oq+ujcI S5dqc= X-Received: by 2002:ac8:7d41:0:b0:509:219f:8e34 with SMTP id d75a77b69052e-50ba36c2754mr120405551cf.0.1774870503093; Mon, 30 Mar 2026 04:35:03 -0700 (PDT) X-Received: by 2002:ac8:7d41:0:b0:509:219f:8e34 with SMTP id d75a77b69052e-50ba36c2754mr120405191cf.0.1774870502547; Mon, 30 Mar 2026 04:35:02 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b7ae51ef5sm275868366b.18.2026.03.30.04.34.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 04:35:01 -0700 (PDT) Message-ID: <6d5ebab6-3c4e-4a1c-9578-6e926cbd96de@oss.qualcomm.com> Date: Mon, 30 Mar 2026 13:34:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: Bryan O'Donoghue , Neil Armstrong , Bryan O'Donoghue , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Vladimir Zapolskiy , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260326-x1e-csi2-phy-v5-0-0c0fc7f5c01b@linaro.org> <20260326-x1e-csi2-phy-v5-1-0c0fc7f5c01b@linaro.org> <7712fbdd-a225-49f0-aeb9-ebcbb9d5abac@oss.qualcomm.com> <1f38187a-9464-4aa9-b70a-03b767349d56@linaro.org> <016c03b8-27c3-41dc-a630-8e7095db1f88@linaro.org> <456ded59-d13e-4b61-975b-97ca48b5e771@linaro.org> <76ea03d0-d41b-4880-a48c-06570eb089ed@linaro.org> <0101d8bc-1ae8-475e-bb9e-cc1e16db87ec@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <0101d8bc-1ae8-475e-bb9e-cc1e16db87ec@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=XN09iAhE c=1 sm=1 tr=0 ts=69ca5fe7 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=mneW2Sup4nk-zTkRaDIA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: 2aZUGk5ZCeeZwB0VbhzFVOk1Mhhcipxs X-Proofpoint-ORIG-GUID: 2aZUGk5ZCeeZwB0VbhzFVOk1Mhhcipxs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA5MCBTYWx0ZWRfX+cGtPxilSy3v UJIxIFpQ9nGxvhcJEX4u9JS3dGcXYcGo/BwRMWRfDpNvv3YipAJBxak8SaLfsSWSbkIWPvr/iyj 1LnOzjxWYh8YhVhfFbfUu47Pc9hsQn3iKpBDcqUbH9HP46IoIJBxI5ivDGh77szjGgbxGpDYNTE C2B/W5B39O3sA/rTbVazP9qA9RGhf2RQ3kLY/X9GVOt4LlkJ+PsPFf7pvwg7t71afK5EN8sCRbw BIBOZIRlnotR9Qetce7KFQ5l1+xPnR8OMqG3+VAl4dTxM4/Qd4E/+KXsJUoYO7ttjOsL/04cm+Z Fise3/kI7KmrK2NsMNAj7FWUpC3KkB6QDYvJ3ItMSCssOkb6P0s49b0x8suKbI8D1owelonHSuw K4aCBMHbWuv3T8x5K1xuRLs5G1aH60Z8Tuh7/RdSzFacxYfV2bsNZWfKigvIoQqTqEBW5Hyv40/ 2kEopqzzVCUELJwY+pg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300090 On 3/30/26 11:25 AM, Bryan O'Donoghue wrote: > On 30/03/2026 10:17, Neil Armstrong wrote: >> On 3/30/26 11:02, Bryan O'Donoghue wrote: >>> On 30/03/2026 08:49, Neil Armstrong wrote: >>>> On 3/27/26 18:42, Bryan O'Donoghue wrote: >>>>> On 27/03/2026 15:28, Neil Armstrong wrote: >>>>>>> To be frankly honest you can make an argument for it either way. However my honestly held position is analysing other upstream implementations connecting to the PHY means we can't make the PHY device a drivers/phy device - it would have to be a V4L2 device and then for me the question is why is that even required ? >>>>>> >>>>>> This is plain wrong, DT definition is different from software implementation, you can do whatever you want if you describe HW accurately. >>>>> >>>>> I'm not sure what point it is you are trying to make here. Are you trying to say drivers/phy is OK with you but you want an endpoint ? If so, please just say so. >>>> >>>> I'm against using the "phys = <>" property in the CAMSS to reference the PHYs, a "PHY" in the classic terminology is tied to a single consumer, and if it can be shared to multiple consumer you must model a mux or whatever in the middle. >>> >>> The CSIPHY-to-CSID routing is runtime-configurable and is already managed by the media controller framework. >> >> This is not compatible with the PHY bindings if you don't have a defined MUX device in the middle, it's wrong. You're hiding the muxing details in the CAMSS blob node. >> >>> >>> DT describes static hardware connections. The dynamic mux is a software concern, not a hardware description concern. >> >> DT must describe the possible interconnections between the nodes, if a PHY can be used by multiple hardware components, it must be described. > > But right now the CAMSS block is described as a single block. There is no CSID device in the kernel _yet_. > > When we break CSID into its own block then fine, lets have a debate about a mux then but right now the "nodes" are CAMSS[MONOLITH] <=> CSIPHY there is no DT CSID device to model this to. Let's take a step back - since any CSIPHY can feed into any CSID (at runtime), the resulting nodes would either look like: // hardcoded, m may != n csid_n: csid@1000000 { phys = <&csiphy_m>; }; or // determined at runtime csid_n: csid@1000000 { phys = <&csiphy_0>, [...] <&csiphy_n-1>; }; or we could store them once, centrally, in the "CAMSS_TOP" node and pass handles around as necessary: // camss "catalog/manager" driver/library provides CSIDn with PHYm camss: camss@10000000 { phys = <&csiphy_0>, [...] <&csiphy_n-1>; csid_n: csid@1000 { // no PHY references }; }; Konrad