From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC44C47082 for ; Mon, 31 May 2021 14:20:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D50FB613CD for ; Mon, 31 May 2021 14:20:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233469AbhEaOTC (ORCPT ); Mon, 31 May 2021 10:19:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55249 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231926AbhEaNsk (ORCPT ); Mon, 31 May 2021 09:48:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622468820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Mppih9q2pe0krRA02rkEmn1QaYGR0wK6GLj3051FLM=; b=EslIREJp93YEI2OrduOY/7icRP910lydizwc16hWiGhPOZt8TLZVKRt5JHsyPpa+Rdz3zm CROshmlkzEux3O5L7u3CP3f+RF6NpY8ZHvjK8Mutc+/zeHusd9R9srvtElRaQ0ofYFnac7 JxFzlfpm2X/7/6UVJhjVMBnazk7Q/1M= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-536-IwaAxwu8Nm-W17F9ST_Ppg-1; Mon, 31 May 2021 09:46:59 -0400 X-MC-Unique: IwaAxwu8Nm-W17F9ST_Ppg-1 Received: by mail-ej1-f69.google.com with SMTP id h18-20020a1709063992b02903d59b32b039so2475052eje.12 for ; Mon, 31 May 2021 06:46:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6Mppih9q2pe0krRA02rkEmn1QaYGR0wK6GLj3051FLM=; b=lG7292QygYTVxAi6etUusdBoU5VkigNKN7S3gkFq6+pJvtjARoP/XCl3oGf6NPQ5Ja mcm4jVYLPpexyFO2+hMo4SpiYvDwhOZPkqW6evil3PJDsnVxgIpUaBGr8Ub+XRH7HKlb xOuOieawMtDMVVIqo249A0d3dQob9h1MzYWdEaV+KU+YFQK7AYuGrZbXMYMFvGz6iUPo a3uMoe5wQwJ5V+JL/l7Ap1fTWRTsELtg8dxin4zrJplG+JVaGuOiUY4MZw4UlAf89Y7b Efkgs72yGsp957LMDIoYBU4+yBc/UwYEIzhmc+ZhlUu38/ggX6Vsyp3iHmYpfWHNAzzs Hqpg== X-Gm-Message-State: AOAM5325ho5F4lnht8Wk5wBC38kV42jW37iBXOMT5veOyrSKQIvBUlZy Te1fqHf6nGyerkjuUzHJpwKIJaKS9n5z8T1kBW/fECAYPFFgCMgVDOeVf4EYab6FZ6RhEU2/lWd tkiWmYRyUFVJlb26+mamUcqtK1i30I9k1kWv51568zw7X1/uZKDwAHw0Ac8B7cRoOBit/9UeMem Mh X-Received: by 2002:a17:906:dfea:: with SMTP id lc10mr5179553ejc.148.1622468818477; Mon, 31 May 2021 06:46:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPpE+IMwk1MrbOORE80mWvg7eYwcoNrc63HkzejWjQs6koMXLDB6caROQwZksUbE4iUoEpjA== X-Received: by 2002:a17:906:dfea:: with SMTP id lc10mr5179518ejc.148.1622468818255; Mon, 31 May 2021 06:46:58 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id n4sm5913342eja.121.2021.05.31.06.46.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 May 2021 06:46:57 -0700 (PDT) Subject: Re: [PATCH -next] x86/platform/uv: functions should not be declared extern From: Hans de Goede To: Qiheng Lin , mike.travis@hpe.com, dimitri.sivanich@hpe.com, russ.anderson@hpe.com, dvhart@infradead.org, andy@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com Cc: steve.wahl@hpe.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210531060747.21934-1-linqiheng@huawei.com> <56198fed-ce73-f7e8-3d90-50089e243799@redhat.com> Message-ID: <6d605a59-6069-5a20-f33a-b5ace5437244@redhat.com> Date: Mon, 31 May 2021 15:46:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <56198fed-ce73-f7e8-3d90-50089e243799@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 5/31/21 3:45 PM, Hans de Goede wrote: > Hi, > > On 5/31/21 8:07 AM, Qiheng Lin wrote: >> These function declarations in 'bios.h' are already marked extern, thus >> their definition should not have the keyword. >> >> This quiets the following sparse warnings: >> function 'uv_bios_get_master_nasid' with external linkage has definition >> function 'uv_bios_get_heapsize' with external linkage has definition >> function 'uv_bios_install_heap' with external linkage has definition >> function 'uv_bios_obj_count' with external linkage has definition >> function 'uv_bios_enum_objs' with external linkage has definition >> function 'uv_bios_enum_ports' with external linkage has definition >> function 'uv_bios_get_geoinfo' with external linkage has definition >> function 'uv_bios_get_pci_topology' with external linkage has definition >> >> Signed-off-by: Qiheng Lin > > Thank you for your patch, I've applied this patch to my review-hans > branch: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans > > Note it will show up in my review-hans branch once I've pushed my > local branch there, which might take a while. > > Once I've run some tests on this branch the patches there will be > added to the platform-drivers-x86/for-next branch and eventually > will be included in the pdx86 pull-request to Linus for the next > merge-window. Correction I just noticed that this makes changes under arch/x86 so this should go upstream through the tip tree. So I'm dropping this patch from review-hans now, sorry for the noise. Regards, Hans >> --- >> arch/x86/platform/uv/bios_uv.c | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/arch/x86/platform/uv/bios_uv.c b/arch/x86/platform/uv/bios_uv.c >> index bf31af3d32d6..7e7634c8be62 100644 >> --- a/arch/x86/platform/uv/bios_uv.c >> +++ b/arch/x86/platform/uv/bios_uv.c >> @@ -172,55 +172,55 @@ int uv_bios_set_legacy_vga_target(bool decode, int domain, int bus) >> (u64)decode, (u64)domain, (u64)bus, 0, 0); >> } >> >> -extern s64 uv_bios_get_master_nasid(u64 size, u64 *master_nasid) >> +s64 uv_bios_get_master_nasid(u64 size, u64 *master_nasid) >> { >> return uv_bios_call(UV_BIOS_EXTRA, 0, UV_BIOS_EXTRA_MASTER_NASID, 0, >> size, (u64)master_nasid); >> } >> EXPORT_SYMBOL_GPL(uv_bios_get_master_nasid); >> >> -extern s64 uv_bios_get_heapsize(u64 nasid, u64 size, u64 *heap_size) >> +s64 uv_bios_get_heapsize(u64 nasid, u64 size, u64 *heap_size) >> { >> return uv_bios_call(UV_BIOS_EXTRA, nasid, UV_BIOS_EXTRA_GET_HEAPSIZE, >> 0, size, (u64)heap_size); >> } >> EXPORT_SYMBOL_GPL(uv_bios_get_heapsize); >> >> -extern s64 uv_bios_install_heap(u64 nasid, u64 heap_size, u64 *bios_heap) >> +s64 uv_bios_install_heap(u64 nasid, u64 heap_size, u64 *bios_heap) >> { >> return uv_bios_call(UV_BIOS_EXTRA, nasid, UV_BIOS_EXTRA_INSTALL_HEAP, >> 0, heap_size, (u64)bios_heap); >> } >> EXPORT_SYMBOL_GPL(uv_bios_install_heap); >> >> -extern s64 uv_bios_obj_count(u64 nasid, u64 size, u64 *objcnt) >> +s64 uv_bios_obj_count(u64 nasid, u64 size, u64 *objcnt) >> { >> return uv_bios_call(UV_BIOS_EXTRA, nasid, UV_BIOS_EXTRA_OBJECT_COUNT, >> 0, size, (u64)objcnt); >> } >> EXPORT_SYMBOL_GPL(uv_bios_obj_count); >> >> -extern s64 uv_bios_enum_objs(u64 nasid, u64 size, u64 *objbuf) >> +s64 uv_bios_enum_objs(u64 nasid, u64 size, u64 *objbuf) >> { >> return uv_bios_call(UV_BIOS_EXTRA, nasid, UV_BIOS_EXTRA_ENUM_OBJECTS, >> 0, size, (u64)objbuf); >> } >> EXPORT_SYMBOL_GPL(uv_bios_enum_objs); >> >> -extern s64 uv_bios_enum_ports(u64 nasid, u64 obj_id, u64 size, u64 *portbuf) >> +s64 uv_bios_enum_ports(u64 nasid, u64 obj_id, u64 size, u64 *portbuf) >> { >> return uv_bios_call(UV_BIOS_EXTRA, nasid, UV_BIOS_EXTRA_ENUM_PORTS, >> obj_id, size, (u64)portbuf); >> } >> EXPORT_SYMBOL_GPL(uv_bios_enum_ports); >> >> -extern s64 uv_bios_get_geoinfo(u64 nasid, u64 size, u64 *buf) >> +s64 uv_bios_get_geoinfo(u64 nasid, u64 size, u64 *buf) >> { >> return uv_bios_call(UV_BIOS_GET_GEOINFO, nasid, (u64)buf, size, 0, 0); >> } >> EXPORT_SYMBOL_GPL(uv_bios_get_geoinfo); >> >> -extern s64 uv_bios_get_pci_topology(u64 size, u64 *buf) >> +s64 uv_bios_get_pci_topology(u64 size, u64 *buf) >> { >> return uv_bios_call(UV_BIOS_GET_PCI_TOPOLOGY, (u64)buf, size, 0, 0, 0); >> } >>