From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30058C433E7 for ; Tue, 1 Sep 2020 06:17:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1716B2071B for ; Tue, 1 Sep 2020 06:17:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726503AbgIAGRf (ORCPT ); Tue, 1 Sep 2020 02:17:35 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:54232 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726006AbgIAGRf (ORCPT ); Tue, 1 Sep 2020 02:17:35 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 9513316CCEF2AEE92511; Tue, 1 Sep 2020 14:17:32 +0800 (CST) Received: from [127.0.0.1] (10.174.179.108) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Tue, 1 Sep 2020 14:17:28 +0800 Subject: Re: [PATCH] x86/platform/intel-mid: Fix build error without CONFIG_ACPI To: Randy Dunlap , , , , , , , , References: <20200901035825.25256-1-yuehaibing@huawei.com> <5427fca0-6674-42e9-a3b1-52b060ef0301@infradead.org> CC: , From: Yuehaibing Message-ID: <6d686f3f-b4ee-70e0-3050-1eb6d060ffc3@huawei.com> Date: Tue, 1 Sep 2020 14:17:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <5427fca0-6674-42e9-a3b1-52b060ef0301@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.108] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/1 12:07, Randy Dunlap wrote: > On 8/31/20 8:58 PM, YueHaibing wrote: >> arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’: >> arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration] >> acpi_noirq_set(); >> ^~~~~~~~~~~~~~ >> acpi_irq_get >> >> Fixes: a912a7584ec3 ("x86/platform/intel-mid: Move PCI initialization to arch_init()") >> Signed-off-by: YueHaibing > > Bjorn has merged my patch (or so his email says), but apparently it's not > in linux-next yet. Thanks for info. > > >> --- >> arch/x86/pci/intel_mid_pci.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c >> index 00c62115f39c..0aaf31917061 100644 >> --- a/arch/x86/pci/intel_mid_pci.c >> +++ b/arch/x86/pci/intel_mid_pci.c >> @@ -33,6 +33,7 @@ >> #include >> #include >> #include >> +#include >> >> #define PCIE_CAP_OFFSET 0x100 >> >> > > thanks. >