mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aubrey <aubreylee@gmail.com>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: "Luke Yang" <luke.adi@gmail.com>,
	linux-kernel@vger.kernel.org, "Andrew Morton" <akpm@osdl.org>
Subject: Re: [PATCH 2/4] Blackfin: Serial driver for Blackfin arch on 2.6.18
Date: Thu, 21 Sep 2006 17:23:52 +0800	[thread overview]
Message-ID: <6d6a94c50609210223o5adf9bb5w7bfb70fb59094c85@mail.gmail.com> (raw)
In-Reply-To: <1158830784.11109.93.camel@localhost.localdomain>

On 9/21/06, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> Ar Iau, 2006-09-21 am 11:33 +0800, ysgrifennodd Luke Yang:
> > Hi,
> >
> > This is the serial driver for Blackfin. It is designed for the serial
> > core framework.
>
> > +#define DMA_RX_XCOUNT                TTY_FLIPBUF_SIZE
>
> TTY_FLIPBUF_SIZE is going away. Just pick a value good for your hardware
> and under PAGE_SIZE.

Thanks for your comments. I'll change it soon and submit a new patch.

>
> Other question - is your locking ok for low latency. In low latency mode
> tty_flip_buffer_push() may directly end up calling your write methods.
>
Yes, I noticed that and I think it's ok. The driver is tested everday
and works fine.

-Aubrey

  reply	other threads:[~2006-09-21  9:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-21  3:33 Luke Yang
2006-09-21  5:28 ` Randy.Dunlap
     [not found]   ` <6d6a94c50609210020x5bb32474wa61fab5f9581a124@mail.gmail.com>
2006-09-21  8:28     ` Luke Yang
2006-09-21  9:01       ` Luke Yang
2006-09-21 10:28   ` Matti Aarnio
2006-09-21  9:26 ` Alan Cox
2006-09-21  9:23   ` Aubrey [this message]
2006-09-21  9:57     ` Luke Yang
2006-09-21 15:38       ` Randy.Dunlap
     [not found]         ` <489ecd0c0609210849r44a76be1h9ddbc308ba78d574@mail.gmail.com>
2006-09-21 16:00           ` Aubrey
2006-09-21 16:07       ` Randy.Dunlap
2006-09-22  2:03 ` Oleg Verych
2006-09-22  2:27   ` Aubrey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d6a94c50609210223o5adf9bb5w7bfb70fb59094c85@mail.gmail.com \
    --to=aubreylee@gmail.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®