mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nanzhe Zhao" <nzzhao@126.com>
To: "Chao Yu" <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re:Re: [f2fs-dev] [PATCH] f2fs: avoid f2fs_map_blocks() for consecutive holes in readpages
Date: Mon, 19 Jan 2026 15:43:47 +0800 (CST)	[thread overview]
Message-ID: <6d6b3bad.5f72.19bd535bd6d.Coremail.nzzhao@126.com> (raw)
In-Reply-To: <32fa7311-0393-4e71-a927-3c502e40efd8@kernel.org>

Hi Chao:
At 2026-01-16 16:52:02, "Chao Yu" <chao@kernel.org> wrote:
>> 
>> Do we have plans to also support reducing f2fs_map_blocks() calls for
>> consectives holes in logical file postion with dnode have already been
>> allocated in buffered large folio read?
>> Such as consective NULL_ADDR or NEW_ADDR?
>
>Nanzhe,
>
>We have supported that for large folio read w/ this patch?
>
>Thanks,
>

Sorry, I'm a bit confused.
In the condition of F2FS_MAP_BLOCK_DEFAULT, the default: case will only
set map->m_next_pgofs to pgofs + 1 then sync out. When we enter
next iteration and the index advanced, currrent index now turns to pgofs + 1
and index < next_pgofs become false.In consequence, we won't reduce
f2fs_map_blocks() calls for hole with dnode allocated.

Also, for NEW_ADDR, the default: case will directly go to sync out and bypass
map_is_mergeable, so it will also not reduce f2fs_map_blocks calls.

Or am I missing something?

Thanks,
Nanzhe Zhao

  reply	other threads:[~2026-01-19  7:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12  1:33 Chao Yu
2026-01-15 12:48 ` [f2fs-dev] " Nanzhe Zhao
2026-01-16  8:52   ` Chao Yu
2026-01-19  7:43     ` Nanzhe Zhao [this message]
2026-01-19 13:44       ` Chao Yu
2026-01-20  0:24         ` Nanzhe Zhao
2026-01-20 12:49           ` Chao Yu
2026-01-19 13:50 ` patchwork-bot+f2fs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d6b3bad.5f72.19bd535bd6d.Coremail.nzzhao@126.com \
    --to=nzzhao@126.com \
    --cc=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome