mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Zev Weiss <zev@bewilderbeest.net>,
	Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kconfig: Add findconf script and helper program
Date: Wed, 8 Jun 2022 19:48:44 -0700	[thread overview]
Message-ID: <6d6d252d-79e9-4b4c-4a62-aa4018a6254c@infradead.org> (raw)
In-Reply-To: <20220608095456.27479-1-zev@bewilderbeest.net>

Hi--

On 6/8/22 02:54, Zev Weiss wrote:
> scripts/findconf provides menuconfig's search functionality as a
> standalone, non-interactive command, somewhat in the spirit of
> scripts/config.  It is meant to be useful for tasks like getting a
> quick overview of symbol dependencies or determining which Kconfig
> file to edit for a given symbol, without having to fire up one of the
> interactive config programs.
> 
> It accepts a single command-line flag, '-v', which causes it to also
> print the help text of each matching result.
> 
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> ---

I can see how this could be useful.
It's a little easier to use than what I currently do:

$ findconfig  DRM_HISI_HIBMC
./drivers/gpu/drm/hisilicon/hibmc/Kconfig:2:config DRM_HISI_HIBMC

then $EDITOR that_Kconfig_file


In testing, I am seeing this:

#
# using defaults found in /boot/config-5.3.18-150300.59.63-default
#
.config:421:warning: symbol value 'm' invalid for I8K
.config:2335:warning: symbol value 'm' invalid for MTD_NAND_ECC_SW_HAMMING
.config:2484:warning: symbol value 'm' invalid for PVPANIC
.config:8671:warning: symbol value 'm' invalid for INTERCONNECT
.config:9369:warning: symbol value 'm' invalid for CRYPTO_ARCH_HAVE_LIB_BLAKE2S
.config:9370:warning: symbol value 'm' invalid for CRYPTO_LIB_BLAKE2S_GENERIC
.config:9653:warning: symbol value '1' invalid for KASAN_STACK

How do I specify/choose a .config file to be used?

Oh, use KCONFIG_CONFIG=filename


Please update (add) usage/help text in scripts/kconfig/Makefile.

> 
> This works a bit differently from [gmnq]conf in that it accepts (and
> requires) arguments, but I couldn't see an easy/obvious way of passing
> command-line args through the makefile infrastructure that invokes
> those, so the wrapper script passes things to it via environment
> variables instead.  Suggestions welcome if there's a nicer way of
> achieving that.
> 
>  scripts/findconf           | 22 ++++++++++++
>  scripts/kconfig/.gitignore |  1 +
>  scripts/kconfig/Makefile   |  7 +++-
>  scripts/kconfig/findconf.c | 74 ++++++++++++++++++++++++++++++++++++++
>  scripts/kconfig/lkc.h      |  1 +
>  scripts/kconfig/menu.c     |  2 +-
>  6 files changed, 105 insertions(+), 2 deletions(-)
>  create mode 100755 scripts/findconf
>  create mode 100644 scripts/kconfig/findconf.c
> 

thanks.
-- 
~Randy

  reply	other threads:[~2022-06-09  2:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08  9:54 Zev Weiss
2022-06-09  2:48 ` Randy Dunlap [this message]
2022-06-09  3:46   ` Zev Weiss
2022-06-09  3:48     ` Randy Dunlap
2022-06-09  5:47       ` Masahiro Yamada
2022-06-09 11:19         ` Zev Weiss
2022-06-10 14:44           ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d6d252d-79e9-4b4c-4a62-aa4018a6254c@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=zev@bewilderbeest.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®