From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62A86435ED7 for ; Mon, 10 Aug 2026 18:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385577; cv=none; b=mVeIQDzNk+znFtbazQR0RHEnq4bF38ctsIoPJNhpp3Atw8Mcz2IeTD9kfDhA+b1+nHwujCHe1F5fhO8zYs+d6BpDfajVdCLGUqYuvYPyKq+Q5wTvIv6lStFiIAvlkfn1+jQBEP3wKvMWiekfISablmFUpYy8Tvjq+liL6vGUWWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385577; c=relaxed/simple; bh=umUHF9rOXtQ8ecpvqrgfStmkI7x93dZzPqwKnFRIKpE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WCtD9ozgdwbEnCYdnxHeEARjh+Abr1SnOeoP4SGUN29xlExOdhUOVB2yy1NkgrsxSa3YOMj79QLcUmV8PkS8gwlzK4U8ObLOTIo6NgAHvvVAi3ssuaNYxfHh91eQ/GA3DHIkbomVdF95U08JyM8xDaUcQz0TLT2+rHlGDez33m4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T9JZeWk4; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T9JZeWk4" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cc61541f8cso2437165ad.0 for ; Mon, 10 Aug 2026 11:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786385576; x=1786990376; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LamTcANYadoWUGaG2LRUytAWANVCX7wDn1ku3HxunHQ=; b=T9JZeWk4IpD4iTPx0CR23q8iFJy8F/Vad4RtdKzpTq5ar3eK8bptSs/tOo93zOoSfG mw2gAclcswR3eawCKAt5PqO7puuvSioex+tQ7X6RucLkdkEG2a7X1mtIXTgIV/NRTumj qP23nXd5CEa89JPvVII9FXXFC3/ZOFF5y8bNkVHoxQq4SiF4qwlty0dxbLCD40vhWckV lv6wRjwEFkno7DxaB085x5Y8CeKq7ZQMMyS2/mDCQ9q5hsq3meApTfAI0nC1iDyio2k8 q3pqYty7tGuEDmwUZ1CFKUw2DUnmG9IERYH0IpB0IPCZpUYOH6cBOf52FONXs49x2uh2 mbZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786385576; x=1786990376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=LamTcANYadoWUGaG2LRUytAWANVCX7wDn1ku3HxunHQ=; b=siPMyH2hNDaos9SBj1UnG9/dURNPSG45Hw25rhPcPGD5OipvcDiSRPzQf6lMRsVd7n hWChF1VrR/2+FPWY+GOuPDVKwKNrTHx2po2NAyqEpLKr/ks6FoZTsdMWHNhKaAUmSrqo rD7usMsj89aaGsQ/s7ziBPyFJ9vH+JlRbz78m/W8nQ9nOsejtY8HLLfEX6irrluzqhUI Qow96HoMTZu11NRFKiA5wpUQI+2loBjl6rvKizjDcMetkKzR8jem+GVXMiFDfytqlY/0 POYZ1VyIUzJRbk3e5cJwjMz8VhdKxP4ppqwE691ZBuX1cuJ5k09QBHJneADyHD/LdmrV 2HKw== X-Forwarded-Encrypted: i=1; AHgh+RqjRjWrrHHH4UEa5dxE61Lc4kEkiHqo5MhtJJGnElNHnIatjVwK3G6DIt1RS7EQ5ulI9k0QWj8TqnvBhIo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzx4qGyvgrXRLVCJxnycSL/G7T4dIYQdFv2I2akYTQ6dxgTzKKR uEYF4HeYI/dwGgsk7SPjIJ1XzDk01OcI2ZhKZq1rnLbQ/TZZFPOOygyK X-Gm-Gg: AR+sD11IiVXUrLVy4j6tyxKrAQUo4RhmJ/Qv+9cvyPEArFbBdUFbupeuRQ0C0AmM7z4 08LHOTTFBUnp88eCLq4Nk1lOL9NrsH/ajmXtx3rxjfgRSL3AN0Ov9GjRLmoKutL12hAs5a8QRI7 EjqdGhrGluyo+bJQSy9HF3nyHR/94Df/M6vXDlBTtXDovPpX/7of0oykPgeci1jpZBUv0JFwWfm OeYC1jBLMaxTycuXHQZ4LXvsSlsZmz3WnaLcrz3dep0EY9DHVKoX5jVMoxG2V41Q7Sj596O5YcG I9x5fC458z0WAG+wuYp1ILI3VvgZkEqK16Oh+tnvwsnsfVSgm3Z53fZy2CspfNl4+HV5JcUI7mm AN5/8SMaX9iKV8Ep02pbuhXdopOaopShJQdoL/Zi4KdKhCJR0+/mj4qv3bR7ZZM52v2dxg6rQ5T q4almT2GYR5wrNgmsyLpk0q0zXEzBCYC4XHAUkNw2RpoHbU8/NSDLrLB5qAfIQ8pk= X-Received: by 2002:a17:90b:4f84:b0:38e:5828:a446 with SMTP id 98e67ed59e1d1-392d620beb5mr122845a91.19.1786385575553; Mon, 10 Aug 2026 11:12:55 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fa9:fa00:b1a9:6513:83c6:1d23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d53b873asm472795a91.17.2026.08.10.11.12.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 11:12:55 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook , Laxman Dewangan , Jon Hunter , Thierry Reding , linux-tegra@vger.kernel.org Subject: [PATCH v3 22/34] dmaengine: tegra20-apb: use channel BH helpers Date: Mon, 10 Aug 2026 11:09:23 -0700 Message-ID: <6d720011ba5a41fa48cf1926cd9060da22f89444.1786384169.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Switch the per-channel tasklet to dmaengine_*_bh so completion handling runs through the shared per-channel deferral mechanism. Signed-off-by: Allen Pais --- drivers/dma/tegra20-apb-dma.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index 640b8a218c9a..45995b82a133 100644 --- a/drivers/dma/tegra20-apb-dma.c +++ b/drivers/dma/tegra20-apb-dma.c @@ -194,9 +194,8 @@ struct tegra_dma_channel { struct list_head free_dma_desc; struct list_head cb_desc; - /* ISR handler and tasklet for bottom half of isr handling */ + /* ISR handler for bottom-half processing */ dma_isr_handler isr_handler; - struct tasklet_struct tasklet; /* Channel-slave specific configuration */ unsigned int slave_id; @@ -632,9 +631,10 @@ static void handle_cont_sngl_cycle_dma_done(struct tegra_dma_channel *tdc, } } -static void tegra_dma_tasklet(struct tasklet_struct *t) +static void tegra_dma_tasklet(struct dma_chan *chan) { - struct tegra_dma_channel *tdc = from_tasklet(tdc, t, tasklet); + struct tegra_dma_channel *tdc = container_of(chan, struct tegra_dma_channel, + dma_chan); struct dmaengine_desc_callback cb; struct tegra_dma_desc *dma_desc; unsigned int cb_count; @@ -670,7 +670,7 @@ static irqreturn_t tegra_dma_isr(int irq, void *dev_id) if (status & TEGRA_APBDMA_STATUS_ISE_EOC) { tdc_write(tdc, TEGRA_APBDMA_CHAN_STATUS, status); tdc->isr_handler(tdc, false); - tasklet_schedule(&tdc->tasklet); + dmaengine_schedule_bh(&tdc->dma_chan); wake_up_all(&tdc->wq); spin_unlock(&tdc->lock); return IRQ_HANDLED; @@ -819,7 +819,7 @@ static void tegra_dma_synchronize(struct dma_chan *dc) */ wait_event(tdc->wq, tegra_dma_eoc_interrupt_deasserted(tdc)); - tasklet_kill(&tdc->tasklet); + dmaengine_kill_bh(&tdc->dma_chan); pm_runtime_put(tdc->tdma->dev); } @@ -1317,7 +1317,7 @@ static void tegra_dma_free_chan_resources(struct dma_chan *dc) dev_dbg(tdc2dev(tdc), "Freeing channel %d\n", tdc->id); tegra_dma_terminate_all(dc); - tasklet_kill(&tdc->tasklet); + dmaengine_kill_bh(&tdc->dma_chan); list_splice_init(&tdc->pending_sg_req, &sg_req_list); list_splice_init(&tdc->free_sg_req, &sg_req_list); @@ -1511,7 +1511,7 @@ static int tegra_dma_probe(struct platform_device *pdev) tdc->id = i; tdc->slave_id = TEGRA_APBDMA_SLAVE_ID_INVALID; - tasklet_setup(&tdc->tasklet, tegra_dma_tasklet); + dmaengine_init_bh(&tdc->dma_chan, tegra_dma_tasklet); spin_lock_init(&tdc->lock); init_waitqueue_head(&tdc->wq); @@ -1617,7 +1617,7 @@ static int __maybe_unused tegra_dma_dev_suspend(struct device *dev) for (i = 0; i < tdma->chip_data->nr_channels; i++) { struct tegra_dma_channel *tdc = &tdma->channels[i]; - tasklet_kill(&tdc->tasklet); + dmaengine_kill_bh(&tdc->dma_chan); spin_lock_irqsave(&tdc->lock, flags); busy = tdc->busy; -- 2.43.0