From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755204AbdGKCEI (ORCPT <rfc822;w@1wt.eu>);
        Mon, 10 Jul 2017 22:04:08 -0400
Received: from merlin.infradead.org ([205.233.59.134]:47796 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751071AbdGKCEH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Jul 2017 22:04:07 -0400
Subject: Re: [PATCH 01/17] lib: Add shared copies of some GCC library routines
To: Stephen Rothwell <sfr@canb.auug.org.au>,
        Palmer Dabbelt <palmer@dabbelt.com>
Cc: yamada.masahiro@socionext.com, mmarek@suse.com, will.deacon@arm.com,
        peterz@infradead.org, boqun.feng@gmail.com, mingo@redhat.com,
        daniel.lezcano@linaro.org, tglx@linutronix.de, jason@lakedaemon.net,
        marc.zyngier@arm.com, gregkh@linuxfoundation.org, jslaby@suse.com,
        davem@davemloft.net, mchehab@kernel.org, fweisbec@gmail.com,
        viro@zeniv.linux.org.uk, mcgrof@kernel.org, dledford@redhat.com,
        bart.vanassche@sandisk.com, sstabellini@kernel.org,
        daniel.vetter@ffwll.ch, mpe@ellerman.id.au, msalter@redhat.com,
        nicolas.dichtel@6wind.com, james.hogan@imgtec.com,
        paul.gortmaker@windriver.com, linux@roeck-us.net,
        heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com,
        linux-kernel@vger.kernel.org, patches@groups.riscv.org,
        akpm@linux-foundation.org, albert@sifive.com
References: <20170711013924.22085-1-palmer@dabbelt.com>
 <20170711013924.22085-2-palmer@dabbelt.com>
 <20170711120219.3989dc65@canb.auug.org.au>
From: Randy Dunlap <rdunlap@infradead.org>
Message-ID: <6d735b95-563d-e3b5-3bc4-e25a0fbc167f@infradead.org>
Date: Mon, 10 Jul 2017 19:03:44 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170711120219.3989dc65@canb.auug.org.au>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/10/2017 07:02 PM, Stephen Rothwell wrote:
> Hi Palmer,
> 
> On Mon, 10 Jul 2017 18:39:08 -0700 Palmer Dabbelt <palmer@dabbelt.com> wrote:
>>
>> This patch adds a new copy of these library routine files, which are
>> functionally identical to the various other copies.  These are
>> availiable via Kconfig as CONFIG_LIB_$ROUTINE, which currently isn't
> 
> Umm, the patch actually uses CONFIG_GENERIC_$ROUTINE.
> 
>> +config GENERIC_ASHLDI3
>> +	def_bool n
> 
> Just
> 	bool
> is the same.
> 

and several "default n" lines can (should) be removed from Kconfig.


-- 
~Randy