From: "Christian König" <christian.koenig@amd.com>
To: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] drm/amdgpu: remove gart_window_lock usage from gmc v12
Date: Tue, 16 Sep 2025 11:25:37 +0200 [thread overview]
Message-ID: <6d7b6840-de22-444e-8182-a3b6fdd7d8f0@amd.com> (raw)
In-Reply-To: <20250916070846.5107-2-pierre-eric.pelloux-prayer@amd.com>
On 16.09.25 09:08, Pierre-Eric Pelloux-Prayer wrote:
> This lock was part of the SDMA workaround originally implemented in
> gmc_v10_0_flush_gpu_tlb (a70cb2176f7ef6f moved it to
> amdgpu_gmc_flush_gpu_tlb).
>
> This means this lock is useless and be safely dropped.
>
> Signed-off-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c
> index 76d3c40735b0..454fd1104c6d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c
> @@ -312,9 +312,7 @@ static void gmc_v12_0_flush_gpu_tlb(struct amdgpu_device *adev, uint32_t vmid,
> return;
> }
>
> - mutex_lock(&adev->mman.gtt_window_lock);
> gmc_v12_0_flush_vm_hub(adev, vmid, vmhub, 0);
> - mutex_unlock(&adev->mman.gtt_window_lock);
> return;
> }
>
next prev parent reply other threads:[~2025-09-16 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 7:08 [PATCH v1 1/2] drm/amdgpu: make non-NULL out fence mandatory Pierre-Eric Pelloux-Prayer
2025-09-16 7:08 ` [PATCH v1 2/2] drm/amdgpu: remove gart_window_lock usage from gmc v12 Pierre-Eric Pelloux-Prayer
2025-09-16 9:25 ` Christian König [this message]
2025-09-16 9:25 ` [PATCH v1 1/2] drm/amdgpu: make non-NULL out fence mandatory Christian König
2025-09-16 9:46 ` Pierre-Eric Pelloux-Prayer
2025-09-16 10:52 ` Christian König
2025-09-16 11:58 ` Pierre-Eric Pelloux-Prayer
2025-09-16 12:51 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d7b6840-de22-444e-8182-a3b6fdd7d8f0@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-eric.pelloux-prayer@amd.com \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®