From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Miaoqian Lin <linmq006@gmail.com>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Jeff Garzik <jgarzik@redhat.com>,
David Daney <david.daney@cavium.com>, <linux-ide@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ata: pata_octeon_cf: Fix refcount leak in octeon_cf_probe
Date: Wed, 1 Jun 2022 22:01:06 +0300 [thread overview]
Message-ID: <6d7d546b-e3c0-cd87-522e-c537ddc949bb@omp.ru> (raw)
In-Reply-To: <20220601085926.45183-1-linmq006@gmail.com>
Hello!
On 6/1/22 11:59 AM, Miaoqian Lin wrote:
> of_find_device_by_node() takes reference, we should use put_device()
> to release it when not need anymore.
> Add missing put_device() to avoid refcount leak.
>
> Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
next prev parent reply other threads:[~2022-06-01 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 8:59 Miaoqian Lin
2022-06-01 19:01 ` Sergey Shtylyov [this message]
2022-06-02 6:32 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d7d546b-e3c0-cd87-522e-c537ddc949bb@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=damien.lemoal@opensource.wdc.com \
--cc=david.daney@cavium.com \
--cc=jgarzik@redhat.com \
--cc=linmq006@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®