From: Bart Van Assche <bvanassche@acm.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "David Jeffery" <djeffery@redhat.com>,
linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Tarun Sahu" <tarunsahu@google.com>,
"Pasha Tatashin" <tatashin@google.com>,
"Michał Cłapiński" <mclapinski@google.com>,
"Jordan Richards" <jordanrichards@google.com>,
"Ewan Milne" <emilne@redhat.com>,
"John Meneghini" <jmeneghi@redhat.com>,
"Lombardi, Maurizio" <mlombard@redhat.com>,
"Stuart Hayes" <stuart.w.hayes@gmail.com>,
"Laurence Oberman" <loberman@redhat.com>,
"Marco Elver" <elver@google.com>
Subject: Re: [PATCH 2/5] driver core: separate function to shutdown one device
Date: Wed, 11 Mar 2026 14:42:00 -0700 [thread overview]
Message-ID: <6d82e4f3-7fd6-48b9-b319-b5350d54e9d3@acm.org> (raw)
In-Reply-To: <20260311213728.GA1024689@bhelgaas>
On 3/11/26 2:37 PM, Bjorn Helgaas wrote:
> Maybe it's just the lock anti-pattern below?
Yes, that's my only concern.
> I guess avoiding the "conditional acquisition and later conditional
> release" pattern mentioned at [1] is what makes this compatible with
> lock context analysis?
Correct.
> I guess this is another way of expressing the "no conditionally held
> locks" rule [2], which is more concise and fits better in my pea
> brain.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/context-analysis.rst?id=v7.0-rc1#n42
> [2] https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#no-conditionally-held-locks
Is this perhaps intended as a suggestion for simplifying the language in
Documentation/dev-tools/context-analysis.rst?
s/such as conditional acquisition and later conditional release in the
same function/no conditionally held locks/
Thanks,
Bart.
next prev parent reply other threads:[~2026-03-11 21:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 17:12 [PATCH 1/5] driver core: do not always lock parent in shutdown David Jeffery
2026-03-11 17:12 ` [PATCH 2/5] driver core: separate function to shutdown one device David Jeffery
2026-03-11 18:00 ` Bart Van Assche
2026-03-11 21:37 ` Bjorn Helgaas
2026-03-11 21:42 ` Bart Van Assche [this message]
2026-03-12 13:39 ` David Jeffery
2026-03-12 1:49 ` kernel test robot
2026-03-12 5:10 ` kernel test robot
2026-03-11 17:12 ` [PATCH 3/5] driver core: async device shutdown infrastructure David Jeffery
2026-03-11 19:40 ` Randy Dunlap
2026-03-11 23:05 ` Bjorn Helgaas
2026-03-12 14:01 ` David Jeffery
2026-03-11 17:12 ` [PATCH 4/5] pci: enable async shutdown support David Jeffery
2026-03-11 23:08 ` Bjorn Helgaas
2026-03-12 13:46 ` David Jeffery
2026-03-12 5:09 ` Greg Kroah-Hartman
2026-03-12 13:54 ` David Jeffery
2026-03-11 17:12 ` [PATCH 5/5] scsi: " David Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d82e4f3-7fd6-48b9-b319-b5350d54e9d3@acm.org \
--to=bvanassche@acm.org \
--cc=dakr@kernel.org \
--cc=djeffery@redhat.com \
--cc=driver-core@lists.linux.dev \
--cc=elver@google.com \
--cc=emilne@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=jmeneghi@redhat.com \
--cc=jordanrichards@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=mclapinski@google.com \
--cc=mlombard@redhat.com \
--cc=rafael@kernel.org \
--cc=stuart.w.hayes@gmail.com \
--cc=tarunsahu@google.com \
--cc=tatashin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®