From: Mark Brown <broonie@kernel.org>
To: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
Cc: michael.hennerich@analog.com, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH drivers-next] regulator: ad5398: Fix incorrect power down bit mask
Date: Thu, 6 Feb 2025 11:28:19 +0000 [thread overview]
Message-ID: <6d856228-e5e7-4502-9d0b-9755626faf40@sirena.org.uk> (raw)
In-Reply-To: <20250206103153.59114-1-dheeraj.linuxdev@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
On Thu, Feb 06, 2025 at 04:01:53PM +0530, Dheeraj Reddy Jonnalagadda wrote:
> AD5398_SW_POWER_DOWN was defined with a bit position outside the valid
> range of the device's 16-bit register. The bitwise operation with an
> unsigned short would always evaluate to 0, making the power down check
> ineffective.
Please don't add noise like drivers-next to your subject lines - it just
makes it harder to see the actual subject.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-02-06 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 10:31 Dheeraj Reddy Jonnalagadda
2025-02-06 11:28 ` Mark Brown [this message]
2025-02-06 13:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d856228-e5e7-4502-9d0b-9755626faf40@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dheeraj.linuxdev@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®