From: Randy Dunlap <rdunlap@infradead.org>
To: Li zeming <zeming@nfschina.com>,
rafael.j.wysocki@intel.com, kai.heng.feng@canonical.com,
dmitry.osipenko@collabora.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: reboot: Remove unnecessary ‘0’ values from ret
Date: Sun, 9 Jul 2023 20:53:29 -0700 [thread overview]
Message-ID: <6d8593f4-3dcd-7db8-899b-2f96e02a09a0@infradead.org> (raw)
In-Reply-To: <20230711202145.5138-1-zeming@nfschina.com>
On 7/11/23 13:21, Li zeming wrote:
> ret is assigned first, so it does not need to initialize the assignment.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> kernel/reboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/reboot.c b/kernel/reboot.c
> index 3bba88c7ffc6..e00a02a74694 100644
> --- a/kernel/reboot.c
> +++ b/kernel/reboot.c
> @@ -702,7 +702,7 @@ SYSCALL_DEFINE4(reboot, int, magic1, int, magic2, unsigned int, cmd,
> {
> struct pid_namespace *pid_ns = task_active_pid_ns(current);
> char buffer[256];
> - int ret = 0;
> + int ret;
>
> /* We only trust the superuser with rebooting the system. */
> if (!ns_capable(pid_ns->user_ns, CAP_SYS_BOOT))
--
~Randy
prev parent reply other threads:[~2023-07-10 3:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 20:21 Li zeming
2023-07-10 3:53 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d8593f4-3dcd-7db8-899b-2f96e02a09a0@infradead.org \
--to=rdunlap@infradead.org \
--cc=dmitry.osipenko@collabora.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®