Re: [PATCH v3 01/47] dt-bindings: clock: qcom: gcc-sdm845: Add CX power domain

[Krzysztof Kozlowski <krzk@kernel.org>]

On 24/08/2026 13:53, Abel Vesa wrote:
> Describe the CX power-domain dependency for SDM845 and SDM670 GCCs, and
> require it for both compatibles.
> 
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/clock/qcom,gcc-sdm845.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sdm845.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sdm845.yaml
> index a7523a414341..980edcd244a2 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sdm845.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sdm845.yaml
> @@ -31,6 +31,8 @@ properties:
>      maxItems: 5
>  
>    power-domains:
> +    description:
> +      A phandle and PM domain specifier for the CX power domain.

Describe items instead:
items:
  - description:

Also, "A phandle and PM domain specifier for the" is redundant part of
sentence. This cannot be anything else than phandle and PM domain, thus
just say "CX power domain".

>      maxItems: 1
>  
>  required:
> @@ -56,6 +58,8 @@ allOf:
>              - const: bi_tcxo
>              - const: bi_tcxo_ao
>              - const: sleep_clk
> +      required:
> +        - power-domains

Why? Commit msg should tell me why you are changing ABI. It is actual
ABI break without an explanation...

Best regards,
Krzysztof