mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jürgen Groß" <jgross@suse.com>
To: GuoHan Zhao <zhaoguohan@kylinos.cn>,
	Stefano Stabellini <sstabellini@kernel.org>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/privcmd: unregister xenstore notifier on module exit
Date: Wed, 25 Mar 2026 14:59:43 +0100	[thread overview]
Message-ID: <6d909f11-528a-4d30-9e29-c7e29bc8f730@suse.com> (raw)
In-Reply-To: <20260325120246.252899-1-zhaoguohan@kylinos.cn>


[-- Attachment #1.1.1: Type: text/plain, Size: 737 bytes --]

On 25.03.26 13:02, GuoHan Zhao wrote:
> Commit 453b8fb68f36 ("xen/privcmd: restrict usage in
> unprivileged domU") added a xenstore notifier to defer setting the
> restriction target until Xenstore is ready.
> 
> XEN_PRIVCMD can be built as a module, but privcmd_exit() leaves that
> notifier behind. Balance the notifier lifecycle by unregistering it on
> module exit.
> 
> This is harmless even if xenstore was already ready at registration
> time and the notifier was never queued on the chain.
> 
> Fixes: 453b8fb68f3641fe ("xen/privcmd: restrict usage in unprivileged domU")
> Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>

Thanks for catching this!

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

      reply	other threads:[~2026-03-25 13:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 12:02 GuoHan Zhao
2026-03-25 13:59 ` Jürgen Groß [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d909f11-528a-4d30-9e29-c7e29bc8f730@suse.com \
    --to=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=zhaoguohan@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®