From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A5682134CDC for ; Wed, 3 Apr 2024 09:58:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712138310; cv=none; b=fAay72RPMWanfSLHdSnllmDR0bdYPDWk9IZXEfFbwvwPALMB2hNiagVmS1MPzn1jIhWKDgWX9pwMehfSPteLrSzzeO1weoBpTkac2nLqpRRMwuPlQfPyp2salDIqQ8visZ7/106IThiBotI7KF0jL6CK07TchgkxLcHY5SJUPrY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712138310; c=relaxed/simple; bh=v6kPPu8AbJZK6mxxZQbhLMHpWRSSYapD027qb+raLG0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eCBdM505qeCgq8OAXG1nNZ3wZVANbBbXtzZVtrAkjRXYrcTDmNebcrotXIbULUTQfPRPSLGPvlpDHfoyCkyYPwHhsyS0W/JhVMzYo26M77ZpAWByE9YHLBX0q3SsV6lxV/vvbfeY3ccGwaWM5VCUUx/SCIYuh9ycgiqP9eQ5CIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 02B8A1007; Wed, 3 Apr 2024 02:58:59 -0700 (PDT) Received: from [10.57.73.155] (unknown [10.57.73.155]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F05E63F64C; Wed, 3 Apr 2024 02:58:26 -0700 (PDT) Message-ID: <6d90b034-b91a-4e33-b728-b86261c050b0@arm.com> Date: Wed, 3 Apr 2024 10:58:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: remove redundant 'extern' Content-Language: en-GB To: Mark Rutland Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240327112439.200455-1-steven.price@arm.com> From: Steven Price In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02/04/2024 11:01, Mark Rutland wrote: > On Wed, Mar 27, 2024 at 11:24:39AM +0000, Steven Price wrote: >> It isn't necessary to mark function definitions extern and goes against >> the kernel coding style. Remove the redundant extern keyword. >> >> Signed-off-by: Steven Price > > We (unfortunately) have extern misused in a number of places: > > | [mark@lakrids:~/src/linux]% git grep 'extern.*(' -- arch/arm64/include | cut -d: -f 1 | uniq -c > | 11 arch/arm64/include/asm/cacheflush.h > | 1 arch/arm64/include/asm/checksum.h > | 1 arch/arm64/include/asm/cpu_ops.h > | 4 arch/arm64/include/asm/cpufeature.h > | 2 arch/arm64/include/asm/efi.h > | 2 arch/arm64/include/asm/elf.h > | 1 arch/arm64/include/asm/exec.h > | 1 arch/arm64/include/asm/fixmap.h > | 48 arch/arm64/include/asm/fpsimd.h > | 3 arch/arm64/include/asm/ftrace.h > | 10 arch/arm64/include/asm/hugetlb.h > | 11 arch/arm64/include/asm/hw_breakpoint.h > | 6 arch/arm64/include/asm/io.h > | 4 arch/arm64/include/asm/kexec.h > | 1 arch/arm64/include/asm/kgdb.h > | 16 arch/arm64/include/asm/kvm_asm.h > | 3 arch/arm64/include/asm/kvm_host.h > | 11 arch/arm64/include/asm/kvm_hyp.h > | 2 arch/arm64/include/asm/kvm_pkvm.h > | 2 arch/arm64/include/asm/memory.h > | 8 arch/arm64/include/asm/mmu.h > | 2 arch/arm64/include/asm/page.h > | 1 arch/arm64/include/asm/percpu.h > | 2 arch/arm64/include/asm/perf_event.h > | 2 arch/arm64/include/asm/pgalloc.h > | 18 arch/arm64/include/asm/pgtable.h > | 3 arch/arm64/include/asm/pointer_auth.h > | 3 arch/arm64/include/asm/proc-fns.h > | 2 arch/arm64/include/asm/processor.h > | 3 arch/arm64/include/asm/ptrace.h > | 12 arch/arm64/include/asm/smp.h > | 1 arch/arm64/include/asm/stacktrace.h > | 14 arch/arm64/include/asm/string.h > | 2 arch/arm64/include/asm/suspend.h > | 1 arch/arm64/include/asm/system_misc.h > | 6 arch/arm64/include/asm/uaccess.h > > ... so it'd probably be best to make the commit title more specific to this > instance, and maybe go clean those up in bulk as a series to avoid a steady > stream of copycat patches. Ah, I hadn't gone looking that closely - I'll do a series updating the arch/arm64/include ones (thanks for the list ;) ), and I'll include an updated version of this patch, with a clearly commit title, in the series. Thanks, Steve > Mark. > >> --- >> arch/arm64/include/asm/fixmap.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/include/asm/fixmap.h b/arch/arm64/include/asm/fixmap.h >> index 87e307804b99..75b22b89db1a 100644 >> --- a/arch/arm64/include/asm/fixmap.h >> +++ b/arch/arm64/include/asm/fixmap.h >> @@ -107,7 +107,7 @@ void __init early_fixmap_init(void); >> #define __late_set_fixmap __set_fixmap >> #define __late_clear_fixmap(idx) __set_fixmap((idx), 0, FIXMAP_PAGE_CLEAR) >> >> -extern void __set_fixmap(enum fixed_addresses idx, phys_addr_t phys, pgprot_t prot); >> +void __set_fixmap(enum fixed_addresses idx, phys_addr_t phys, pgprot_t prot); >> >> #include >> >> -- >> 2.34.1 >> >>