From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A1653B961D for ; Wed, 25 Feb 2026 14:57:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772031449; cv=none; b=EJfY73UqAnkH0PE6JHDGpJPWo0UPRUPrvbtSQJTrQ3i8d1nP2veD4rLOwRY6Z8BF2VwjcpAfX76SIu6AimczRzexn2o2bwAlOUoQcLvJG9N5FaNjqVwx2DlLj0rfGPV8hLMb2cs8ielvmH86F1pu818MXqrbQYlarxTMqkGTomg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772031449; c=relaxed/simple; bh=3nDq6V9sMil92xFBi9eCRFNPceNL07AhmXRsNjKjL9M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N0gDnltgdPDvsugEWXtpkAz+BaHMZORt7KWpZp+LSWEtcjJLdIiEdAkPn/JklEyqgMRboPYZ6oWTWzhSPm4hCBg2iuciCW3Tj+7cqFcyJcF2fZS9D1fufoJzLrihw/DZzeKjW1fBM/19icI5dFq71jOnQVMCNYWOrqR9TCpwpzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y9Mxd5oC; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=DetyLtqt; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y9Mxd5oC"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="DetyLtqt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772031447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WOFZD4dDncjyTTf4CK7xsUk9kkt0EXLPHp2enm9+JaE=; b=Y9Mxd5oCYGuBk8LhXpkwkEIHPAXcWXRA9R0yU0OgTTXUYaT+jGgrI9/zyi0v+PfqFgXD+B B2uIKir3AC7fBn2mCgIRBtApMR4r9J1+VzQlHpmcDE15rxJagz0bc7BT9rOuV0RZ+/WIoN /UgiipPSqzyJIK+KcTwEPjDmmzieEh4= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-269-PO26RDZfPCKVD3uf2bdvDA-1; Wed, 25 Feb 2026 09:57:23 -0500 X-MC-Unique: PO26RDZfPCKVD3uf2bdvDA-1 X-Mimecast-MFC-AGG-ID: PO26RDZfPCKVD3uf2bdvDA_1772031442 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-389ebb088d5so2879601fa.0 for ; Wed, 25 Feb 2026 06:57:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772031442; x=1772636242; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WOFZD4dDncjyTTf4CK7xsUk9kkt0EXLPHp2enm9+JaE=; b=DetyLtqt17ZgNG3gI1AEf5+2z8RUgsnqAmltNnWsD6SgNdwC3ijkmWbx+8zIka1SJI wizBsVL3WFAxpnc3iHzIU0h5hdXbFfOdjWYlOyPbNeQaUcgu4F74JJg79RDYG0ZbneA4 MW4mn5HldO/RFNZaAt1DSktTs92JvnMFWi/m2EqvmAS82HIoIpwR1xT3/juf+tJkB3dS lzfIMKgzNyKi+h2llbzOM/h/OM3TslMr8Fh/zMN+yyLiPZ49g4u0xhMWBMSN3dqfNXEv PdUP+EiWpogx4HoCO+Kk99dRvYsAh8kStHsF4Xg/k5A/vj5d2gJJMkWIRMWnhvgid/wQ ID6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772031442; x=1772636242; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WOFZD4dDncjyTTf4CK7xsUk9kkt0EXLPHp2enm9+JaE=; b=hYbSaZSvb5z/p3QuoQOdu7KMKoaXW1H+7Ip66mOhyv9PC5pV85DuRA9yev3DkhC5dt j6MS7IvwtpughIaFV8vREpMYKSJ6RQR+f2E6WGEZlrQ6k1jHYKwg0MTcOTqJDNY5r+uE xI9BAYFqkvvts4IxzA5xzzVgsou+pe8toUahB8wj9Xzr1Oiq5UoZ41pUl0CBeFw8Vv0p VG80MobqehS3JcMUMZ4aKBjvN1dqFgtRKEi1rwLCXV7yoQf8XGVCkwi92PzHvodwllar tIE4cET8qQfuG9thHLCArk/bUvCdQT1aYTuEuJWhHMhRHe1fBk+yXONnK4o0LsbV30w+ +jdQ== X-Forwarded-Encrypted: i=1; AJvYcCVlU2fanz2PslszXVDEiDkmA+fSq1GNi2t1Q31uoReWt54kkjGt8hqcuZBDV6RJa1kJnuUnb408xwb3IHM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6nMbpPXm8kt887bnrSJlRO5JnL7ZbAuI6sDJuvPUHAkvch9Nj tGrhKwHJmbGDL7HWnm4Lzq6Biq5Li+TN30Yps+DP2n9uoJZ/uEBcYaXTXZXzlNgeOhDCtUtyVAF UNvWRZU12IHr5SMdMef0NtzdT+gvuWC2d9yUi7f2MrZ0nXc79mlljC5P/1HLqygA/Xw== X-Gm-Gg: ATEYQzx64IsLR6pN41bTG9TzyMnnzRcs65Pey9V+Y54RnSey4YHqEKJ5kC1YIjp/gfw kGYXNrcgKpkEibLiHfOrYWAq/wKcSRKAI9z8e3GVEm90QDXUEUQxNQocQcSOWg2bTK5YIjOEk7t FfLWgJyEqFCPId6Z4DZYVv6UNge35h5RQP+GPW9CHzdRaH/WW8WB6s6u/OtcW03hGlVd6ngeH22 EcdPlSpDqQXXxlqHDNHsN8toWO7lau8knoeUNq+nSiFlTFbBVcQvNSEJnoavd6nwDVVdGOZ4Wy/ cb6k4gH7v7WvnZ6PLp6JcIx2ZglpUnrryNuSgpJm0SPNn95B/KQ1jdJUVKTQ2buIYYuUhhhZTW2 ZV0l2VQOt8T1eF5aJlvTK X-Received: by 2002:a05:651c:1581:b0:387:799:17f8 with SMTP id 38308e7fff4ca-389a5d4e7f8mr51094551fa.16.1772031442088; Wed, 25 Feb 2026 06:57:22 -0800 (PST) X-Received: by 2002:a05:651c:1581:b0:387:799:17f8 with SMTP id 38308e7fff4ca-389a5d4e7f8mr51094491fa.16.1772031441579; Wed, 25 Feb 2026 06:57:21 -0800 (PST) Received: from [192.168.2.83] ([46.175.183.46]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-389a770ecb7sm30766031fa.0.2026.02.25.06.57.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Feb 2026 06:57:20 -0800 (PST) Message-ID: <6d93637e-cc59-45e5-9365-8140f53e4004@redhat.com> Date: Wed, 25 Feb 2026 15:57:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-wired-lan] [PATCH iwl-net] iavf: fix VLAN filter lost on add/delete race To: Michal Schmidt Cc: netdev@vger.kernel.org, Przemek Kitszel , Eric Dumazet , Ahmed Zaki , Andrew Lunn , Tony Nguyen , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" , linux-kernel@vger.kernel.org References: <20260225100137.383527-1-poros@redhat.com> Content-Language: en-US From: Petr Oros In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/25/26 12:17, Michal Schmidt wrote: > On Wed, Feb 25, 2026 at 11:02 AM Petr Oros wrote: >> When iavf_add_vlan() finds an existing filter in IAVF_VLAN_REMOVE >> state, it transitions the filter to IAVF_VLAN_ACTIVE assuming the >> pending delete can simply be cancelled. However, there is no guarantee >> that iavf_del_vlans() has not already processed the delete AQ request >> and removed the filter from the PF. In that case the filter remains in >> the driver's list as IAVF_VLAN_ACTIVE but is no longer programmed on >> the NIC. Since iavf_add_vlans() only picks up filters in >> IAVF_VLAN_ADD state, the filter is never re-added, and spoof checking >> drops all traffic for that VLAN. >> >> CPU0 CPU1 Workqueue >> ---- ---- --------- >> iavf_del_vlan(vlan 100) >> f->state = REMOVE >> schedule AQ_DEL_VLAN >> iavf_add_vlan(vlan 100) >> f->state = ACTIVE >> iavf_del_vlans() >> f is ACTIVE, skip >> iavf_add_vlans() >> f is ACTIVE, skip >> >> Filter is ACTIVE in driver but absent from NIC. > I don't get it. If, as the diagram shows, iavf_del_vlans() skipped it, > then how does the filter become absent from NIC? VLAN teardown Workqueue VLAN setup ------------- --------- ---------- iavf_del_vlan(100) f->state = REMOVE schedule AQ_DEL_VLAN iavf_open() restore_filters() f is REMOVE, skip iavf_add_vlan(100) f->state = ACTIVE iavf_del_vlans() f is ACTIVE, skip iavf_add_vlans() f is ACTIVE, skip Is it clear like this? > Michal > >> Transition to IAVF_VLAN_ADD instead and schedule >> IAVF_FLAG_AQ_ADD_VLAN_FILTER so iavf_add_vlans() re-programs the >> filter. A duplicate add is idempotent on the PF. >> >> Fixes: 0c0da0e95105 ("iavf: refactor VLAN filter states") >> >> Signed-off-by: Petr Oros >> --- >> drivers/net/ethernet/intel/iavf/iavf_main.c | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c >> index 4b0fc8f354bc90..6046b93c7f3472 100644 >> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c >> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c >> @@ -782,10 +782,13 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter *adapter, >> adapter->num_vlan_filters++; >> iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_VLAN_FILTER); >> } else if (f->state == IAVF_VLAN_REMOVE) { >> - /* IAVF_VLAN_REMOVE means that VLAN wasn't yet removed. >> - * We can safely only change the state here. >> + /* Re-add the filter since we cannot tell whether the >> + * pending delete has already been processed by the PF. >> + * A duplicate add is harmless. >> */ >> - f->state = IAVF_VLAN_ACTIVE; >> + f->state = IAVF_VLAN_ADD; >> + iavf_schedule_aq_request(adapter, >> + IAVF_FLAG_AQ_ADD_VLAN_FILTER); >> } >> >> clearout: >> -- >> 2.52.0 >>