From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3609F33D6ED for ; Fri, 31 Jul 2026 20:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785530048; cv=none; b=aeK+cYIE8cBecWhs1EoXkM/sebxUHo4pVfCk2LgLTu3h31v+i/P1XEg6rap7lWz9GexMTuG6wv9/yghPGN/saaUk4cp9TDzTDemzqR+4gg+RvO2VqTwGlpYvyQ4u8sWAKZv7QsESDb+wpDk5wV33E7vWM1V+CAGbjLuO1pTgK4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785530048; c=relaxed/simple; bh=NXZDspMbrOv5vkONMoM2L5ggiE2EAR+AQYiQEdJNcHo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fZxvxlpLFst8Nhwz8BuH6ffU/9YYe/lxuCm4Gj249TTqsN3lLDWZwTPCqN42nLHmyMrnuuaAfYS4F5TuhJC2kAnbMgz1nMxBhvxIx80ssb9exOoYZzDsVGtotW7jmpSPB2ICNmoFE+6YRPNGDNhZmfSAZDQQMVsOyHP+0o9P/Jw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=reactivated.net; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=reactivated.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47de008b020so1045918f8f.1 for ; Fri, 31 Jul 2026 13:34:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785530045; x=1786134845; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Se3TlLpuysYiEG2DYm26v81iW1ITt60yQ73LdmliEgA=; b=QzBHinoKX+CTh6yvx/EeL8VvXaVdg6StbHPy+HgB3sMeSNVO2yXAxNvSHpxVJN3y5I 1mMpFhsQ6I/vtD4+l1rCaa06v74h+KR9nkj9r0N+dUCL++i9k37cO3KAQgbzzYCIgU+w EUegANsGK/SFyKE1og5q23OvyTbOxBShfqd4qmcH8fPf/IhWUrSU0whFFZX1d3W3gSBm vJ8Uq2klXEM+Zkiwc+BjmI0ixZ41eKULIDvu2c+CKh+TNeqrIAVYKJQZgNMXAeIfqa7r bxYEPwvJiML8gkgySL8KCt9NWsal2BygEqOXWR8VxRFwP08bVxiHGEaPwGno9+kXAuti FdOw== X-Forwarded-Encrypted: i=1; AHgh+RqWPjUBLo594WN82hjslDxh+tpzD/PY2/4fay6XsaMG2vAQ9Z6guT07glmUQuHo6MjsF65QxtcWIdyqZlI=@vger.kernel.org X-Gm-Message-State: AOJu0YyY578umOq4awCkGtNplznRO54b0+vW8QqzPlldGFQ+Md1Qkp9D f7TGtrrkxV2sGclXet563JfSU0YssjbTrXrvHnCGL+FtsFZ4HtITjLHxrcvxDEuv X-Gm-Gg: AR+sD13wsdHWYBN58z35Q2SWn6d/lGEu+HWg8RPJNmIEkXWg78r19BwKZLHGWWOG4JX NXLMgbwp9XDKjhuXvONI++tGbq/n48TZi91oDiK4P16yGbuzR8P6UqCYTVrPw+mIzvrLPblPmrZ /dCY4uERBOczRzDKCd8VNS8p+5CBWFvtsUZERsDnY4WdtUMeD5/NaKJ3yKcckPQrEFoBfInByAG YU4xAfKSmoMxW2mlG5DzZmEvmcaEPbQAek3/uFcO89994BM/Lyp+AZo3ZxuGAXJeazDnylAxgqg UYEzxItHcmSs7i0Or6frV6DFJJ9s4YApvSdcL6iOk+BMF7MgdPv0HQ93jlAEDTa6pbOND6IuIyt gLmWGsYN1swKIMldshuuj5C6Hw6IUbb347gM4XHBh/5IaJpskDzMqqo/rz8Y935Ri/Ls1VoPLZj Fbwc0XvPY/WhFt4q3rz245tMHEgIXJZqcF8GI9M5W4qtnmiKnW24U1vN5QDf45PcmGCSQ6sAAOL kQm2EKPF8XT2hCD78JvkGkeWRq7Ned9l6oZ84ch0u//+gfV77Cahacc9X75i9mMpTuV X-Received: by 2002:a05:6000:1846:b0:47f:6e8b:699c with SMTP id ffacd0b85a97d-47fd729208fmr2040027f8f.14.1785530045266; Fri, 31 Jul 2026 13:34:05 -0700 (PDT) Received: from ?IPV6:2001:8a0:d6cd:9000:86f4:4e71:9fc8:3183? ([2001:8a0:d6cd:9000:86f4:4e71:9fc8:3183]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd456a6d7sm9618856f8f.19.2026.07.31.13.34.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 13:34:04 -0700 (PDT) Message-ID: <6d9b28ec-0905-4cb0-9a62-980c7fa69572@reactivated.net> Date: Fri, 31 Jul 2026 21:34:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] iommu: Add Broadcom BCM2712 IOMMU driver To: Krzysztof Kozlowski Cc: "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, nick.hollinghurst@raspberrypi.com, Jason Gunthorpe References: <20260727-bcm2712-iommu-submit-v2-0-0247b5c03de8@reactivated.net> <20260727-bcm2712-iommu-submit-v2-4-0247b5c03de8@reactivated.net> <20260730-small-solid-spoonbill-8a8bbd@quoll> Content-Language: en-US From: Daniel Drake In-Reply-To: <20260730-small-solid-spoonbill-8a8bbd@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/07/2026 08:00, Krzysztof Kozlowski wrote: > On Mon, Jul 27, 2026 at 09:43:59PM +0100, Daniel Drake wrote: >> +static int bcm2712_iommu_init_cache(struct bcm2712_iommu *mmu, >> + struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + struct platform_device *cache_pdev; >> + struct device_node *cache_np; >> + >> + cache_np = of_parse_phandle(dev->of_node, "brcm,iommu-cache", 0); >> + >> + /* Fall back on 'cache' property used in old/downstream firmware */ >> + if (!cache_np) >> + cache_np = of_parse_phandle(dev->of_node, "cache", 0); > > NAK. > > You cannot have undocumented ABI. I asked you to drop this at v1. Is there any approach I should consider here in order to support existing shipped firmware versions that use the 'cache' property, or should I simply break compatibility? While I was working on another issue recently there was a lean towards supporting existing/wrong DTs at the end of https://lore.kernel.org/all/878q898ulx.wl-maz@kernel.org/ but admittedly that case has some different parameters: it was incorrect DT values (not incorrect ABI) and also was more severe (breaks boot). In this case if the system were to boot without iommu support it is not the end of the world. Thanks, Daniel