From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C61C1C433FE for ; Mon, 17 Oct 2022 22:12:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230153AbiJQWMg (ORCPT ); Mon, 17 Oct 2022 18:12:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230148AbiJQWMd (ORCPT ); Mon, 17 Oct 2022 18:12:33 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AC976CF40 for ; Mon, 17 Oct 2022 15:12:31 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id z30so7584690qkz.13 for ; Mon, 17 Oct 2022 15:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1OJf4F+JKFppB/W0S0nhFbRnIAx64pBVeYTRLpixwyE=; b=vX8e52AS+9MDUc9S8uNK4Q0XQGHn9O4xlkEdlvHntcs+g2y4f70q49YdgSGtiFoFM3 lJC6cZI3uOD/EtcwCjVl2b9OoCpxTGNR5RfDUxxA1vRMw9dtMaxyxF0jX3PuHXaoP6Jv zu3SxnPesLcdlfBy55n+vZUhizHwOiDGBagH3yMBFxbS7hvVoMZRmR5EyGBxVDN/K95Z lshiQdabI3kle6iu6uMJlhvVv5f8Y3SwIaY5gmocf0oUeS9054pkpkgaed64hT/gP4jO /kj0NfTQ6Gu1elluEP6rsVIIAv176mh8jIF8DeHJcmba+TSpCu/I8C9kPrzdjUghCx3a Oeag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1OJf4F+JKFppB/W0S0nhFbRnIAx64pBVeYTRLpixwyE=; b=TxCLJk00gv9BVdQz3vNmGOHxMAwwePn2yXQCg/atBxJxYFE/X8p97GZoe1e+2OU7bk VSMpg9kFc2PrzJvhHvA+Ro5eYwFeRn/61FYquSVjoiMP0caYXSV8tkVk5FZ93Q2FprmD sxkja1/BpgXKDt0y7yXRIkbojL4iYT0MUGsz1eTBkib+R3S/M1FZVm8T8frzAGNmCqQf bumbPS2HZLH3kCCwEuLH7VVKgGA9QLmLsSrodSMgu058hGOBECpt/FUGcNOEJ6IKMEeD /PwYpgv3jv3dHgUfjqRTHADz2sKJqg/t9g7bUYNZEaw5jv9A11VaDaF7WnEjumzLbFlG KXcg== X-Gm-Message-State: ACrzQf0hs/IoFfY6D5QhtG4VXyzog/6FsO13+XI7HMV/OUAKLV8C1lLV ROXPzJ/fJXP3uhGHl62FoJqpaQ== X-Google-Smtp-Source: AMsMyM4GKqAMJAAvwwgEdE6t9HOW5Z4eFfI2/AeOZaIj9u0+aquUf93vI+CcZOvQas4C2sEkS22rCQ== X-Received: by 2002:a05:620a:1293:b0:6ee:dfb8:d448 with SMTP id w19-20020a05620a129300b006eedfb8d448mr6588764qki.510.1666044750690; Mon, 17 Oct 2022 15:12:30 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id r17-20020ac87951000000b0039cb9ef50b5sm672321qtt.26.2022.10.17.15.12.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Oct 2022 15:12:29 -0700 (PDT) Message-ID: <6d9df544-b99e-4d62-53d1-1f3290d31a19@linaro.org> Date: Mon, 17 Oct 2022 18:12:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 2/5] dmaengine: qcom: gpi: document preferred SM6350 binding Content-Language: en-US To: Richard Acayan , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Melody Olvera References: <20221015140447.55221-1-krzysztof.kozlowski@linaro.org> <20221015140447.55221-3-krzysztof.kozlowski@linaro.org> <20221017212320.4960-1-mailingradian@gmail.com> <801c902d-4e1a-6ddc-e050-afdc2514e687@linaro.org> <20221017220004.6234-1-mailingradian@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20221017220004.6234-1-mailingradian@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/10/2022 18:00, Richard Acayan wrote: >> On 17/10/2022 17:23, Richard Acayan wrote: >>>> Devices with ee offset of 0x10000 should rather bind with SM6350 >>>> compatible, so the list will not unnecessarily grow for compatible >>>> devices. >>>> >>>> Signed-off-by: Krzysztof Kozlowski >>>> --- >>>> drivers/dma/qcom/gpi.c | 7 ++++--- >>>> 1 file changed, 4 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c >>>> index f8e19e6e6117..061add832295 100644 >>>> --- a/drivers/dma/qcom/gpi.c >>>> +++ b/drivers/dma/qcom/gpi.c >>>> @@ -2286,13 +2286,14 @@ static int gpi_probe(struct platform_device *pdev) >>>> } >>>> >>>> static const struct of_device_id gpi_of_match[] = { >>>> - { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, >>>> { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, >>>> { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 }, >>>> /* >>>> - * Deprecated, devices with ee_offset = 0 should use sdm845-gpi-dma as >>>> - * fallback and not need their own entries here. >>> >>> This comment is from the dependency series [1]. Why would we need to add it just >>> to remove it here? I was not notified that the dependency was applied anywhere >>> (except as a base for other series) so it's not set in stone. Let's just drop >>> the original patch that this comment originates from to prevent needlessly >>> adding and removing the same lines at once. >> >> I don't remove the comment, I re-phrase it to be better suited for final >> code. > > Yes, I didn't word that exactly right. I still think the patch that adds this is > now useless if it's just going to be replaced. Do you think I should keep the > patch that this comment originates from, even though we already know exactly how > its substantial contents will be replaced? > > We can't modify history and drop commits on kernel trees, but I can still send > a v6 series that drops the original comment. Sure. You can make it then: * Do not grow the list for compatible devices. Instead use * qcom,sdm845-gpi-dma (for ee_offset = 0x0). And my patch will just change one line. We can also keep it like: * Do not grow the list for compatible devices. Instead use * proper fallback compatibles. Best regards, Krzysztof