From: Andrew Lunn <andrew@lunn.ch>
To: Ninad Palsule <ninad@linux.ibm.com>
Cc: minyard@acm.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
ratbert@faraday-tech.com,
openipmi-developer@lists.sourceforge.net, netdev@vger.kernel.org,
joel@jms.id.au, andrew@codeconstruct.com.au,
devicetree@vger.kernel.org, eajames@linux.ibm.com,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/10] ARM: dts: aspeed: system1: Add RGMII support
Date: Tue, 7 Jan 2025 18:56:24 +0100 [thread overview]
Message-ID: <6d9ea6f5-4ff5-40ed-b470-e40c1f6a5982@lunn.ch> (raw)
In-Reply-To: <20250107162350.1281165-6-ninad@linux.ibm.com>
On Tue, Jan 07, 2025 at 10:23:42AM -0600, Ninad Palsule wrote:
> system1 has 2 transceiver connected through the RGMII interfaces. Added
> device tree entry to enable RGMII support.
>
> ASPEED AST2600 documentation recommends using 'rgmii-rxid' as a
> 'phy-mode' for mac0 and mac1 to enable the RX interface delay from the
> PHY chip.
Why?
Does the mac0 TX clock have an extra long clock line on the PCB?
Does the mac1 TX and RX clocks have extra long clock lines on the PCB?
Anything but rgmii-id is in most cases wrong, so you need a really
good explanation why you need to use something else. Something that
shows you understand what is going on, and why what you have is
correct.
Andrew
next prev parent reply other threads:[~2025-01-07 17:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 16:23 [PATCH v2 00/10] DTS updates for system1 BMC Ninad Palsule
2025-01-07 16:23 ` [PATCH v2 01/10] dt-bindings: net: faraday,ftgmac100: Add phys mode Ninad Palsule
2025-01-07 16:23 ` [PATCH v2 02/10] bindings: ipmi: Add binding for IPMB device intf Ninad Palsule
2025-01-07 18:22 ` Rob Herring (Arm)
2025-01-07 23:13 ` Rob Herring
2025-01-08 16:40 ` Ninad Palsule
2025-01-07 16:23 ` [PATCH v2 03/10] ARM: dts: aspeed: system1: Add IPMB device Ninad Palsule
2025-01-07 16:23 ` [PATCH v2 04/10] ARM: dts: aspeed: system1: Add GPIO line name Ninad Palsule
2025-01-07 16:23 ` [PATCH v2 05/10] ARM: dts: aspeed: system1: Add RGMII support Ninad Palsule
2025-01-07 17:56 ` Andrew Lunn [this message]
2025-01-07 16:23 ` [PATCH v2 06/10] ARM: dts: aspeed: system1: Reduce sgpio speed Ninad Palsule
2025-01-07 16:23 ` [PATCH v2 07/10] ARM: dts: aspeed: system1: Update LED gpio name Ninad Palsule
2025-01-07 16:23 ` [PATCH v2 08/10] ARM: dts: aspeed: system1: Remove VRs max8952 Ninad Palsule
2025-01-07 16:23 ` [PATCH v2 09/10] ARM: dts: aspeed: system1: Mark GPIO line high/low Ninad Palsule
2025-01-07 16:23 ` [PATCH v2 10/10] ARM: dts: aspeed: system1: Disable gpio pull down Ninad Palsule
2025-01-07 22:54 ` [PATCH v2 00/10] DTS updates for system1 BMC Rob Herring (Arm)
2025-01-08 3:54 [PATCH v2 05/10] ARM: dts: aspeed: system1: Add RGMII support Jacky Chou
2025-01-08 17:52 ` Andrew Lunn
2025-01-08 19:14 ` Ninad Palsule
2025-01-08 20:17 ` Andrew Lunn
2025-01-08 22:31 ` Ninad Palsule
2025-01-08 23:08 ` Andrew Lunn
2025-01-09 14:32 ` Ninad Palsule
2025-01-09 14:48 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d9ea6f5-4ff5-40ed-b470-e40c1f6a5982@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=edumazet@google.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=netdev@vger.kernel.org \
--cc=ninad@linux.ibm.com \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=pabeni@redhat.com \
--cc=ratbert@faraday-tech.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®