mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Timur Tabi <ttabi@nvidia.com>
To: Alexandre Courbot <acourbot@nvidia.com>,
	"dakr@kernel.org" <dakr@kernel.org>,
	"aliceryhl@google.com" <aliceryhl@google.com>,
	"airlied@gmail.com" <airlied@gmail.com>,
	"simona@ffwll.ch" <simona@ffwll.ch>
Cc: Alistair Popple <apopple@nvidia.com>,
	John Hubbard <jhubbard@nvidia.com>, Edwin Peer <epeer@nvidia.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
	Joel Fernandes <joelagnelf@nvidia.com>
Subject: Re: [PATCH 7/9] gpu: nova-core: firmware: fwsec: do not require bound device when unneeded
Date: Mon, 8 Dec 2025 16:18:07 +0000	[thread overview]
Message-ID: <6da7ff0ff31c1f4250b8d6cd1b535bd69322d0c9.camel@nvidia.com> (raw)
In-Reply-To: <20251208-nova-misc-v1-7-a3ce01376169@nvidia.com>

On Mon, 2025-12-08 at 18:26 +0900, Alexandre Courbot wrote:
>      /// Loads the FWSEC firmware into `falcon` and execute it.
> -    pub(crate) fn run(
> -        &self,
> -        dev: &Device<device::Bound>,
> -        falcon: &Falcon<Gsp>,
> -        bar: &Bar0,
> -    ) -> Result<()> {
> +    pub(crate) fn run(&self, dev: &Device, falcon: &Falcon<Gsp>, bar: &Bar0) -> Result<()> {

I frequently see patches that, when they change the function signature, rearrange the parameters
from one line to multiple lines.  Here, you are doing the opposite.  Not only that, but it seems
unnecessary because you're actually just changing one parameter, so you should only be replacing
one line.

It seems to me that some people have their editors configured to prefer one line, and others
have their editor configured to prefer multiple lines, so whenever there's a signature change,
we get diffs like this.


  reply	other threads:[~2025-12-08 16:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08  9:26 [PATCH 0/9] gpu: nova-core: miscellaneous improvements Alexandre Courbot
2025-12-08  9:26 ` [PATCH 1/9] gpu: nova-core: gsp: warn if data remains after processing a message Alexandre Courbot
2025-12-11 21:59   ` lyude
2025-12-08  9:26 ` [PATCH 2/9] gpu: nova-core: gsp: remove unnecessary Display impls Alexandre Courbot
2025-12-09  1:26   ` Alistair Popple
2025-12-11 22:02   ` lyude
2025-12-08  9:26 ` [PATCH 3/9] gpu: nova-core: gsp: simplify sequencer opcode parsing Alexandre Courbot
2025-12-11 22:04   ` lyude
2025-12-08  9:26 ` [PATCH 4/9] gpu: nova-core: gsp: remove unneeded sequencer trait Alexandre Courbot
2025-12-11 22:06   ` lyude
2025-12-08  9:26 ` [PATCH 5/9] gpu: nova-core: gsp: derive `Debug` on more sequencer types Alexandre Courbot
2025-12-11 22:06   ` lyude
2025-12-08  9:26 ` [PATCH 6/9] gpu: nova-core: gsp: derive Zeroable for GspStaticConfigInfo Alexandre Courbot
2025-12-11 22:07   ` lyude
2025-12-08  9:26 ` [PATCH 7/9] gpu: nova-core: firmware: fwsec: do not require bound device when unneeded Alexandre Courbot
2025-12-08 16:18   ` Timur Tabi [this message]
2025-12-08 16:51     ` John Hubbard
2025-12-08 17:55       ` Timur Tabi
2025-12-09  2:30         ` Alexandre Courbot
2025-12-11 22:08   ` lyude
2025-12-08  9:27 ` [PATCH 8/9] gpu: nova-core: use core library's CStr instead of kernel one Alexandre Courbot
2025-12-11 22:09   ` lyude
2025-12-08  9:27 ` [PATCH 9/9] gpu: nova-core: simplify str_from_null_terminated Alexandre Courbot
2025-12-11 22:10   ` lyude

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6da7ff0ff31c1f4250b8d6cd1b535bd69322d0c9.camel@nvidia.com \
    --to=ttabi@nvidia.com \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=epeer@nvidia.com \
    --cc=jhubbard@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®