From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m49243.qiye.163.com (mail-m49243.qiye.163.com [45.254.49.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FC2E194098; Mon, 19 May 2025 08:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.243 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747645184; cv=none; b=QYkfLu2+KAhloTtGirWPCwlH6WP/CKXV4X1QuNQA6WcpQIBER69QeMs70atoVJSrV1XRYGB2JodNjkB9xYzvC4i5KVC4CLcc5oAw5VxbgHC6BG7DjspU0nrTN1FrawixlukzEiTNFkrUyLJQ9mLx2KYwDP7Gp4LHoUo4hloXBL8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747645184; c=relaxed/simple; bh=UEBlw8vboLiO7dN2wOjs6AQukQENUwMD9NDOlANOesQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gNWZH3vtcqVYz2xpwpGyL+CRwj9/ZiimVW2C/Iq15UMNN5iHffvBihQirB6VmMxv6ZoBFOTHTCS1JagKTPBnSm6/rgpqgYSbSGQcfatrvBMKo041u3bHNDRSviddHItq1pMC7RHudGU31HyuN4Xp/6WVG5p8SSjbTxryTxkddtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=ZPU7PwL+; arc=none smtp.client-ip=45.254.49.243 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="ZPU7PwL+" Received: from [127.0.0.1] (gy-adaptive-ssl-proxy-2-entmail-virt205.gy.ntes [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 158ccae3f; Mon, 19 May 2025 16:44:14 +0800 (GMT+08:00) Message-ID: <6dac10df-d410-4d52-8711-4c8046f90fbd@rock-chips.com> Date: Mon, 19 May 2025 16:43:48 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml To: Krzysztof Kozlowski Cc: Chaoyi Chen , Sandy Huang , Heiko Stuebner , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dragan Simic , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250519012632.94-1-kernel@airkyi.com> <20250519012632.94-3-kernel@airkyi.com> <20a565da-296c-4920-b962-e9de9af464d9@kernel.org> <632f9f4d-ec0f-4512-a153-d2abfd9f6841@rock-chips.com> <20250519-tall-glistening-quokka-9ffa6f@kuoka> From: Chaoyi Chen In-Reply-To: <20250519-tall-glistening-quokka-9ffa6f@kuoka> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGkMeT1ZLThpIHxhJHkgdTUpWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ X-HM-Tid: 0a96e7b7094a03aekunm158ccae3f X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OCo6HSo5LjExDC0zLio4FRhI STMwCS5VSlVKTE9MTU9PSU1KSEpDVTMWGhIXVRgTGhQCElUYEx4VOwkUGBBWGBMSCwhVGBQWRVlX WRILWUFZTkNVSUlVTFVKSk9ZV1kIAVlBT0pOTzcG DKIM-Signature:a=rsa-sha256; b=ZPU7PwL+nAfueycpdY2yJue2tLZTRMoaiSKoIlGm+G9Xi5nboCuoO35Wc21TaIz7dmKHezIH5NNK7VX/AwNFNGs4VT9yz1RQ8ILaIY3w7ZNE2aSZPqay6utDnKSNSgECauwziW8cxvAKh6tB/lrJCpw5w5MseqaRQIiz8er641o=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=UN9mV4Ay8ghFsuFemLHGgtg/VXgBJG+F9kHs6DqrncA=; h=date:mime-version:subject:message-id:from; Hi Krzysztof, On 2025/5/19 16:23, Krzysztof Kozlowski wrote: > On Mon, May 19, 2025 at 02:56:03PM GMT, Chaoyi Chen wrote: >> Hi Krzysztof, >> >> On 2025/5/19 14:16, Krzysztof Kozlowski wrote: >>> On 19/05/2025 03:26, Chaoyi Chen wrote: >>>> +maintainers: >>>> + - Andy Yan >>>> + - Heiko Stuebner >>>> + - Sandy Huang >>>> + >>>> +allOf: >>>> + - $ref: /schemas/sound/dai-common.yaml# >>>> + >>>> +properties: >>>> + compatible: >>>> + items: >>>> + - const: rockchip,rk3399-cdn-dp >>>> + >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + clocks: >>>> + items: >>>> + - description: DP core work clock >>>> + - description: APB clock >>>> + - description: SPDIF interface clock >>>> + - description: GRF clock >>>> + >>>> + clock-names: >>>> + items: >>>> + - const: core-clk >>>> + - const: pclk >>>> + - const: spdif >>>> + - const: grf >>>> + >>>> + extcon: >>>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>>> + items: >>>> + maxItems: 1 >>>> + maxItems: 2 >>> Instead of this, list the items. Old binding said only "specifier", so >>> this is technically a change, which should be explained in commit msg. >> Will fix in v5. >> >> >>>> + description: >>>> + List of phandle to the extcon device providing the cable state for the DP PHY. >>>> + >>>> + interrupts: >>>> + maxItems: 1 >>>> + >>>> + phys: >>>> + items: >>>> + maxItems: 1 >>>> + maxItems: 2 >>>> + description: | >>>> + List of phandle to the PHY device for DP output. >>>> + RK3399 have two DP-TPYEC PHY, specifying one PHY which want to use, >>>> + or specify two PHYs here to let the driver determine which PHY to use. >>> You do not allow one phy, so your description is not accurate. OTOH, >>> original binding did not allow two phandles, so that's another change in >>> the binding. You need to document all changes done to the binding in the >>> commit msg. >> Oh, the original binding example use two phandles. I think only one PHY can > Example is not the binding, just an example. > >> also pass the dtb check here, or maybe I'm missing something else? > You think or you tested it? What is the minItems value? 2, so even if > this works it's rather a bug in dtschema. Yes I tested it. Both of "phys = <&tcphy0_dp>", "phys = <&tcphy0_dp>, <&tcphy1_dp>" pass the dtb check. > > Also, inner maxItems:1 is not really correct. Why can't this work with > different phy providers? I'll see what other bindings do. Thanks for the clarification!