From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S936473AbcHJSiH (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Aug 2016 14:38:07 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:12288 "EHLO
	mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752856AbcHJSiD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Aug 2016 14:38:03 -0400
X-AuditID: cbfec7f5-f792a6d000001302-80-57aae55c4ef7
Subject: Re: [PATCH] max17042_battery: fix model download bug.
To: Sebastian Reichel <sre@kernel.org>,
        Sven Van Asbroeck <thesven73@gmail.com>
References: <CAGngYiVv=+RKDcuwqPxyg5GpU6iCBkuR2v7EFmnDM3Xf+w0b_g@mail.gmail.com>
 <20160809185429.GB19946@earth>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        Jonghwa Lee <jonghwa3.lee@samsung.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
X-Enigmail-Draft-Status: N1110
Message-id: <6db1eb24-d659-e424-9da7-39cabd6ad5ee@samsung.com>
Date: Wed, 10 Aug 2016 10:27:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-version: 1.0
In-reply-to: <20160809185429.GB19946@earth>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsVy+t/xq7oxT1eFG3Qe07d4/W86i0Xn2SfM
	Fq9fGFpc3jWHzeJz7xFGi9O7Sywe3r7J4sDusXPWXXaPTas62Tw+Pr3F4tG3ZRWjx+dNcgGs
	UVw2Kak5mWWpRfp2CVwZk8/cYCrYwV5xs1+qgbGdrYuRk0NCwETiwKvXTBC2mMSFe+uB4lwc
	QgJLGSXmtHSCJYQEnjFKfHtQC2ILC9hJHF35A6xZRMBfYteqpewQNcUSb2ZdZQZpZhaYwChx
	ovsmWDObgLHE5uVLoLbJSfR2T2IBsXmBBr04dxesmUVAVaLj2TNWEFtUIELi1qqPjBA1ghI/
	Jt8Dq+cU0JbY9uQi0EwOoAV6EvcvaoGEmQXkJTavecs8gVFwFpKOWQhVs5BULWBkXsUomlqa
	XFCclJ5rpFecmFtcmpeul5yfu4kREvRfdzAuPWZ1iFGAg1GJh3cD06pwIdbEsuLK3EOMEhzM
	SiK8+x4BhXhTEiurUovy44tKc1KLDzFKc7AoifPO3PU+REggPbEkNTs1tSC1CCbLxMEJDPHd
	ubfyJ/xcKvz69b65nfUPIidacQhHZQgbJzO+/9b9JGD2xGNlenHsisYxPqV7nEssV3eyPfJo
	Drec+WsZ76/fj6YbfXzZcLfvvN2x0BPyLrIrO8xn+qhmrLt4fiHXtzDzV0Uvl96NfJ11mUHd
	4evhCfVOS1101bmCz+/Yp++pLWK0RCF+JZsSS3FGoqEWc1FxIgBD6YE5dgIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/09/2016 08:54 PM, Sebastian Reichel wrote:
> Hi,
> 
> [adding some people to CC]
> 
> On Wed, Aug 03, 2016 at 10:03:46AM -0400, Sven Van Asbroeck wrote:
>> The device's model download function returns the model data as
>> an array of u32s, which is later compared to the reference
>> model data. However, since the latter is an array of u16s,
>> the comparison does not happen correctly, and model verification
>> fails. This in turn breaks the POR initialization sequence.
> 
> Patch looks ok, except for missing Fixes. I guess it should be
> "Fixes: 39e7213edc4f3". I will wait with queuing it for a few
> days giving Samsung people a chance to reply.

Looks correct.
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Also:
Cc: <stable@vger.kernel.org>

And how about:
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
https://www.marc.info/?l=linux-pm&m=143954612610000&w=4

Best regards,
Krzysztof