From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85C41C433DF for ; Tue, 21 Jul 2020 16:27:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69C6B20771 for ; Tue, 21 Jul 2020 16:27:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730101AbgGUQ13 (ORCPT ); Tue, 21 Jul 2020 12:27:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:39704 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727115AbgGUQ12 (ORCPT ); Tue, 21 Jul 2020 12:27:28 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CD59EAD79; Tue, 21 Jul 2020 16:27:33 +0000 (UTC) Message-ID: <6db722947546221ed99d3f473f78e1a6de65d7d6.camel@suse.de> Subject: Re: [PATCH] dma-pool: Do not allocate pool memory from CMA From: Nicolas Saenz Julienne To: Amit Pundir Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , David Rientjes , linux-rpi-kernel@lists.infradead.org, jeremy.linton@arm.com, iommu@lists.linux-foundation.org, lkml , John Stultz , Sumit Semwal Date: Tue, 21 Jul 2020 18:27:24 +0200 In-Reply-To: References: <20200708164936.9340-1-nsaenzjulienne@suse.de> <550b30a86c0785049d24c945e2c6628d491cee3a.camel@suse.de> <011994f8a717a00dcd9ed7682a1ddeb421c2c43f.camel@suse.de> <01831596e4a2a6c9c066138b23bd30435f8e5569.camel@suse.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-07-21 at 20:52 +0530, Amit Pundir wrote: [...] > > > > Can you try booting *without* my patch and this in the kernel > > > > command > > > > line: "cma=16M@0x100000000-0x200000000". > > > > > > It doesn't boot with this added kernel command line. > > > > For the record, this placed the CMA in the [4GB, 8GB] address space > > instead of you setup's default: [3GB, 4GB]. All atomic pools fall > > in > > that memory area without my patch, which makes me think some of the > > devices on your board might not like higher addresses. > > > > Thank you Nicolas for the details. Though we don't set the CMA > alloc-ranges explicitly in upstream sdm845 dts, but I dug around and > found that CMA alloc-ranges in the downstream kernel are indeed in > lower address space. > https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/dipper-q-oss/arch/arm64/boot/dts/qcom/sdm845.dtsi#L662 > > /* global autoconfigured region for contiguous allocations */ > linux,cma { > compatible = "shared-dma-pool"; > alloc-ranges = <0 0x00000000 0 0xffffffff>; > reusable; > alignment = <0 0x400000>; > size = <0 0x2000000>; > linux,cma-default; > }; Pretty standard, and similar to what it's being used upstream by default. > > > What happens if you boot with my troublesome patch with this in > > your > > device tree? (insert it at the bottom of sdm845-beryllium.dts) > > > > &soc { > > dma-ranges = <0 0 0 0 0x1 0>; > > }; > > > > Device still doesn't boot up to adb shell. Let's get a bigger hammer, I'm just looking for clues here. Can you apply this and provide the dmesg output. diff --git a/kernel/dma/pool.c b/kernel/dma/pool.c index 6bc74a2d5127..2160676bf488 100644 --- a/kernel/dma/pool.c +++ b/kernel/dma/pool.c @@ -268,6 +268,8 @@ void *dma_alloc_from_pool(struct device *dev, size_t size, schedule_work(&atomic_pool_work); } + dev_info(dev, "%s: size %lx, phys addr %llx, flags 0x%x\n", __func__, size, phys, flags); + return ptr; } Regards, Nicolas