From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ACC2C282C2 for ; Wed, 13 Feb 2019 18:02:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F25F9222B6 for ; Wed, 13 Feb 2019 18:02:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393582AbfBMSCi (ORCPT ); Wed, 13 Feb 2019 13:02:38 -0500 Received: from mga17.intel.com ([192.55.52.151]:12641 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729522AbfBMSCh (ORCPT ); Wed, 13 Feb 2019 13:02:37 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2019 10:02:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,366,1544515200"; d="scan'208";a="115946043" Received: from rbhardw1-mobl.gar.corp.intel.com (HELO [10.252.68.82]) ([10.252.68.82]) by orsmga006.jf.intel.com with ESMTP; 13 Feb 2019 10:02:35 -0800 Subject: Re: [PATCH v2 00/10] ICL support and other enhancements for PMC Core To: Andy Shevchenko Cc: Platform Driver , Darren Hart , Andy Shevchenko , Linux Kernel Mailing List References: <20190213150810.32750-1-rajneesh.bhardwaj@linux.intel.com> <63bb8cc7-4feb-f69c-33be-ba5308c441d1@linux.intel.com> From: "Bhardwaj, Rajneesh" Message-ID: <6db89a43-8c69-fc33-a777-61250433fcaa@linux.intel.com> Date: Wed, 13 Feb 2019 23:32:33 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13-Feb-19 10:58 PM, Andy Shevchenko wrote: > On Wed, Feb 13, 2019 at 5:50 PM Bhardwaj, Rajneesh > wrote: >> On 13-Feb-19 9:03 PM, Andy Shevchenko wrote: >>> On Wed, Feb 13, 2019 at 5:08 PM Rajneesh Bhardwaj >>> wrote: >>>> This patch series provides Icelake support for PMC Core driver and while >>>> doing so it introduces the Icelake Mobile to intel-family.h as per the >>>> CPUID from below Coreboot link >>>> https://github.com/coreboot/coreboot/blob/5ebcea3aaaa3cd358bc5bccaa156b13a6ef25df6/src/soc/intel/common/block/include/intelblocks/mp_init.h >>>> and provides some fixes and enhancements to the driver. >>> It's not applicable to my tree. >> Hi Andy, I could apply and test in on latest upstream so i think its >> probably because you have applied 5 patches from v1 on your tree. >> https://github.com/dvhart/linux-pdx86/commits/for-next > You need to use latest tip of the subsystem tree always. Ok. > >> I sent the whole series again since >> https://patchwork.kernel.org/patch/10791893 referred to a wrong commit >> for Fixes:. If you want to address that by rebasing then can you please >> just consider patches 6-10. > We don't do rebasing for published changes. Only in rear cases when > otherwise would be worse. > Darren didn't respond to my question what he thinks about this case, > but at least it's not related to the code itself which, in my opinion, > decreases a severity. Thanks Andy. So if i understand correctly, you are suggesting that i should ignore those patches that made to "for-next" branch already? So should i just send a v3 comprising of remaining 5 patches and of course,  addressing recent review comments? >> Please let me know if there is any other issue? >