From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 888F14657C0 for ; Tue, 30 Jun 2026 15:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782834565; cv=none; b=jQAgXF46GQzZTnNag9bSm7wmwL2jr9s5Ex4EJh21iezN2tNXzPW5eNf32jTD5Ef53hUTIhP3mBNfosSrq46ZHZwMCEM8oiNvyAbQyhYJPs85JFnYI+00n0CnfpP2XbKvab99CLyqbuKEGuoNDvkqHjIEfv8iKl05WCqaN+fstpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782834565; c=relaxed/simple; bh=uOUXiuu2gk9jozaUGkU89UMF7rfF2U5T71UJJbhI+L4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e8sD5p+wY+soFJM/GArDkGH7ngbghrSs8X+Sutn/r1cPOlGFxMwAd+usurlmp4DrFJQeLrEUnX18+82YaXc2hdkP92xEU5UHpEAanRz6ppcsUEThxRX9VoJKY1pxk/UZQzL+P7mAWf45AJ3Y2OfpFokspA9gCnQiyPazW9IQiIs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=C38UeUeB; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qZDQZIhq; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="C38UeUeB"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qZDQZIhq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782834563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DTD6v+WOVsO8BscP05zQC7/J56T8cQoXSWwoIsFjkx4=; b=C38UeUeBdF22MVSWpZaUDKTb1LtovScwzN9v4SYu8jnZ8YVFlODHCAr926BYLANwdrjr3y IwDlivNomA7Puko/80SSFfnzdAP5jh/RGXzo5U59B49L2u6694h3LmECrRPG8QsqjN3uuc RAjHgdzbrdUa7bjyunDTRVvwP/pAgvQ= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-577-ayxvRmKIMC2px4w-HCpQYQ-1; Tue, 30 Jun 2026 11:49:22 -0400 X-MC-Unique: ayxvRmKIMC2px4w-HCpQYQ-1 X-Mimecast-MFC-AGG-ID: ayxvRmKIMC2px4w-HCpQYQ_1782834561 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-8099ed7adc6so81472037b3.3 for ; Tue, 30 Jun 2026 08:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782834561; x=1783439361; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DTD6v+WOVsO8BscP05zQC7/J56T8cQoXSWwoIsFjkx4=; b=qZDQZIhqXG+V+n3kSJykUePceMjtjLidBoUPjVKxUdHzyuKwuxgxH4abqEv8fRCvEL bxg/4s7O1r+7lz9eoPAsUWpL672MeQl4EsuRSC8nG9OlN4PfUsrynsgg9g/ZlNc8Rx5W OFBG+OskwQaZPHeqoGQqKhGlZEFPcdwOnuRbDRIR7CGDlmd977tCDZ+uJgm99RRR2du2 PBZwsAbzIDPoSOAMmvUm26zPed+8erfrZqilEroP2X5AvRY3npfiDboIeK8VChURENhT Jl9z1PBMEoVRYzzhCH1+4lJad3wajm+rOLDhKyTny2T1l8nJtZWKZaPTZj3O0uXOAQTN D84g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782834561; x=1783439361; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DTD6v+WOVsO8BscP05zQC7/J56T8cQoXSWwoIsFjkx4=; b=bPxFXslwqcwQ5mueZdNhGBFsd6JJpFfhhIXkuu0M7sXA3yr0IdTpbRpfoolS/DcAI1 gXvKQZatu/AqkmhSjGScco5zbjqCQC/fsDmCLHLNbDRifhoh9G3fXd0azgKmpa5Q+z7y hdDM8NGQQxsDaLJHU8cquZj7K6vDuo9+aHz4fLw8vz9WGM3UcInTKYs2xqBkU8fdgsK4 Hec4i8SIcGrbTnTPQeCPZIai1LE3C3Qne/S2i12ezXohlA7Af9mBO6qoBnHd4IlV9K/u pA67QMMRxiG6MUCY8hF5dYz1DAStIjzY/rVj73WMc4NDejDTp9YFnjLCfAkACsUZ50yU 1uDw== X-Forwarded-Encrypted: i=1; AHgh+RqcKJhN167JD8hXrGOZ1AG/CETdN0qiX1KLwuF7+1OJcHmGNW4TtKYWkxXhnrhF1lNJ4pEFYyfpJ5HHTCw=@vger.kernel.org X-Gm-Message-State: AOJu0YxHu+ZCQX+mMpBBOuP/p1pUmXVNJmMpW1W37Qe3aNf4gxHY7EB8 DHFQ5Fvv7bi98SQJkwKP0bioY97r1hKihJXvaCEKC7/T6zfDxutgOYCvcwhZ3d2ARo0jS7hpnQG dIKf/qnkRonVLOUBqh2BKgP91QFwZBaW3M0S/1kUsuyUGbRvCUMNERdPNCcGhFahHbQ== X-Gm-Gg: AfdE7clbZ/6dbKfz2bpZITx0satYDYuhVBYpJaDyU23YlHC5o7UEqPMt0iftec8K+5O xohGstEkWRmp986KaGvnnmmxI/60OXY3Hjc1Z3OVrAp/GInoRTTfGIms5gpnAm4KoJXsgjEab8L sTiJuGvbNij7qDdXc+DZyhMbAhZKqf0bbuyxp6wQ0xRg9OR79ym2AEU7mj9yWQuBmDi0GBAh02N zNtkl63+KJioPHQ9TT8YT4uRHHlh4XGPWo1zB1fRKVZ8teIr3whocyINWYp+F5FLW2/81rqoEGL PCk8varhFK+9KDWBtB+k1sxBCzz6Gyi5d7fI57/O+UWGOLo2WQdHIR9+oLFiBqpjrqOTYqgJljc 9Lnmkj9k/7vh0H9huX3Nuk+CTMjrEfxSeAFYCLJzEXid/ybOla+FawF5GGJeXr9GQyadVLu4WLn MMgO/eSJGfpQ== X-Received: by 2002:a05:690c:368f:b0:80b:bfee:c424 with SMTP id 00721157ae682-812012333ccmr10773457b3.18.1782834561602; Tue, 30 Jun 2026 08:49:21 -0700 (PDT) X-Received: by 2002:a05:690c:368f:b0:80b:bfee:c424 with SMTP id 00721157ae682-812012333ccmr10773147b3.18.1782834561065; Tue, 30 Jun 2026 08:49:21 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:2eb7:f61a:75:4534? ([2a0d:3344:5521:6b10:2eb7:f61a:75:4534]) by smtp.gmail.com with ESMTPSA id 00721157ae682-810ea1620b2sm12566107b3.35.2026.06.30.08.49.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 08:49:20 -0700 (PDT) Message-ID: <6dbb6d6d-26b6-4b9a-8e06-0a53212d022d@redhat.com> Date: Tue, 30 Jun 2026 17:49:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: gianfar: dispose irq mappings on probe failure and device removal To: Rosen Penev , netdev@vger.kernel.org Cc: Claudiu Manoil , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Andy Fleming , open list References: <20260626225228.427392-1-rosenp@gmail.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260626225228.427392-1-rosenp@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/27/26 12:52 AM, Rosen Penev wrote: > irq_of_parse_and_map() creates irqdomain mappings that should be > balanced with irq_dispose_mapping(). The driver never called > irq_dispose_mapping(), leaking mappings on probe failure and > device removal. > > Fix by adding irq_dispose_mapping() in free_gfar_dev() and > expanding its loop from priv->num_grps to MAXGROUPS so the > error path also catches partially-initialized groups. All > irqinfo pointers are pre-initialized to NULL in gfar_of_init(), > making the NULL-guarded walk in free_gfar_dev() safe for every > scenario. > > gfar_parse_group() itself is left as a simple parse function > with no resource management; cleanup is centralized in the > caller's error path. > > Assisted-by: opencode:big-pickle > Fixes: b31a1d8b4151 ("gianfar: Convert gianfar to an of_platform_driver") > Signed-off-by: Rosen Penev The PW bot is on holiday, no automated notifications for a while. Applied, thanks! /P