From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABDD027F00A; Mon, 21 Jul 2025 06:44:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753080284; cv=none; b=Qx+pmB7QyV7vFOEKWwb1s2ScZHdkH/Htnkk3/5ejhPdWKLydjyB/hlEZHfehmPjqmaVER3jjN+x3C5ipqm3TLHSgQw8Q+aUF2Svb1wVeo19783jXE92PcLalwNWlQPPO8fyHTBv4ft2zQkSLsnPKlwnALicpRBYr9b9XO8cO568= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753080284; c=relaxed/simple; bh=wvxEQfO5q7696mFzNxs9ne5fSgIF2uWYH+60V8ROAmo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z63QUB/q32dDqCce3+2U5zn/xw1lOm9rqRgBOvfC9IGhQ8z00aoxjDKs6snFJWEFtebPFJpyFd9rYT3rNB05WCS1jJQnQH4i8ayFIxsWA/SDnEAqkxbIbfbtM0916RsPdFcQLnpfucu3qlvTSgzstlhSH2EGwsDR6FLs5hK49tk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=koyHUpY3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="koyHUpY3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD43DC4CEED; Mon, 21 Jul 2025 06:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753080284; bh=wvxEQfO5q7696mFzNxs9ne5fSgIF2uWYH+60V8ROAmo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=koyHUpY3JFkN64NrYE9EI1KXTEwY/vPI0Jp0RcWoI542qQcQxlthOETZ2QIzqKzaQ HxWlFfgqat8RqDd+pQo4q7Y/pBuk8Ce+YdQdJovRuKjNkUBp+SE1xC6ZluHdzYPD6b 5svg/VaZN7OqRY1MRnIOZ0jxbd7NLHVK7LniR2mPO9XIffWPdd2UEi/fu42q1Sk7LZ W45mf/I3UIsCiKmUirHIrbMMUWEs3RI3UTUJ/vw5KDztLAXQv9t8knQHzkuM85Nd/8 96UdFxayHhtlhJqx1VFA23Gl2bC3rskloySAw4BMvV7xkkjEuxjOCSH87F+w3Q/CrM OVoffsOZUzfEg== Message-ID: <6dc0c8d7-e081-4a3d-b289-368b6da69011@kernel.org> Date: Mon, 21 Jul 2025 08:44:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/9] ASoC: dt-bindings: sound: Add Samsung ExynosAuto ABOX binding To: ew kim , broonie@kernel.org, s.nawrocki@samsung.com, robh@kernel.org, krzk+dt@kernel.org Cc: lgirdwood@gmail.com, tiwai@suse.com, perex@perex.cz, conor+dt@kernel.org, alim.akhtar@samsung.com, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250721023052.3586000-1-ew.kim@samsung.com> <20250721023052.3586000-4-ew.kim@samsung.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20250721023052.3586000-4-ew.kim@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/07/2025 04:30, ew kim wrote: > Add the device tree binding documentation for the Samsung Exynos Automotive > ABOX generic audio management core. This binding describes how to configure > the maximum number of PCM playback, PCM capture, and dummy I2S backend > instances for the ABOX core. Actual hardware functionality is provided > by child audio sub-drivers. > > Signed-off-by: ew kim > --- > .../bindings/sound/samsung,exynosauto.yaml | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml > > diff --git a/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml b/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml > new file mode 100644 > index 000000000000..b1e49f38ffe9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/samsung,exynosauto.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung Exynos Automotive Abox Generic > + > +maintainers: > + - Eunwoo Kim > + > +description: | > + The Samsung Exynos Automotive Abox Generic node represents a > + generic audio management platform device inside Exynos Automotive SoCs. No, we do not add bindings for "generic" stuff. Describe the SoC. > + It does not directly control hardware resources itself, but acts as Does not control hardware? so not suitable for bindings and DTS. > + a common interface to manage child audio sub-drivers for PCM playback, > + PCM capture, and I2S dummy backends. Not relevant. > + > + Typically, this node provides configuration for the maximum number of > + PCM playback and capture devices (ALSA PCM) and the maximum number > + of dummy I2S backend devices. The actual hardware control is handled > + by child drivers attached to this generic core. Not relevant. Describe the hardware. > + > + This node must exist for the platform driver to probe, > + even though it does not map any physical hardware address. Drivers are not relevant, read writing bindings. > + > +properties: > + compatible: > + const: samsung,abox_generic You did not implement previous feedback. This does not follow DTS coding style and writing bindings. I already asked you to read DTS coding style and nothing improved, no issues were resolved. > + > + samsung,num-pcm-playback: > + description: Maximum number of PCM playback instances (ALSA PCM devices). > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + samsung,num-pcm-capture: > + description: Maximum number of PCM capture instances (ALSA PCM devices). > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + samsung,num-i2s-dummy-backend: > + description: Maximum number of dummy I2S backend instances. > + $ref: /schemas/types.yaml#/definitions/uint32 Nothing above describes hardware. Bindings are not for ALSA. > + > + '#address-cells': > + description: Required for child nodes that may declare address space. > + const: 2 > + > + '#size-cells': > + description: Required for child nodes that may declare address space. > + const: 1 > + > +required: > + - compatible > + - samsung,num-pcm-playback > + - samsung,num-pcm-capture > + - samsung,num-i2s-dummy-backend > + > +additionalProperties: false > + > +examples: > + - | > + abox_generic { Did you read DTS coding style? > + compatible = "samsung,abox_generic"; > + samsung,num-pcm-playback = <32>; > + samsung,num-pcm-capture = <32>; > + samsung,num-i2s-dummy-backend = <5>; > + status = "disabled"; No. > + #address-cells = <2>; > + #size-cells = <1>; > + }; Best regards, Krzysztof