From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9DCEC433EF for ; Tue, 24 May 2022 13:03:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237533AbiEXNDU (ORCPT ); Tue, 24 May 2022 09:03:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231294AbiEXNDQ (ORCPT ); Tue, 24 May 2022 09:03:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 77374644E2 for ; Tue, 24 May 2022 06:03:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653397391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VuA+hQIP5NuMWzKci8Ce7ATCFxGvl8XcBeLDZ4SQZrw=; b=Xb+D9eUA/cAvD2E4+VfGAFE004kxNmi85GWwlATNQZmtCYYwOPXk8a4/bUwftWi4sneb9B cnDALIKT9LGSoLXv7hHgolR3Fn3bv7jJG+nYCBrL+BO/SztBRQR6eulXA4OLic9DNQXDjR kTcDwRgzryvhIFgW3d20KKcKKTFkwjE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-444-CLSOGblpOlahh7p4EKebVg-1; Tue, 24 May 2022 09:03:10 -0400 X-MC-Unique: CLSOGblpOlahh7p4EKebVg-1 Received: by mail-wm1-f72.google.com with SMTP id k35-20020a05600c1ca300b003946a9764baso1273771wms.1 for ; Tue, 24 May 2022 06:03:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=VuA+hQIP5NuMWzKci8Ce7ATCFxGvl8XcBeLDZ4SQZrw=; b=1RcAi6gRZeEo8dVB9RDW4B0eFiJPpEWS46Oq48Xd8JPWKpsFaKjSntoikeIyeH8u6G y4ff3SRYRDnWYaTO+E/x0DCQonRiusnJ7bXH9ip0VeouZx47MwmszqqtAQEuV4GodjLH 6YMrZxWnE2U41yutAJKj+F39mkYXgkZHlN/S5kIniPgZUNYgC8WuX5/IX8YUEJabhKtX 9IKaVnuDUTPn68Ldf11Sy9CuZzrf/ezzz9a7DJ6Wa/ZtHJZLGueztFFo7C2WpoppVruI J5nvpRJuXV7o9cb6tryAyzYRTa9rOOzuTbxmBZNhEdbhCGzLL29+k/v6JAzI+TSp05mo lJkg== X-Gm-Message-State: AOAM530m8fJ/t1WEXMhvjScc8kOe8f49mfND9vRmBbEgnlQv7PbflsBV yvRAT8AMXEa7YnhXnKeAZBUXA/jG85W7+P+BojqU9SBZ/n0nBV0nl/LSCri6e5ZM2kaKse67Q5Z 4jU65wFcaugXMeswxnAJNh22y X-Received: by 2002:a05:6000:184d:b0:20f:e9a0:dad6 with SMTP id c13-20020a056000184d00b0020fe9a0dad6mr5473137wri.317.1653397388921; Tue, 24 May 2022 06:03:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6FGiz36BIprlRrTIAV1mNT8gxPmWO8Z7EZuutiOcqaDrFguXdDtGyDfOJNR44VniSl70yKQ== X-Received: by 2002:a05:6000:184d:b0:20f:e9a0:dad6 with SMTP id c13-20020a056000184d00b0020fe9a0dad6mr5473116wri.317.1653397388723; Tue, 24 May 2022 06:03:08 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-112-184.dyn.eolo.it. [146.241.112.184]) by smtp.gmail.com with ESMTPSA id g17-20020adfbc91000000b0020e6c51f070sm12972975wrh.112.2022.05.24.06.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 06:03:08 -0700 (PDT) Message-ID: <6dc4367dc75d3f7baf9f61e2691045066b3716e1.camel@redhat.com> Subject: Re: [PATCH] r8152: Return true/false (not 1/0) from bool functions From: Paolo Abeni To: Jiapeng Chong , davem@davemloft.net Cc: edumazet@google.com, kuba@kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Date: Tue, 24 May 2022 15:03:07 +0200 In-Reply-To: <20220524093733.9537-1-jiapeng.chong@linux.alibaba.com> References: <20220524093733.9537-1-jiapeng.chong@linux.alibaba.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-05-24 at 17:37 +0800, Jiapeng Chong wrote: > Return statements in functions returning bool should use true/false > instead of 1/0. > > Clean the following coccicheck warning: > > ./drivers/net/usb/r8152.c:9579:10-11: WARNING: return of 0/1 in function > 'rtl8152_supports_lenovo_macpassthru' with return type bool. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/net/usb/r8152.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index 7389d6ef8569..7b7704b4b500 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -9576,15 +9576,15 @@ static bool rtl8152_supports_lenovo_macpassthru(struct usb_device *udev) > case DEVICE_ID_THINKPAD_USB_C_DOCK_GEN2: > case DEVICE_ID_THINKPAD_USB_C_DOCK_GEN3: > case DEVICE_ID_THINKPAD_USB_C_DONGLE: > - return 1; > + return true; > } > } else if (vendor_id == VENDOR_ID_REALTEK && parent_vendor_id == VENDOR_ID_LENOVO) { > switch (product_id) { > case 0x8153: > - return 1; > + return true; > } > } > - return 0; > + return false; > } > > static int rtl8152_probe(struct usb_interface *intf, This looks like net-next material, and net-next is currently closed, please resubmit in ~2weeks specifying the target tree in the subj. Thanks Paolo