From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 38A8B1C84A2 for ; Tue, 21 Apr 2026 08:51:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776761462; cv=none; b=E1z7R2R8TEcESp+64pbKlSqT3S4ltFbCEAyT5QjFya0Jyzlz6+PgptFqWXD2GEVJOQ6qPk/zZhokmCofJfvFmA7kRwQMbulbxeiB4kqmp5S6Q/17icFLcfiJFZvP8bfCPhJDvq6J/NmTCfyelAM6KDWr0S7K9iKjfeeUbAD8Hfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776761462; c=relaxed/simple; bh=bnoP5YNr4DMDkrY0kSZkQ7sNqqURlVJaylvyCZaTk7Y=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=RbUXFefJeyKa7RKdhCIUoWTQd8UznXaeCx2bMXsa7pyLHE+Nv9kkbqwDCjnwQG5p93INZ7dB0xcKeNL3DJr8bFOCyVRYQfFGMiaGeUgwLQIdnJ9RhHh2mCbCxX7mk1mav8HlJHUEKOcp7gHaqgPMM/oqZ9bMsPaoDtpjy7MrJRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=stJIgZ23; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="stJIgZ23" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C9C6625E0; Tue, 21 Apr 2026 01:50:54 -0700 (PDT) Received: from [10.57.17.241] (unknown [10.57.17.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C6C433F915; Tue, 21 Apr 2026 01:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776761460; bh=bnoP5YNr4DMDkrY0kSZkQ7sNqqURlVJaylvyCZaTk7Y=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=stJIgZ23FrBqf0a2lHiIC1Hoh/aJV3ZwmPS/N5ncEOZTsdTUTLTPebM1MPu9+p+y7 V5oUsp7pIC3Rzc8cCtucTZw0dF4kWLJOpHIDOLqLmv1Zk5lDco50V5lryxsfRrrmmi 2NljbEAoMm0nfHoZh0sK9/+s3mSI2lMR7HRrUlvc= Message-ID: <6dcb14c1-0759-4f2a-8bbc-b85adf3d12f4@arm.com> Date: Tue, 21 Apr 2026 09:50:56 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 02/12] coresight: etm4x: fix underflow for nrseqstate Content-Language: en-GB From: Suzuki K Poulose To: Leo Yan , Yeoreum Yun Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com References: <20260415165528.3369607-1-yeoreum.yun@arm.com> <20260415165528.3369607-3-yeoreum.yun@arm.com> <20260416151102.GL356832@e132581.arm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 21/04/2026 09:50, Suzuki K Poulose wrote: > On 16/04/2026 16:11, Leo Yan wrote: >> On Wed, Apr 15, 2026 at 05:55:18PM +0100, Yeoreum Yun wrote: >>> TCRSEQEVR is implemented only when TCRIDR5.NUMSEQSTATE is 0b100, >>> in which case n ranges from 0 to 2; otherwise, TCRIDR5.NUMSEQSTATE is >>> 0b000. >> >> My suggestion in previous version is not quite right, thanks for >> making this correct. >> >> [...] >> >>> @@ -1395,6 +1395,8 @@ static ssize_t seq_idx_store(struct device *dev, >>>       struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); >>>       struct etmv4_config *config = &drvdata->config; >>> +    if (!drvdata->nrseqstate) >>> +        return -EINVAL; >> >> For "nrseqstate = 0" case, would it return -EOPNOTSUPP instead? > > Or should we make this only visible if the nrseqstore is meaningful ? > > Suzuki > >> >> Otherwise, LGTM: >> >> Reviewed-by: Leo Yan > Also, please add Fixes: tag for these bug fixes