From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B106FE9271B for ; Thu, 5 Oct 2023 16:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240484AbjJEQNE (ORCPT ); Thu, 5 Oct 2023 12:13:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240222AbjJEQLi (ORCPT ); Thu, 5 Oct 2023 12:11:38 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55C021997; Thu, 5 Oct 2023 06:49:15 -0700 (PDT) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 395Crnot016177; Thu, 5 Oct 2023 13:49:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=Pz0GqpDqSZMui6KOWNYOmZIs7ZEVaF6iscVwRiqliXA=; b=iJITAnVaZUWj4t8T56dL9G/LdGucJ2le8tQwLL2wEWjmWGhloq6uYFbH5at060lk84bh WHDG4s9D510adfvAlTJPtjKoGD0BVMvmM9Jl7cQH3cWQqOH4qnL1MdoyLfKMVtRkZ56+ bYIUP7Mqi9VolBzhUt3NbqYpSNmXfGhxQT3uaXB/qkQnX4e6NuFzD3X/cbWjPCdpNoUV eERLbihFnCoRMuxtxsocdORaN8CVe+I/kSpaO64ybMLIQKkR0lISayIRCj/g4jSHNFoC bbsyAWC0Wj+HVxcQSVXRMhlOyxFlGPEUnKFY9CyRrJeKHCx/sqj9f62UgHz+LhU79Bu/ fw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3thj6ghe3t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Oct 2023 13:49:04 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 395Dn3x4022628 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Oct 2023 13:49:03 GMT Received: from [10.216.12.172] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Thu, 5 Oct 2023 06:48:59 -0700 Message-ID: <6dcb61f6-9be4-4feb-a7dd-44d606fcc480@quicinc.com> Date: Thu, 5 Oct 2023 19:18:45 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: ipq5018: add QUP1 SPI controller Content-Language: en-US To: Robert Marko , , , , , , , , , References: <20231004191303.331055-1-robimarko@gmail.com> From: Kathiravan Thirumoorthy In-Reply-To: <20231004191303.331055-1-robimarko@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: iJwaZZ0vxw8Y6w8cw_rERT9pYza4loj8 X-Proofpoint-ORIG-GUID: iJwaZZ0vxw8Y6w8cw_rERT9pYza4loj8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-05_08,2023-10-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 malwarescore=0 adultscore=0 priorityscore=1501 clxscore=1011 mlxlogscore=916 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310050108 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/5/2023 12:42 AM, Robert Marko wrote: > Add the required BAM and QUP nodes for the QUP1 SPI controller on IPQ5018. > > Signed-off-by: Robert Marko > --- > arch/arm64/boot/dts/qcom/ipq5018.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > index 38ffdc3cbdcd..484034e65f4f 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > @@ -146,6 +146,16 @@ sdhc_1: mmc@7804000 { > status = "disabled"; > }; > > + blsp_dma: dma-controller@7884000 { > + compatible = "qcom,bam-v1.7.0"; > + reg = <0x07884000 0x1d000>; > + interrupts = ; > + clocks = <&gcc GCC_BLSP1_AHB_CLK>; > + clock-names = "bam_clk"; > + #dma-cells = <1>; > + qcom,ee = <0>; > + }; > + > blsp1_uart1: serial@78af000 { > compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm"; > reg = <0x078af000 0x200>; > @@ -156,6 +166,20 @@ blsp1_uart1: serial@78af000 { > status = "disabled"; > }; > > + blsp1_spi1: spi@78b5000 { > + compatible = "qcom,spi-qup-v2.2.1"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x78b5000 0x600>; Please pad the address part to 8 hex digits with leading zeroes. With that, Reviewed-by: Kathiravan T > + interrupts = ; > + clocks = <&gcc GCC_BLSP1_QUP1_SPI_APPS_CLK>, > + <&gcc GCC_BLSP1_AHB_CLK>; > + clock-names = "core", "iface"; > + dmas = <&blsp_dma 4>, <&blsp_dma 5>; > + dma-names = "tx", "rx"; > + status = "disabled"; > + }; > + > intc: interrupt-controller@b000000 { > compatible = "qcom,msm-qgic2"; > reg = <0x0b000000 0x1000>, /* GICD */