From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750930AbdE2IAc (ORCPT ); Mon, 29 May 2017 04:00:32 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:60929 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbdE2IAb (ORCPT ); Mon, 29 May 2017 04:00:31 -0400 Subject: Re: [PATCH v1 7/8] powerpc/Kconfig: Enable STRICT_KERNEL_RWX To: kbuild test robot , Balbir Singh , Laura Abbott , Linus Torvalds Cc: paulus@samba.org, kbuild-all@01.org, naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, rashmica.g@gmail.com, "linux-kernel@vger.kernel.org" , linux-pm@vger.kernel.org References: <201705260000.CDMt1Ieh%fengguang.wu@intel.com> From: Christophe LEROY Message-ID: <6dcd8ea3-e953-3319-0e0e-8543018e882f@c-s.fr> Date: Mon, 29 May 2017 10:00:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <201705260000.CDMt1Ieh%fengguang.wu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 25/05/2017 à 18:45, kbuild test robot a écrit : > Hi Balbir, > > [auto build test ERROR on powerpc/next] > [also build test ERROR on v4.12-rc2 next-20170525] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Balbir-Singh/Enable-STRICT_KERNEL_RWX/20170525-150234 > base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next > config: powerpc-allmodconfig (attached as .config) > compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=powerpc > > All errors (new ones prefixed by >>): > >>> kernel//power/snapshot.c:40:28: fatal error: asm/set_memory.h: No such file or directory > #include Looks like it is linked to commit 50327ddfb ("kernel/power/snapshot.c: use set_memory.h header"). https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=50327ddfb I believe that inclusion should be conditional to CONFIG_ARCH_HAS_SET_MEMORY, which is not set by powerpc arch, just like in include/linux/filter.c Christophe > ^ > compilation terminated. > > vim +40 kernel//power/snapshot.c > > 25761b6eb Rafael J. Wysocki 2005-10-30 24 #include > 38b8d208a Ingo Molnar 2017-02-08 25 #include > 25761b6eb Rafael J. Wysocki 2005-10-30 26 #include > 25761b6eb Rafael J. Wysocki 2005-10-30 27 #include > 25761b6eb Rafael J. Wysocki 2005-10-30 28 #include > 846705deb Rafael J. Wysocki 2008-11-26 29 #include > 5a0e3ad6a Tejun Heo 2010-03-24 30 #include > 52f5684c8 Gideon Israel Dsouza 2014-04-07 31 #include > db5976058 Tina Ruchandani 2014-10-30 32 #include > 25761b6eb Rafael J. Wysocki 2005-10-30 33 > 7c0f6ba68 Linus Torvalds 2016-12-24 34 #include > 25761b6eb Rafael J. Wysocki 2005-10-30 35 #include > 25761b6eb Rafael J. Wysocki 2005-10-30 36 #include > 25761b6eb Rafael J. Wysocki 2005-10-30 37 #include > 25761b6eb Rafael J. Wysocki 2005-10-30 38 #include > 50327ddfb Laura Abbott 2017-05-08 39 #ifdef CONFIG_STRICT_KERNEL_RWX > 50327ddfb Laura Abbott 2017-05-08 @40 #include > 50327ddfb Laura Abbott 2017-05-08 41 #endif > 25761b6eb Rafael J. Wysocki 2005-10-30 42 > 25761b6eb Rafael J. Wysocki 2005-10-30 43 #include "power.h" > 25761b6eb Rafael J. Wysocki 2005-10-30 44 > 0f5bf6d0a Laura Abbott 2017-02-06 45 #ifdef CONFIG_STRICT_KERNEL_RWX > 4c0b6c10f Rafael J. Wysocki 2016-07-10 46 static bool hibernate_restore_protection; > 4c0b6c10f Rafael J. Wysocki 2016-07-10 47 static bool hibernate_restore_protection_active; > 4c0b6c10f Rafael J. Wysocki 2016-07-10 48 > > :::::: The code at line 40 was first introduced by commit > :::::: 50327ddfbc926e68da1958e4fac51f1106f5e730 kernel/power/snapshot.c: use set_memory.h header > > :::::: TO: Laura Abbott > :::::: CC: Linus Torvalds > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation >