From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A79C3293C5B for ; Fri, 27 Jun 2025 13:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751031484; cv=none; b=nu/uw7ZCPLET92HPTJwl8L/nZD9keTWvgzBJt7Yk0lckwYU7hL4F4CJrvjkIdwjfYHs5i5QoibaZiJ+YAMMkvs0ldkY3xtvt4Nz1m6YK/oX15Kojgv2hhWRkcaqqGDsT//MggVJyOUEK1gnB98ph3+D/GLYfmJf/lJic7DJLDzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751031484; c=relaxed/simple; bh=xnDoLqofriKHpPY1ZzRiz8Isb9hYWeVDw3r07UJgEA8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nO3o4B9mkx1BENYZhcXWXliGIiHe99QoePPfnxauob0fxPGoyWpWOOZ/1JOO48iUOgXojJfHTJ8ud3SXEHzufYX5jZ8dxwA+Aw95ni1d90v2CH5g2yjlPhKtGErmO8OsK1Yj18RLtp5hyvcASr27joPw7+U8vkElURZPogxBwCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cQj35XqU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cQj35XqU" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55RBxmCc001166 for ; Fri, 27 Jun 2025 13:38:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2QtnvQnfluWMwHt5pv65ScEV4CUxIy5BoKzB2wk7FAQ=; b=cQj35XqUQK8xtpDy I8pHTQeVJQY2Vx2y2VgUuIR+nA1JnYfaqf++o1KIYpBKe2DvPMXETHXKC4s0LwOj q8ak1N7/MYobBNDuH2WZRB859JJ1+GXlxbPbRUSrmPGwWlkwlzPZNuqMfd4X3lNR NTw807OvA43MQoyXGbB2+KuubA3Hn23g/swq3BQwWXaaeh3BY9twYoDEwFBID0Ry kAU09bA3kPjGadbweSVR4WDvGRKtbNqc6MaWigcVbtsCvbk5CNJ4nDejZPDOPIva kIK7jNukqxP0OqoBFnR1IchI1Qq6SXCMDVuNJSoR2POzCc7lhB6aDON3bxR2Kf+M VQ89FQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47g7tdh0qv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 27 Jun 2025 13:38:01 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7d446ce0548so90601985a.3 for ; Fri, 27 Jun 2025 06:38:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751031480; x=1751636280; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2QtnvQnfluWMwHt5pv65ScEV4CUxIy5BoKzB2wk7FAQ=; b=ZLZmnJJVPlHyDez+cL2aJxAtM7fLktuOUDfn+6Pk2aAuAeFw8G1mzI6dR07OhEPG7b No2ST+F/bYpsDUQGvGhIGuGBfVl5x7jqR29PZVrR0kirhJTrzcQxDIcyxxY0crZSFFqw uEb9Io7qBBNnhl6sJzmJ0xhp0GOnp90vya2mVE3wrc+x5NuFdWcAxQTEXIRexycRChU/ ZJ+utpNJhHcxJGR2U74oi3X/L9A8AVLeDpZFVmW9B7J06cSMo2PGE7eV9uma83xhUmPF ZJ0s1AIN6C9Rqrz2LzZHHyEmj8Jfo7POgdwsIgDy5liwvJX9SSBdsdzFn0dZL+Li71Em dZTA== X-Forwarded-Encrypted: i=1; AJvYcCVZdpANiVYT17MC4C22WVLt/WNKILcK/7dasBcB82FLLRueh3t0Tyf/Z35/jX+bbomVHl6GcLIWEIdvhEI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw65I4YQ9J8HXIjcnD6da8LFJKY76wZGZNrnN8Elyv8mQHaTKpH 4ajr0S6aYcqVoqQsKH5C5MPANEHZGjF9pi9oVg6ZRSm0/d5P53h1le/iIGPoxkDGxGPTMz8OOlM QWa1zxCv9fnfodcFzt3dDkv1Y9mcwgjk3Zwe1OZKLfQJeKvUsxU0LRis1cgzAgdfLJNQ= X-Gm-Gg: ASbGncvgHBh/d8nBaJQo998DqVVZ/qDs6Rj0b2EJZpoKOF7pIgTit//s7NZF1fA5WmT r3YTQ6sVecRdsuu8C74pPL34sSMOLKQEJR5k2dA5eDZI9Q/10y90Z6dC4cPNJrX8753fiSDnBOb oW4O+Fo37LB4MMsf7NqQ0ZR0J00ovAhAmFLPhMK/jKfK3I6JIB7ES41arc9hPIdDC1FRaig9y3v R0p3sQThpFepUdAaGtA5ur5WO/3iS7+C9kIAiAU/GCoPVJgcoPmM0itJHK3gCzgBje1NJzLsLyo wKCl1dFG3smX8Ta5eIxK4800kEFjf4WCV0sfuM38Qw== X-Received: by 2002:a05:620a:1904:b0:7d3:907f:7544 with SMTP id af79cd13be357-7d4439a6584mr493459485a.35.1751031480165; Fri, 27 Jun 2025 06:38:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGvL73yf4sU/gW3mguJ2q0llUda4VgDpvmnaVGMd6K090C/8Loa8JscxVRP4J8tuzbwVKrCvw== X-Received: by 2002:a05:620a:1904:b0:7d3:907f:7544 with SMTP id af79cd13be357-7d4439a6584mr493455085a.35.1751031479671; Fri, 27 Jun 2025 06:37:59 -0700 (PDT) Received: from [10.92.240.160] ([212.136.9.4]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353c0100fsm125509766b.88.2025.06.27.06.37.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jun 2025 06:37:58 -0700 (PDT) Message-ID: <6dcf88bc-0bdf-4965-b8af-b881a564d762@oss.qualcomm.com> Date: Fri, 27 Jun 2025 16:37:56 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/38] drm/msm/dp: remove dp_display's dp_mode and use dp_panel's instead To: Yongxing Mou Cc: Rob Clark , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20250609-msm-dp-mst-v2-0-a54d8902a23d@quicinc.com> <20250609-msm-dp-mst-v2-2-a54d8902a23d@quicinc.com> <1be2238d-7bb2-4ef9-9c7c-81dab0dcb559@quicinc.com> <4jrpa7iyygciuy2k4ydk7cpm5isdrddclljf6gbyvkiqc645tx@idyds4tkstkx> <9358a017-81ed-4db7-8e35-955922287c76@quicinc.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: <9358a017-81ed-4db7-8e35-955922287c76@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=CPYqXQrD c=1 sm=1 tr=0 ts=685e9eb9 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=dNlqnMcrdpbb+gQrTujlOQ==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=e5mUnYsNAAAA:8 a=COk6AnOGAAAA:8 a=QLF5U8kL1nvtC7vkCdQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=Vxmtnl_E_bksehYqCbjh:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI3MDExMyBTYWx0ZWRfX4BjrYLyuMWcT yqIlwERWzw/jH3hFyzJ3vbYSGGZo3D55bVHUtgNA6/BvXA93chWu2uMuN3Xw06xw/USA6E0HB3m pMS4OaKixQuiMFf9KoynfWHaerB6F8+X0qgD91ZPFFkA4QX03V1BNvlMmhLQ//oIKQgkg9TI24U 30IaGZu4B0+Pc1mRZyxk+C1pscQRsf8gd8m1pxK5P7/6sUhhf1cnet+qXP8bvofJc5pLiDgAwlb cJdCc2MGJaN3hCKwzBFGVFNwO6HaTYpv/lOoxJqhkGSp2GpMp14DXieYmQLHiFcjPrBsXuHf3C5 Uc0X19Ebrzss8Gh1ZlcV9gsCw1BbJiHh6HG3Gge0sTCED2dOIH76fshDRIB3D6afdoY7qWEXCg6 huT6cjeAPxfawvHFKkud7jF0j1LUzQvGAv+oGs/UAJTU3i9wUOzvC5MswUITJAFi8zH/T3tW X-Proofpoint-GUID: G5qOgMwI4_k3--BUgHnGmpDrvr0KKm5t X-Proofpoint-ORIG-GUID: G5qOgMwI4_k3--BUgHnGmpDrvr0KKm5t X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-27_04,2025-06-26_05,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 impostorscore=0 suspectscore=0 clxscore=1015 spamscore=0 priorityscore=1501 adultscore=0 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506270113 On 27/06/2025 11:40, Yongxing Mou wrote: > > > On 2025/6/25 22:03, Dmitry Baryshkov wrote: >> On Wed, Jun 25, 2025 at 08:34:18PM +0800, Yongxing Mou wrote: >>> >>> >>> On 2025/6/9 20:48, Dmitry Baryshkov wrote: >>>> On Mon, Jun 09, 2025 at 08:21:21PM +0800, Yongxing Mou wrote: >>>>> From: Abhinav Kumar >>>>> >>> Originally, the drm_mode would be passed in >>> two stages: from msm_dp_display->msm_dp_mode to dp_panel- >>> >msm_dp_mode. Since >>> in MST mode each stream requires its own drm_mode and stored in >>> dp_panel, we >>> simplified the two-stage transfer into a single step (.mode_set() do all >>> things and store in msm_dp_panel). Meanwhile we modified the >>> msm_dp_display_set_mode function to accept a msm_dp_panel parameter, >>> allowing the MST bridge funcs' mode_set() to reuse this part code. >>> >>> The following patches: >>> https://patchwork.freedesktop.org/patch/657573/?series=142207&rev=2 and >>> https://patchwork.freedesktop.org/patch/657593/?series=142207&rev=2, >>> introduce msm_dp_display_*_helper functions to help reuse common code >>> across >>> MST/SST/eDP drm_bridge_funcs. >>> >>> If we drop msm_dp_mode from dp_panel and use drm_display_mode, it might >>> introduce a large number of changes that are not directly related to >>> MST. >>> Actually i think the presence of msm_dp_display_mode seems to >>> simplify the >>> work in msm_dp_panel_timing_cfg(), this patch series we want to focus >>> on MST >>> parts, so would we consider optimizing them later? >> >> Sure... But then you have to change two places. If you optimize it >> first, you have to touch only place. And it can be even submitted >> separately. >> > Understood, that’s indeed the case. I just want to prioritize the MST > patch and have it merged first, since it involves changes to lots of > files. Thanks~~ I'm sorry, I hit enter too quickly. The MST will not be merged until we get DP HPD rework in, that's a prerequisite from my side. So, while that is getting sorted out, we can fix minor issues and perform minor cleanups, like the checksums or drm_mode refactoring. -- With best wishes Dmitry