From: "Slark Xiao" <slark_xiao@163.com>
To: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>
Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH v2 1/2] bus: mhi: host: pci_generic: Update the file path for Foxconn SDX55/SDX72
Date: Thu, 25 Jul 2024 16:56:03 +0800 (CST) [thread overview]
Message-ID: <6dd00891.8235.190e91ac139.Coremail.slark_xiao@163.com> (raw)
In-Reply-To: <20240725035954.GA2317@thinkpad>
At 2024-07-25 11:59:54, "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org> wrote:
>On Thu, Jul 25, 2024 at 10:29:40AM +0800, Slark Xiao wrote:
>> To separate the images of Foxconn from other vendors, adding a
>> new foxconn subfolder under qcom/<platform> for edl image path.
>> And delete the fw patch since it's useless for Foxconn devices.
>>
>> Fixes: bf30a75e6e00 ("bus: mhi: host: Add support for Foxconn SDX72 modems")
>> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>> ---
>> v2: change the folder path architecture
>> ---
>> drivers/bus/mhi/host/pci_generic.c | 13 +++++--------
>> 1 file changed, 5 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
>> index 14a11880bcea..f159a9dd53e7 100644
>> --- a/drivers/bus/mhi/host/pci_generic.c
>> +++ b/drivers/bus/mhi/host/pci_generic.c
>> @@ -433,8 +433,7 @@ static const struct mhi_controller_config modem_foxconn_sdx72_config = {
>>
>> static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = {
>> .name = "foxconn-sdx55",
>> - .fw = "qcom/sdx55m/sbl1.mbn",
>> - .edl = "qcom/sdx55m/edl.mbn",
>> + .edl = "qcom/sdx55m/foxconn/prog_firehose_sdx55.mbn",
>
>I think you misunderstood what I suggested in earlier revision. You should add
>the Foxconn specific fw only if it is different from the qcom one. Is it really
>different for all these modems? Otherwise, what is the point of adding them?
>
>- Mani
>
Hi Mani,
Yes, all programer files are different with default. We add a sign step for each image
file. That means other vendor's edl image(including Qualcomm) can't be applied for
Foxconn devices.
>> .config = &modem_foxconn_sdx55_config,
>> .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>> .dma_data_width = 32,
>> @@ -444,8 +443,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = {
>>
>> static const struct mhi_pci_dev_info mhi_foxconn_t99w175_info = {
>> .name = "foxconn-t99w175",
>> - .fw = "qcom/sdx55m/sbl1.mbn",
>> - .edl = "qcom/sdx55m/edl.mbn",
>> + .edl = "qcom/sdx55m/foxconn/prog_firehose_sdx55.mbn",
>> .config = &modem_foxconn_sdx55_config,
>> .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>> .dma_data_width = 32,
>> @@ -455,8 +453,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_t99w175_info = {
>>
>> static const struct mhi_pci_dev_info mhi_foxconn_dw5930e_info = {
>> .name = "foxconn-dw5930e",
>> - .fw = "qcom/sdx55m/sbl1.mbn",
>> - .edl = "qcom/sdx55m/edl.mbn",
>> + .edl = "qcom/sdx55m/foxconn/prog_firehose_sdx55.mbn",
>> .config = &modem_foxconn_sdx55_config,
>> .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>> .dma_data_width = 32,
>> @@ -502,7 +499,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_dw5932e_info = {
>>
>> static const struct mhi_pci_dev_info mhi_foxconn_t99w515_info = {
>> .name = "foxconn-t99w515",
>> - .edl = "fox/sdx72m/edl.mbn",
>> + .edl = "qcom/sdx72m/foxconn/edl.mbn",
>> .edl_trigger = true,
>> .config = &modem_foxconn_sdx72_config,
>> .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>> @@ -513,7 +510,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_t99w515_info = {
>>
>> static const struct mhi_pci_dev_info mhi_foxconn_dw5934e_info = {
>> .name = "foxconn-dw5934e",
>> - .edl = "fox/sdx72m/edl.mbn",
>> + .edl = "qcom/sdx72m/foxconn/edl.mbn",
>> .edl_trigger = true,
>> .config = &modem_foxconn_sdx72_config,
>> .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>> --
>> 2.25.1
>>
>
>--
>மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-07-25 8:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 2:29 Slark Xiao
2024-07-25 2:29 ` [PATCH v2 2/2] bus: mhi: host: pci_generic: Enable trigger_edl for Foxconn SDX55/SDX65/SDX24 products Slark Xiao
2024-08-30 11:55 ` Manivannan Sadhasivam
2024-08-30 12:18 ` Manivannan Sadhasivam
2024-07-25 3:59 ` [PATCH v2 1/2] bus: mhi: host: pci_generic: Update the file path for Foxconn SDX55/SDX72 Manivannan Sadhasivam
2024-07-25 8:56 ` Slark Xiao [this message]
2024-07-26 5:00 ` Manivannan Sadhasivam
2024-07-26 5:55 ` Slark Xiao
2024-07-26 11:58 ` Manivannan Sadhasivam
2024-08-29 11:33 ` Slark Xiao
2024-08-30 11:55 ` Manivannan Sadhasivam
2024-08-30 12:18 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dd00891.8235.190e91ac139.Coremail.slark_xiao@163.com \
--to=slark_xiao@163.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®