From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F127C433EF for ; Sun, 3 Apr 2022 09:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356138AbiDCJO6 (ORCPT ); Sun, 3 Apr 2022 05:14:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234343AbiDCJO5 (ORCPT ); Sun, 3 Apr 2022 05:14:57 -0400 Received: from smtp.smtpout.orange.fr (smtp07.smtpout.orange.fr [80.12.242.129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 292B832EF4 for ; Sun, 3 Apr 2022 02:13:03 -0700 (PDT) Received: from [192.168.1.18] ([90.126.236.122]) by smtp.orange.fr with ESMTPA id awI7nFC7WRGzQawI7nw1jb; Sun, 03 Apr 2022 11:13:01 +0200 X-ME-Helo: [192.168.1.18] X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Sun, 03 Apr 2022 11:13:01 +0200 X-ME-IP: 90.126.236.122 Message-ID: <6dd4ac07-397c-1e02-2ac5-2a8f243bfefe@wanadoo.fr> Date: Sun, 3 Apr 2022 11:12:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] ASoC: msm8916-wcd-digital: Fix missing clk_disable_unprepare() in msm8916_wcd_digital_probe Content-Language: en-US To: =?UTF-8?B?5p6X5aaZ5YCp?= Cc: alsa-devel@alsa-project.org, Banajit Goswami , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown , Srinivas Kandagatla References: <20220307084523.28687-1-linmq006@gmail.com> <93751991-30ce-93a0-0f33-105f99b8dfe3@wanadoo.fr> From: Christophe JAILLET In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 03/04/2022 à 09:15, 林妙倩 a écrit : > Hi, > > Yes, I agree with you. We should check the error code of > devm_snd_soc_register_component() and do corresponding > handling. You already fixed the first issue, do you mind sending a patch for this one as well? CJ > > Christophe JAILLET 于2022年4月3日周日 13:51写道： > >> Le 07/03/2022 à 09:45, Miaoqian Lin a écrit : >>> Fix the missing clk_disable_unprepare() before return >>> from msm8916_wcd_digital_probe in the error handling case. >>> >>> Fixes: 150db8c5afa1 ("ASoC: codecs: Add msm8916-wcd digital codec") >>> Signed-off-by: Miaoqian Lin >>> --- >>> sound/soc/codecs/msm8916-wcd-digital.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/sound/soc/codecs/msm8916-wcd-digital.c >> b/sound/soc/codecs/msm8916-wcd-digital.c >>> index fcc10c8bc625..9ad7fc0baf07 100644 >>> --- a/sound/soc/codecs/msm8916-wcd-digital.c >>> +++ b/sound/soc/codecs/msm8916-wcd-digital.c >>> @@ -1201,7 +1201,7 @@ static int msm8916_wcd_digital_probe(struct >> platform_device *pdev) >>> ret = clk_prepare_enable(priv->mclk); >>> if (ret < 0) { >>> dev_err(dev, "failed to enable mclk %d\n", ret); >>> - return ret; >>> + goto err_clk; >>> } >>> >>> dev_set_drvdata(dev, priv); >>> @@ -1209,6 +1209,9 @@ static int msm8916_wcd_digital_probe(struct >> platform_device *pdev) >>> return devm_snd_soc_register_component(dev, &msm8916_wcd_digital, >>> msm8916_wcd_digital_dai, >>> ARRAY_SIZE(msm8916_wcd_digital_dai)); >>> +err_clk: >>> + clk_disable_unprepare(priv->ahbclk); >>> + return ret; >>> } >>> >>> static int msm8916_wcd_digital_remove(struct platform_device *pdev) >> >> Hi, >> I think that the same should be done for 'priv->mclk' if >> devm_snd_soc_register_component() returns an error. >> >> Can you give it a look? >> >> CJ >> >