From: bot+bpf-ci@kernel.org
To: skokovmaksimevg@gmail.com,bpf@vger.kernel.org
Cc: ast@kernel.org,daniel@iogearbox.net,andrii@kernel.org,martin.lau@linux.dev,eddyz87@gmail.com,song@kernel.org,yonghong.song@linux.dev,jolsa@kernel.org,memxor@gmail.com,emil@etsalapatis.com,ihor.solodrai@linux.dev,davem@davemloft.net,edumazet@kernel.org,kuba@kernel.org,pabeni@redhat.com,horms@kernel.org,shuah@kernel.org,vadim.fedorenko@linux.dev,netdev@vger.kernel.org,linux-kselftest@vger.kernel.org,linux-kernel@vger.kernel.org,skokovmaksimevg@gmail.com,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf 1/2] bpf: test_run: Fix false -EBADMSG after skb leaves CHECKSUM_COMPLETE
Date: Wed, 7 Oct 2026 18:45:32 +0000 (UTC) [thread overview]
Message-ID: <6ddac0398e54f73f0d424069145c6901d8d0ff3401fb160db0a9e3b281270c06@mail.kernel.org> (raw)
In-Reply-To: <20261007181249.352831-2-skokovmaksimevg@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]
> bpf: test_run: Fix false -EBADMSG after skb leaves CHECKSUM_COMPLETE
TL;DR: Nit only: the multi-line comment in bpf_prog_test_run_skb() should
start with /* on its own line, per BPF style. No functional problems raised.
> diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c
> index 513354e928cb..45718fa9adfd 100644
> --- a/net/bpf/test_run.c
> +++ b/net/bpf/test_run.c
> @@ -1237,7 +1237,12 @@ int bpf_prog_test_run_skb(struct bpf_prog *prog, const union bpf_attr *kattr,
> memset(__skb_push(skb, hh_len), 0, hh_len);
> }
>
> - if (kattr->test.flags & BPF_F_TEST_SKB_CHECKSUM_COMPLETE) {
> + /* A helper such as bpf_skb_change_tail() may have downgraded the skb
> + * from CHECKSUM_COMPLETE. skb->csum is then unused by the stack and
> + * there is nothing to validate.
> + */
This isn't a bug, but could the opening of this multi-line comment be put on
its own line, with the text starting on the next line, as is preferred for
BPF code?
/*
* A helper such as bpf_skb_change_tail() may have downgraded the skb
* from CHECKSUM_COMPLETE. skb->csum is then unused by the stack and
* there is nothing to validate.
*/
> + if ((kattr->test.flags & BPF_F_TEST_SKB_CHECKSUM_COMPLETE) &&
> + skb->ip_summed == CHECKSUM_COMPLETE) {
> const int off = skb_network_offset(skb);
> int len = skb->len - off;
> __wsum csum;
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/37667470582
next prev parent reply other threads:[~2026-10-07 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 18:12 [PATCH bpf 0/2] bpf: test_run: Fix false -EBADMSG with BPF_F_TEST_SKB_CHECKSUM_COMPLETE Maxim Skokov
2026-10-07 18:12 ` [PATCH bpf 1/2] bpf: test_run: Fix false -EBADMSG after skb leaves CHECKSUM_COMPLETE Maxim Skokov
2026-10-07 18:45 ` bot+bpf-ci [this message]
2026-10-08 17:17 ` Maxim Skokov
2026-10-07 18:12 ` [PATCH bpf 2/2] selftests/bpf: Cover test_run csum validation after bpf_skb_change_tail() Maxim Skokov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ddac0398e54f73f0d424069145c6901d8d0ff3401fb160db0a9e3b281270c06@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@kernel.org \
--cc=emil@etsalapatis.com \
--cc=horms@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mason@kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=skokovmaksimevg@gmail.com \
--cc=song@kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®