From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751769AbdF1XSK (ORCPT ); Wed, 28 Jun 2017 19:18:10 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:36187 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbdF1XSD (ORCPT ); Wed, 28 Jun 2017 19:18:03 -0400 Subject: Re: [RFC 1/2] net: phy: rework Kconfig settings for MDIO_BUS To: Arnd Bergmann Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Kishon Vijay Abraham I , Andrew Lunn , netdev@vger.kernel.org, "David S . Miller" , linux-kernel@vger.kernel.org References: <20170621220626.46691-1-arnd@arndb.de> From: Florian Fainelli Message-ID: <6ddd0a30-cd29-a05a-01e3-b523689271e4@gmail.com> Date: Wed, 28 Jun 2017 16:17:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170621220626.46691-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/21/2017 03:06 PM, Arnd Bergmann wrote: > I still see build errors in randconfig builds and have had this > patch for a while to locally work around it: > > drivers/built-in.o: In function `xgene_mdio_probe': > mux-core.c:(.text+0x352154): undefined reference to `of_mdiobus_register' > mux-core.c:(.text+0x352168): undefined reference to `mdiobus_free' > mux-core.c:(.text+0x3521c0): undefined reference to `mdiobus_alloc_size' > > The idea is that CONFIG_MDIO_BUS now reflects whether the mdio_bus > code is built-in or a module, and other drivers that use the core > code can simply depend on that, instead of having a complex > dependency line. > > Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs") > Signed-off-by: Arnd Bergmann Reviewed-by: Florian Fainelli This looks a lot better indeed, thanks! -- Florian