From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752520AbdHVVEg (ORCPT ); Tue, 22 Aug 2017 17:04:36 -0400 Received: from gateway36.websitewelcome.com ([192.185.188.18]:42458 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079AbdHVVEf (ORCPT ); Tue, 22 Aug 2017 17:04:35 -0400 X-Greylist: delayed 1495 seconds by postgrey-1.27 at vger.kernel.org; Tue, 22 Aug 2017 17:04:35 EDT Subject: Re: [PATCH] PCI: dwc: dra7xx: fix error return code in dra7xx_pcie_probe() To: Bjorn Helgaas References: <20170809161603.GA31297@embeddedgus> <20170822203750.GF6948@bhelgaas-glaptop.roam.corp.google.com> Cc: Kishon Vijay Abraham I , Bjorn Helgaas , linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Message-ID: <6de244a4-8efb-95c4-ff4b-ab9221ef5751@embeddedor.com> Date: Tue, 22 Aug 2017 15:39:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170822203750.GF6948@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.158.27 X-Exim-ID: 1dkFxb-003RS6-An X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.70]) [189.152.158.27]:47794 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, On 08/22/2017 03:37 PM, Bjorn Helgaas wrote: > On Wed, Aug 09, 2017 at 11:16:03AM -0500, Gustavo A. R. Silva wrote: >> platform_get_irq() returns an error code, but the pci-dra7xx driver >> ignores it and always returns -EINVAL. This is not correct and, >> prevents -EPROBE_DEFER from being propagated properly. >> >> Print and propagate the return value of platform_get_irq on failure. >> >> This issue was detected with the help of Coccinelle. >> >> Signed-off-by: Gustavo A. R. Silva > > Applied with Kishon's ack to pci/host-dra7xx for v4.14, thanks! > Glad to help. :) >> --- >> drivers/pci/dwc/pci-dra7xx.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c >> index f2fc5f4..f58e1b4 100644 >> --- a/drivers/pci/dwc/pci-dra7xx.c >> +++ b/drivers/pci/dwc/pci-dra7xx.c >> @@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) >> >> irq = platform_get_irq(pdev, 0); >> if (irq < 0) { >> - dev_err(dev, "missing IRQ resource\n"); >> - return -EINVAL; >> + dev_err(dev, "missing IRQ resource: %d\n", irq); >> + return irq; >> } >> >> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ti_conf"); >> -- >> 2.5.0 >> -- Gustavo A. R. Silva