From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933221AbdCJRkC (ORCPT ); Fri, 10 Mar 2017 12:40:02 -0500 Received: from mail-dm3nam03on0076.outbound.protection.outlook.com ([104.47.41.76]:37944 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932912AbdCJRjx (ORCPT ); Fri, 10 Mar 2017 12:39:53 -0500 Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=amd.com; Subject: Re: amd-xgbe: unbalanced irq enable in v4.11-rc1 To: Mark Rutland , , References: <20170310171953.GA24571@leverpostej> CC: "David S. Miller" From: Tom Lendacky Message-ID: <6ded1511-af84-e406-7e86-dd84972c451d@amd.com> Date: Fri, 10 Mar 2017 11:39:42 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170310171953.GA24571@leverpostej> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR10CA0012.namprd10.prod.outlook.com (10.172.48.22) To DM5PR12MB1148.namprd12.prod.outlook.com (10.168.236.143) X-MS-Office365-Filtering-Correlation-Id: c40a82b2-75fe-46a7-dbb1-08d467dc71cf X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:DM5PR12MB1148; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1148;3:/fCMi0ovugbVt6JmaszusBjaDhENirD+PrHPsfSMBK9goyatD8jsD5HZVSz04kd+DbCu0Dx9N8pgfqAndtP3A5IEYM3BIsK+zk6+oxDYK6x+kVoErj/26wSIJ0KPK1iNbIUxb/ZGNZodFZFSll7icBjVzfhDQsP7KaGzMXaefUxarc6ctEUuVX0XJTCzmXrGBCuVndzLMmS3JwKQgdmiMCGmcTER9oqsA6yr2dhhMNdeYxLMf2H1UTTz2TbICukvWogO7YtxXcNly8/s3+tY9G80DDKgOaQd+2UMOOV447g=;25:rbzYr8ZfBuKp99BNuD/vhfRgb4gNGzn+h0CvzwCijBA0dsTFUeHtlwoghD2vz2/WIkPYzmegAm4XJHJSw0eEo3lNEB+i8151gOm47y4CNahhX9MAglEYLHRqvXTxQr0HeEdZKHYDB2squcu24MD8V07pLZYP+9qJFRijAks+EcDwNdbPnDNIRXYIgyBbNjItTyHXc+XJ8RRxVe6UUNRLliLFa0spvLkaXv6UKA5BvBAknLHJaq0dQGIwZKMOF3HsdkoJ/yBVGYV4JrZrN3T5lPLEMxQi0Y88qqQOt+kFNA++J/DA/qBZlqFaN+QHPW5yPTKgHBsHu3c4prrMqzpMaW7AtLp9uez9TzCfsb7uqB+uj+XxTUXp5d7kYPCABQ4uIKlTPGfUXTyMgTpylIWTtVFWOtW1DbZSZ5S6ZpStawZq/s+aAtr8CuGKtiAA4j6flWPoJHZVlsCc2an29hs+uA== X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1148;31:NsITWVhjB6oc5ChDzLVyxaHxtolOG0sHlK9es4O3BH8FXfdLseDT+WWnmHb3HTzMu+p4/9la9k5kcWFePwvfcIsTMeYZoBHdLKR2WK/bMTO+ecOdCH8EVPWhrgTHZimXGpZLb0uegY8f4/Ac0iqs6vFbOub/ayoMuWufLBqW7/gw/16jypPAP6EIaYqzx997JuYLjpWitgdbc0V0e2lGjA70TZxEzqHGly7fs4TBODvQqO5ODWa7inLBRppjecE0;20:wAiqbjouvTIMkeaaV5YGV7Mw0BbSdRhIEiHr8sYs7GbKTdeMQ7GH0qKMgrWpCkYfRCd1LXA77cD1ughsWSp8BsmHMDdPqUIzT6UabrfNO4Z3dN18EMepIa+gwcBXbTpjSe792Rgw7RQUD2qm2z8wd5o1cJTobcl7VIC0Layi1PXPraVoFMrxxtRo0Z2WwjTpuSH0M16R9bVeS1s7NAo24DwLIVrTyIvjPiCXb67y0ZUBsJEAaTgrwgatBMBLNEtKsUHFSLA8dLrJ/LoVR/+Kmr7da2kREDnlLeOWgdvgF1MAFWjf2tNR6vuSLitKdJigGU5idsR0LAtze+OSebPvQQ9VHbHGrO67kBZO11Q0XEJR9hyOw+i4N9CUbqBq24Z1aDvWzBMDw0DTsIeaWBIU5Y05/dvYnqFwSEnhDl+UttYHz/GxjTMEvZw3iAtWGGKPjk9yC+Uh7lUTJO61qy1l6c7MGqECi25iafJsvhzrLILaD+cYcynzbTEIKkn1iMjY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(20161123558025)(20161123555025)(20161123560025)(6072148);SRVR:DM5PR12MB1148;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1148; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1148;4:UyGYQbfqiJeCmj4noL+B/qP8c4ojmD5JNQTQ+zhS9oep6XxoB/STvkyRwxc7nz9BuqZhGw3V546tzCVqVAi1LRnItqM/N4umW0symxdwp8NHhFsIbvbZ1tcAueAqAe5dm++8guz90euCfT8tawoziYZ/Vup+MBryYkAWSYS8DFXybUAurGwR3LlYDblTbdutdzNGuD8mJc9kkyWapI1WEY2jzbHnAosXVccpqkpSWoTS03pYTwybkO0rGOikFBU/3Ar8PrADELf1HcUMi3MKmBxUdL79ZLgPMYtEjaWOlpEB6uuy2FKKvCKPqOs+8agGkP3BgozGGmXxfNitSLNYmgESlkWsPwPEnDQWshluA7f7GpTstxhzHNbs80cY7mroArlGibSF4vZut5PUxsJuLOt5MwAzdIY38QhXDtK31y0KGks0oMd6OkDi/4ehSynOtNwOo6ORDyEws8QsOTe3pqnNcVzS7+2nfRoiuP2Hz2DZdh5PVUzySMQQZQB2ZS3hW+hXHXKlZcnqk52UQFqz/lNBeROY+cloR5RQ0ePpGWyiySMth5d1RHN0Ww+vGlh7zQGWb8uQiU3H7N5dhBoeJjE3Bfe8YD7aUE6n/hQ4NHjWUUMSeI+kNxOkz6otmngF X-Forefront-PRVS: 02426D11FE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39850400002)(39860400002)(39410400002)(39840400002)(39450400003)(209900001)(377454003)(24454002)(65826007)(77096006)(4001350100001)(42186005)(4326008)(575784001)(3846002)(2201001)(86362001)(305945005)(6486002)(6116002)(5660300001)(31696002)(90366009)(7736002)(33646002)(36756003)(23746002)(65806001)(50466002)(2950100002)(65956001)(25786008)(50986999)(230700001)(189998001)(6246003)(47776003)(81166006)(31686004)(6306002)(53546006)(966004)(229853002)(6666003)(8676002)(38730400002)(53376002)(64126003)(83506001)(54356999)(76176999)(66066001)(53936002)(2906002)(6606295002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1148;H:[10.236.64.195];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR12MB1148;23:77mvU+uRgpFTXyZYIQy18ONF1uWSYU0TDxVWZ?= =?Windows-1252?Q?RTLs0/BhsYK7x6Duq0ckKbar+++NOGARFX6gNvs6m+jddhboNhs2smQI?= =?Windows-1252?Q?/yUNAJhDZWCal6ZAEh/oVTm/j0IX9bbO6G/HdVtbeUo64qBF0J5hNQZE?= =?Windows-1252?Q?lqc0Rx73fZe0G4hLjhnUMlPDIrxFTnGbO5cdaLOc9GCoKndSU5pfMAEI?= =?Windows-1252?Q?phHKZGCbHrfkveTzAVWAVEBLq08DHZmDVYmlR2klGqYSGr4igVvB2Vey?= =?Windows-1252?Q?f1u9z/+GX2IrNddM8NQSUqFhyYRIm9sPitTxQOfarXHaMrmncIGN2xKp?= =?Windows-1252?Q?M+PvaNEABHTD/I0KJpYQmP7clf7EIy4imigwkrbictMX0kFs5MfskM7S?= =?Windows-1252?Q?l30Tk5WQQLNlZonhehS4qPtOaHSDeCgJjKEb1Sie8n6UUJqmH646VGJJ?= =?Windows-1252?Q?x5Zsx6HaY7a4gSpOxyFjuImEEtME3+qCGMG6/74RGt8vgNLmfXYNScwm?= =?Windows-1252?Q?b1KdTCdmIiIRGcAi6m3cRNOxXfRhLoU6XPROWPJZYUHopszgCyU3W9jx?= =?Windows-1252?Q?6HnFsQjC44u6sGF5EIoD56IGq58Zy+qTn112TLuEDS4bmDU+a8r+hM83?= =?Windows-1252?Q?ntE2bLwpVXpWP1nQJmPgxPdYQi3Azu9LmqutPGVjsY6ThJan8PqVncwr?= =?Windows-1252?Q?btYsMfcxyEyqSaSXBbwjMbfl4VYCPVyPtxR4q29mMAQA+OtSFsUfdLcP?= =?Windows-1252?Q?7Xou2bfB3srT37zde5KKjXsbtlzU4BNh9kyaMBpMI3Uu1Y/YSYb2Pwu7?= =?Windows-1252?Q?aY9RszVPamkFxq0RMZBnsDmfG0VH3gn/Po87x93QT4RR/qmQbT/gO/pf?= =?Windows-1252?Q?eiBM5Ig3JPqZC0diXwOSivuueqsWfX4dCmSJnaPoVSMqqOajS5OO0AZ7?= =?Windows-1252?Q?FDiluy5K792Ya7n7NdDQ/8WsKynCo4DriDBdiC1JjAjyJ85KxFX5DjCb?= =?Windows-1252?Q?cqg0SCZhShAwyMVgPPb/f71L7IoDTy4VKJXTNaqeqWb4i9ML1dChGhXF?= =?Windows-1252?Q?DDiLbFtKOfzKqjz1PG/yNxIrioGLsaL93ywhYWAvTq62TiNGODFDGmZl?= =?Windows-1252?Q?PuqVfwf0zXWcDyQfNofFx6pdO4EShUz0kBIXMIsnxC4Qy8NZH6sLGMEo?= =?Windows-1252?Q?GgKl8YZJ9sAant4my8Pc7oWiSOcAMuMG7Qae5uFccTt9F8rXlBl/IoJB?= =?Windows-1252?Q?7JFkqx62A/h2vOCxzcV0lQoPB24ZtWaAF9E9nhfIwxHYmVeEQC+FByZ+?= =?Windows-1252?Q?KfMTE5oS+kEw2/EADPedHvgPlms1fuFXmx7Lu5cy1tDF07yH7eI3mmvD?= =?Windows-1252?Q?3djlXgwjDfIbvUWdHZYswIFYo7YLiwUJfSb7GZhd4YiL3ME63B3WOceY?= =?Windows-1252?Q?eZIa1ufckJq5X9HSToWErniNvhPtkAwdq+IGJeb8ZaJSrQp5+D1ClEo4?= =?Windows-1252?Q?5e8puULbzbZjojCsu05L2FVzqAlHXAXKQZqRj6kgpFDqfN3/A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1148;6:AbWG02/q56SB51u8YxDYehZOz8pxtti2P7cyidSlwsvLQy0Sw+XVObnXRyt5r5dium7wBNaE5cJNxWIMXBCH4MUjx8XVY+ZIfinla2Vlm5xFu78+J9tPMlD/sHuXs49LlR8FWg40TtxIWM4mA5lwRJLS0NLyKaFEUXlJw2muQ6ZO0pkBdofGikoHHUm+n0JUbMDBW1KbKSGJe0SNWYf4bM8kc5xmVH5j9eUi2OXtxZOTxuHi3uu9gGxUkvBNmccFFV+MmsX7LErss3DFOs9X+53SdzSQKkPW+XJB4zNEI34rA7D+sNMOiJ1zhb2Jxtc0FjboQCgyWORqA+hvi4ZIy7bplNJC96wbDklhpvaVpwMDHfcbBuYTinS1HmhuxDmElJXZCHMf++Lx0QdyHUU87Jhi4Ul0Nw2u7sqJlq2GY4Y=;5:nNAN8abw/F2fq47Pkvt/DoArCaMbtNm1wfaqY7He7r8oK3U0Vx8Qeds/ZHpJO9OK5+2xO5dcCUVP6U15T17+Gh6oMJ3gx8HfM2LH81lQ9liTEbO2BmuwKhLWb+VXRV7H/m5WmyWvwgYKcemBrYh8iA==;24:e8uiTV/1ek0SNVi3cPg/UDNLhLR9Z24s2UQl6NspPWD7zVtxEafpp7xwQQ0NyCcQsYhIggWr9XqM3M06vAimbW+edt/crDwcQ3fSF2WL6Ho= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1148;7:C/y3+7orpQz3RZllKyYKrLDsvbiR6w0Gj1JDeWrsF8Zn312xEPF7GKL8G12eToehLXSws4waAJdtskX6WV0Ph1/4zm7ip6wvGpr+UJmgTr+J+LxIOsjxhWd6N1WhdpyTA2/qPm2WU8CWFxkvujV7Sn7N1d5F/YEyZRBYRQS4lLYYTbbOh7moPJVoh71G4qIoKeFUvRC0TYwe+1YCtaKlBaPRpj7SlE47A2VvFx0PBC5V3o4/Xtz3yaC2RDPjTUxkWVQ+5jGQUTZI0mbms5lSw/9h21XLOL0CXLx1ZR0gRMZDEJIQWVW+wQMk/GL5wiY9Yn6RyYzXQO40ZYOvUcqYrw==;20:kuBA72mLurQrIyWIDxns8fkj6Yq3AUD8AAYZs9LEHmg/oYA0ZGgqNVCXFUSmlrmAAUkop1vVC9/NvDEpaUJ3uKBLvWMazgADq+WrPR/YvNjougHD/hO/hUBJLFiJUwxVoXdxDFM5EdcPJySXLd1CMh+HFgThOEkPaI4Pj3vs8t625wV6nWeUAG5BTcjFHZvsA26UILHxS5ORAbWyxkQqp6Yz8bWvC+ToOxVbICNBg2c8yeQGDmNbQj2hbZTqmXnP X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2017 17:39:45.7439 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1148 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/10/2017 11:19 AM, Mark Rutland wrote: > Hi, > > I'm seeing the below splat when transferring data over the network, using > v4.11-rc1 on an AMD Seattle platform. I don't see the splat with v4.10. > > Looking at just the driver, I couldn't see any suspicious changes. Reverting > commit 402168b4c2dc0734 ("amd-xgbe: Stop the PHY before releasing interrupts") > doesn't change matters. > > Any ideas? Yes, patch submitted. Please see: http://marc.info/?l=linux-netdev&m=148910333810442&w=2 Thanks, Tom > > Thanks, > Mark. > > [ 106.114135] Unbalanced enable for IRQ 34 > [ 106.118157] ------------[ cut here ]------------ > [ 106.122793] WARNING: CPU: 0 PID: 0 at kernel/irq/manage.c:529 __enable_irq+0x168/0x1d8 > [ 106.130708] Modules linked in: > [ 106.133766] > [ 106.135262] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.11.0-rc1-00001-g2411f70 #5 > [ 106.142830] Hardware name: AMD Seattle (Rev.B0) Development Board (Overdrive) (DT) > [ 106.150398] task: ffff20000a9e2000 task.stack: ffff20000a9c0000 > [ 106.156320] PC is at __enable_irq+0x168/0x1d8 > [ 106.160679] LR is at __enable_irq+0x168/0x1d8 > [ 106.165036] pc : [] lr : [] pstate: 000001c5 > [ 106.172428] sp : ffff8003fff17c50 > [ 106.175742] x29: ffff8003fff17c50 x28: ffff800359255160 > [ 106.181063] x27: 1ffff0006b24aa2d x26: ffff800359255170 > [ 106.186385] x25: ffff20000a9ca000 x24: ffff800359255168 > [ 106.191706] x23: ffff80036902ca80 x22: ffff80036bbe8f78 > [ 106.197027] x21: 1ffff0006d77d1ef x20: 0000000000000000 > [ 106.202348] x19: ffff80036bbe8f00 x18: ffff20000a9e27b8 > [ 106.207668] x17: 0000ffff7e2b5d90 x16: 0000000000000000 > [ 106.212989] x15: 1fffe4000153c4f7 x14: 00006003f5590000 > [ 106.218310] x13: ffff20000ac45000 x12: ffff20000b803000 > [ 106.223631] x11: 1fffe40001ba7a8d x10: 0000000000000000 > [ 106.228951] x9 : ffff10007ffe2ee0 x8 : ffff20000a9e27e8 > [ 106.234272] x7 : ffff20000d2d3000 x6 : 0000000000000000 > [ 106.239592] x5 : 0000000041b58ab3 x4 : 1fffe40001ba3a10 > [ 106.244913] x3 : 1fffe40001ba3a10 x2 : dfff200000000000 > [ 106.250234] x1 : ffff10007ffe2f58 x0 : 000000000000001c > [ 106.255553] > [ 106.257044] ---[ end trace 86935ef2e5e5c498 ]--- > [ 106.261658] Call trace: > [ 106.264106] Exception stack(0xffff8003fff17a00 to 0xffff8003fff17b30) > [ 106.270550] 7a00: ffff80036bbe8f00 0001000000000000 ffff8003fff17c50 ffff2000082a1340 > [ 106.278383] 7a20: 00000000000001c5 000000000000003d ffff20000a9ca000 ffff800359255170 > [ 106.286216] 7a40: 1ffff0006b24aa2d ffff20000a9e2000 ffff8003fff17b60 0000ffff73870f20 > [ 106.294048] 7a60: 0000000041b58ab3 ffff20000a7164f0 ffff200008081ac8 ffff20000a05d4a0 > [ 106.301881] 7a80: ffff80036902ca80 ffff800359255168 ffff20000a9ca000 ffff800359255170 > [ 106.309713] 7aa0: ffff8003fff17c50 ffff8003fff17c50 ffff8003fff17c10 00000000ffffffc8 > [ 106.317546] 7ac0: 0000000041b58ab3 ffff20000a72a340 ffff200008299380 ffff20000a9e2000 > [ 106.325379] 7ae0: ffff8003fff17b20 ffff200008bf8f08 ffff80036bbe8f00 ffff80036d8002c0 > [ 106.333211] 7b00: ffff80036d8003f8 1ffff0007ffe2f70 0000000000000000 0000000000000000 > [ 106.341040] 7b20: 000000000000001c ffff10007ffe2f58 > [ 106.345921] [] __enable_irq+0x168/0x1d8 > [ 106.351323] [] enable_irq+0xa8/0x118 > [ 106.356467] [] xgbe_one_poll+0x190/0x280 > [ 106.361956] [] net_rx_action+0x6ac/0xd88 > [ 106.367444] [] __do_softirq+0x324/0xb70 > [ 106.372845] [] irq_exit+0x1cc/0x338 > [ 106.377900] [] __handle_domain_irq+0xdc/0x230 > [ 106.383821] [] gic_handle_irq+0x6c/0xe0 > [ 106.389220] Exception stack(0xffff20000a9c3d40 to 0xffff20000a9c3e70) > [ 106.395663] 3d40: ffff20000a9e27bc 0000000000000007 0000000000000000 1fffe4000153c4f7 > [ 106.403495] 3d60: 0000000000000004 0000000000000000 0000000000000000 ffff20000d2d3000 > [ 106.411327] 3d80: ffff20000a9e27c0 ffff040001538762 0000000000000000 0000000000000003 > [ 106.419160] 3da0: ffff20000b803000 ffff20000ac45000 1ffff0007ffe4281 1fffe4000153c4f7 > [ 106.426992] 3dc0: 0000000000000000 0000ffff7e2b5d90 ffff20000a9e27b8 ffff20000a9e2000 > [ 106.434824] 3de0: ffff20000a9e2000 0000000000000000 ffff20000a9cfeb0 0000000000000003 > [ 106.442656] 3e00: 00000000000000ff ffff20000a9cfe18 ffff20000a901058 0000000000000000 > [ 106.450488] 3e20: 0000008004810018 ffff20000a9c3e70 ffff20000808a1d8 ffff20000a9c3e70 > [ 106.458321] 3e40: ffff20000808a1dc 0000000060000145 0000000000000000 ffff20000a901058 > [ 106.466150] 3e60: ffffffffffffffff ffff20000808a1d8 > [ 106.471029] [] el1_irq+0xb8/0x130 > [ 106.475909] [] arch_cpu_idle+0x1c/0x28 > [ 106.481225] [] default_idle_call+0x34/0x78 > [ 106.486888] [] do_idle+0x21c/0x3c0 > [ 106.491856] [] cpu_startup_entry+0x24/0x28 > [ 106.497517] [] rest_init+0x1ec/0x200 > [ 106.502659] [] start_kernel+0x5d8/0x604 > [ 106.508061] [] __primary_switched+0x6c/0x74 >