From: Jan Kiszka <jan.kiszka@siemens.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>,
Sascha Weisenberger <sascha.weisenberger@siemens.com>
Subject: Re: [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards
Date: Wed, 31 May 2017 18:34:16 +0200 [thread overview]
Message-ID: <6ded8dab-caec-70e3-daf0-16622f89970a@siemens.com> (raw)
In-Reply-To: <CAHp75Vc0t5t8O5cPaxX_oQJQKsN3OWNFfqnA_K3GW4qpfY+N5Q@mail.gmail.com>
On 2017-05-30 20:33, Andy Shevchenko wrote:
> On Tue, May 30, 2017 at 10:01 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> Commtech adapters need the MPIOs for internal purposes, and the
>> gpio-exar driver already refused to pick them up. But there is actually
>> no point in even creating the underlying platform device.
>
> It still feels that partially you may do stuff here, like
> renaming to
> __xr17v35x_register_gpio()
> and creating
> xr17v35x_register_gpio() wrapper.
Sorry, that remains unrelated to the topic of this patch and would be
unclean. If you want me to pull those refactorings out of patch 9, I
need to write a separate patch - no problem.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2017-05-31 16:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 7:01 [PATCH v4 0/9] serial/gpio: exar: Fixes and support for IOT2000 Jan Kiszka
2017-05-30 7:01 ` [PATCH v4 1/9] serial: exar: Leave MPIOs as output for Commtech adapters Jan Kiszka
2017-05-30 7:01 ` [PATCH v4 2/9] gpio-exar/8250-exar: Do not even instantiate a GPIO device for Commtech cards Jan Kiszka
2017-05-30 18:33 ` Andy Shevchenko
2017-05-31 16:34 ` Jan Kiszka [this message]
2017-05-31 18:02 ` Andy Shevchenko
2017-05-30 7:01 ` [PATCH v4 3/9] gpio-exar/8250-exar: Fix passing in of parent PCI device Jan Kiszka
2017-05-30 7:01 ` [PATCH v4 4/9] gpio: exar: Allocate resources on behalf of the platform device Jan Kiszka
2017-05-30 7:01 ` [PATCH v4 5/9] gpio: exar: Fix iomap request Jan Kiszka
2017-05-30 7:01 ` [PATCH v4 6/9] gpio: exar: Fix reading of directions and values Jan Kiszka
2017-05-30 7:01 ` [PATCH v4 7/9] gpio-exar/8250-exar: Rearrange gpiochip parenthood Jan Kiszka
2017-05-30 7:01 ` [PATCH v4 8/9] gpio-exar/8250-exar: Make set of exported GPIOs configurable Jan Kiszka
2017-05-30 18:35 ` Andy Shevchenko
2017-05-30 7:01 ` [PATCH v4 9/9] serial: exar: Add support for IOT2040 device Jan Kiszka
2017-05-30 18:38 ` Andy Shevchenko
2017-05-30 18:39 ` [PATCH v4 0/9] serial/gpio: exar: Fixes and support for IOT2000 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ded8dab-caec-70e3-daf0-16622f89970a@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=andy.shevchenko@gmail.com \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sascha.weisenberger@siemens.com \
--cc=sudip.mukherjee@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®