From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 353C623314B for ; Fri, 12 Sep 2025 17:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757698873; cv=none; b=uzgkR199enM29lwjyJgGpuLFpSsn4ZABl4CLYGcwcA1l8k8dARTiSZm4+OYNQwEZez7rhIYomXJ/WHNXuzj5k7ksG+TscIGG6rk/AhI63JgjqNNwu40Kni+cJEmFkwQGRK3K22LVaVMF7xtPRSD1itDMBjU/96zvvOn1ATWAYsM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757698873; c=relaxed/simple; bh=ebVMkI3NMLghY3II0wHlBBRcDRzhUEGXKBz6MIW4EmQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hBv8NJgU2Ihs5d806re/s0Pc9WvdX7KTp/TTSxEcdGPFubJ2V2Su6Ry65YRPmFWXbasiEHxRW4L08RjXnS4leMN4R6iKUtyaiZF2Uex2INt9ax6kABxG4H9lZ+tFEyCQXjnCM+w7FZu7hDZkToxrDNzChu/rpeSv3sVpsWAvwpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=tAjR29Eu; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="tAjR29Eu" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-750e52fb2deso1829254a34.1 for ; Fri, 12 Sep 2025 10:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1757698870; x=1758303670; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UMFngDg+ThTxH2TqhAB/OrQnknv0ugZMsORXJCad8C8=; b=tAjR29Eup60dWmdPXZTlLtnuXR51PmBwfneMTLfOeMuPdMQZ6t4DpJ+P59gLo3IOr0 aFla4USTyJO2Oy1IYD2OK3Pxcdpi7+dE3Ce+svZhO47OyUUSzvnNH3FqRleqWmb/BlKf XVh9/WFd390bEl+B4aXzSwucvxFoY1kzloR1myNdgyY6foky7NsVCONoAjgkQFjLv0ug QYaEuySSreWaSirwuHkufF+0F9tp2rlLdghKYgyF5W3MHN/HRgVSL2dgsMmJIBdMxYRk fpVS8F14gckwGgT33Rwh4f/Vhm7TFNEqymCFQEeMnqC8jsWeXsOW1GutKeQ8XYZP39uT 6w5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757698870; x=1758303670; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UMFngDg+ThTxH2TqhAB/OrQnknv0ugZMsORXJCad8C8=; b=rPDW5FjQGKnocT6fNTokhaV0ZNRGjpZ55pJV5zjmM3E7H825Y1jG7LjZjbOH1GnNxE cASmVDPVqQOnjcW3BDNKNurCqE6QxWCPqt1V4iEXC6F5qm2RbmO3oAwlsVqfQ2FtvpCK x1n7tndOc6DSCzqN6QDChsScIdAs2jhZfz+nzNE81GvRE4XbO2c09siIq2QWSpALr6qk jcRXZ03W12O+1JNYJV57wVD0QNCvQUEuXK9HFJfIN65l5we5FpNeXCsSKGXQu/hWUT32 Hwu6YLo1T/3/b+YLwVmR9YvaN62WvqERG5ctS9P/WMwKGaoJJ3LAiLN6DctqDuJky5Kr deaA== X-Forwarded-Encrypted: i=1; AJvYcCXf5LeVgsm+Ng2m3Qdm1/nC8e/GkdvkxgAl1yTzL1vvQhhnXpSA+gUXrrSeVHKrogVpcGbjKxBYe7P0Aqs=@vger.kernel.org X-Gm-Message-State: AOJu0YymyieKVIk1gj9xOV521TpGLnzSl/G3eTIQhCrzikuyfYLMDD5n XXRHAlDFTwqcytFerDYT/BZEePr6OGGFRDlbiY2/BRr5SGnI7BIr2u4znZtQKGfGTrM= X-Gm-Gg: ASbGnctCa2xukzmQJHmZOmspDGXYVd7KpK7ZA0fED5aRp1QYFuqMSk+VlIwps4AYDDF 2led5f20llVrVjv6+mMrCi+LJDRkgsfEgNzBVaC5gMJPiytH1nAYh4LlbhC2c7R7slqemXVD1/9 JniKqYbogmVKIpv3a0LBQxiNoSylCez9fKQ+vmLHkBDCWZLDaBErPyMsLqhcs+w706UVW2bCVzV vCorsY3iF+m4uT/Jlsb6FFhsg17/Oc+1AV5q7axzEpHZBzMf7VMEW//j3AOH7Xt1Dgj/C1NzrLz rX3cUJvd85Yo1LlQ7dNwtZBYk/urQls7NB+ArRWK+YgQN+dPT6KO2CfQ1Yji0XpS7VxdC/VSyZX ogyxPwu33fGoLZ8Q3E1arNLkO6bOJz1mmZsl4Nx/4uy1V3ikOQdks+zs3s7D6iaaJZa1DLRgnrn A= X-Google-Smtp-Source: AGHT+IF4uHwM0m4f1PF0IHcsQHJY8vH9pv/dJXciija6fJHfMxoFbxn0mU5WZrupa3mzpzPuWfE4wg== X-Received: by 2002:a05:6808:2185:b0:438:1b50:fd7e with SMTP id 5614622812f47-43b8d934557mr2303922b6e.22.1757698870299; Fri, 12 Sep 2025 10:41:10 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:fdf1:f11e:e330:d3c1? ([2600:8803:e7e4:1d00:fdf1:f11e:e330:d3c1]) by smtp.gmail.com with ESMTPSA id 5614622812f47-43b82aa7b97sm869170b6e.24.2025.09.12.10.41.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 10:41:08 -0700 (PDT) Message-ID: <6dee1849-45f0-47c8-b29e-8057dee44b6a@baylibre.com> Date: Fri, 12 Sep 2025 12:41:08 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] iio: adc: ad7124: use guard(mutex) to simplify return paths To: Andy Shevchenko Cc: Andy Shevchenko , Michael Hennerich , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250911-iio-adc-ad7124-add-filter-support-v2-0-b09f492416c7@baylibre.com> <20250911-iio-adc-ad7124-add-filter-support-v2-3-b09f492416c7@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 9/12/25 12:15 PM, Andy Shevchenko wrote: > On Fri, Sep 12, 2025 at 09:19:36AM -0500, David Lechner wrote: >> On 9/11/25 11:39 PM, Andy Shevchenko wrote: >>> On Fri, Sep 12, 2025 at 12:42 AM David Lechner wrote: >>>> >>>> Use guard(mutex) in a couple of functions to allow direct returns. This >>>> simplifies the code a bit and will make later changes easier. >>> >>> From this and the patch it's unclear if cleanup.h was already there or >>> not. If not, this patch misses it, if yes, the commit message should >>> be different. >> >> cleanup.h is already there. I'm not sure what would need to be different >> in the commit message though. > > I expect something like "finish converting the driver to use guard()()..." > cleanup.h was previously included for __free(), so the guard() stuff is all new.