From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8FCFC4332F for ; Mon, 14 Nov 2022 15:53:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231609AbiKNPxd (ORCPT ); Mon, 14 Nov 2022 10:53:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230079AbiKNPxb (ORCPT ); Mon, 14 Nov 2022 10:53:31 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF2ED10F1 for ; Mon, 14 Nov 2022 07:53:29 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id r12so19988998lfp.1 for ; Mon, 14 Nov 2022 07:53:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ql7BbfjZhi9PUKex4VtigUx0q+x0JH+qcMLmXxKcm9A=; b=B6RXSrmcloy8u6hww8BgiAqFD6lcgsmVusw5HA8LMyLb3k7XTt65oyuat6B3WJSLjE 0WAopbgePqczDLA2XSyO2OMPuyq+m9jZTtNAcKmMPm97TjdNVuSthc7DD2cBqm0DUPH+ 49s3nTx2N9CuB2eapMLAD2qmaA8ESM6ZJHk8bGUMKEB4RzlZqA4+qFxsUyaWKrCbvuyN TmkJdndOYYEFqjhZLpf1B2aZwHWHQp3UMwVoakPWAZAkUcDCVAOYxf1bGf1majwRo08+ WzZuHoZI3+jSSKbWzVALSzlhj1jo2MbvtkqlKKRNEDHyYFkDowiUSs4W6kdAZoPwhfm0 tNhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ql7BbfjZhi9PUKex4VtigUx0q+x0JH+qcMLmXxKcm9A=; b=ktw+/A+x89EyjZ2bK/3nC39w3sKgI7JTBX0gQEF6Kd0OpnZ48//WU3UbrjycwpaMVF ZqsYfDwnsJVCUNxVuRwmVrQaLMzIYQ3bBccUiLPh9qn6bkTfotHEWNYA0A7BL3iC6jVr 6PeGxZPxW7yqwxnpwKBBQSpIBMsTauSdKjhZ6aLi3D0duyb9hToCtNGmR89nOF5uhKcT +OZbCjIumOedis9hFSkzU07i/1fnIbP5qccExd+GkduEy75Rnkk618wCq+qxj74UbZmn jgz1cgCHDtf3PTftw1cYyaal/ZIBKeQtDQLrd+j4+IVldgq4JRO1Y00yfCzEBVRksuya 7Ekg== X-Gm-Message-State: ANoB5pkuqrlpyjIf81G00hzjmx0LctlvyePJYhf3qJKwoA7Q0mpwk5IG R59Cr3t54LgV21iRpUm82mqFe/rGvYWuakxr X-Google-Smtp-Source: AA0mqf4LOVfsXdJpid8qCBFEZKOX1+gwsm7JoP/gdBWrJumjJEp6xqZ9ZpFEUBbr2IbTJX74ohz6Qg== X-Received: by 2002:a05:6512:3e14:b0:4aa:7eed:f70c with SMTP id i20-20020a0565123e1400b004aa7eedf70cmr4871674lfv.630.1668441207703; Mon, 14 Nov 2022 07:53:27 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id 2-20020a2e1542000000b0026c3ecf9a39sm2072160ljv.38.2022.11.14.07.53.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 07:53:27 -0800 (PST) Message-ID: <6df463da-1065-025f-b104-dea5c0bd0dcd@linaro.org> Date: Mon, 14 Nov 2022 16:53:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 2/2] drivers: arm-smmu-impl: Add QDU1000 and QRU1000 iommu implementation Content-Language: en-US To: Will Deacon Cc: Melody Olvera , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Robin Murphy , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221026190534.4004945-1-quic_molvera@quicinc.com> <20221026190534.4004945-3-quic_molvera@quicinc.com> <0ae09be0-cb1b-dc27-943b-db64ca97b8c7@linaro.org> <20221114144220.GA31043@willie-the-truck> From: Krzysztof Kozlowski In-Reply-To: <20221114144220.GA31043@willie-the-truck> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/11/2022 15:42, Will Deacon wrote: > On Mon, Nov 14, 2022 at 03:28:15PM +0100, Krzysztof Kozlowski wrote: >> On 26/10/2022 21:05, Melody Olvera wrote: >>> Add compatible for Qualcomm QDU1000 and QRU1000 SoCs to add iommu >>> support for them. >>> >>> Signed-off-by: Melody Olvera >>> --- >>> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c >>> index b2708de25ea3..0580a381a04b 100644 >>> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c >>> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c >>> @@ -426,6 +426,7 @@ static struct arm_smmu_device *qcom_smmu_create(struct arm_smmu_device *smmu, >>> static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = { >>> { .compatible = "qcom,msm8998-smmu-v2" }, >>> { .compatible = "qcom,qcm2290-smmu-500" }, >>> + { .compatible = "qcom,qdu1000-smmu-500" }, >> >> The patch was applied but it contradicts work here: >> https://lore.kernel.org/all/20221102184420.534094-12-dmitry.baryshkov@linaro.org/ >> which explicitly asks not to add such compatibles... > > Sure, but we've been adding new compatibles for years so I don't mind > picking up the last few now before we stop accepting new ones. > > I already asked Dmitry to respin his series as there are some open comments > from others anyway. OK. This also solves my other comment for other patch. Best regards, Krzysztof