From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.143 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795103782; b=2QbIYMpvbVGYbKyIUdQ7Y0tvuEQBQ6ouqq+iAta8e5Tw0LPv7xaJgVAbUqdVO6tonXLS LEURxBFY42JV+9t4J2xjrycM38pN9tG17vJtkYIcZWrG4kIdl6p4+JUu6sLpZwMqdYNy8 SKaKCiRi2cdOxtjYncue05vJC9Thxxm3X0R5fG+8pL22gPP2byIJQsXkYWgcvfkl0zrkx 8kdo8rg90b4FUZiYfsjWtSJkvUK53VoBSbBO7Ct8mYznR3DWVSuU5NvR9PL8idq4V0N8F x/yK+mRREdzahplhBSrqYlRJ9XinVhm3U0zEUiO2RRStkRPXThPkobMDU/ite91lKcQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795103782; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:MIME-Version:Date:Content-Type: Content-Transfer-Encoding:From:Message-ID:TLS-Required:Subject:To:Cc: In-Reply-To:References; bh=n+k74e9867nRhb8ulyLRle75AgKH2rav4a8VKiRxz7g=; b=PZrhEl5oKXnpArzB14l7UyaM0cLqdqr0YQuFED6gxCMFKoOrbtxRTxOWvY4olfrij9qI FP0KVK0wF94oxyUwj9JflndlVgqeKNRzrG4wjMIOaIDsuHphpcicDw4QYfLDF8GvYoAOk eMbszweuZY8/kLB7wcG0hEBAUM1oMmfFdWiMKYhY3LZr6bHHcHGoDPL3l52FZBBwLiQFC d6LXhO+ID1YPLWxI3y+H32MlWZZmVgp32N2GTUO/PgavOCUOHyIMppdquFN+cDW+Bo3WC 4WERc45o11s6DShVoH7OqFU9wMgIVJHhF1oN4Fwx1pwuyJ4z6nwPc++gsy3rcGb/7lQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=klsxY4PJ; arc=none smtp.remote-ip=95.215.58.143 Received: from mta1.migadu.com (out-143.mta1.migadu.com [95.215.58.143]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15DC2606A320 for ; Thu, 19 Nov 2026 15:56:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 15DC2606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=klsxY4PJ X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=ccsxT6du60e05bc+5yqFYQ0nZGJ4mi0+0AzsLneGKZo=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795103780; v=1; x=1795708580; b=klsxY4PJMl4Ikgo+XQKCm7RtgIevP/q/v5kRoZWFqtjJ092Y0vbMrBbA4cCeHgEKgUd9+Co0 gn/CVJdvsGwuro+UMNi/q5MOuM8fZtlc5G9qjm2CclVAVNTd+IbEtXxN5xDT1EMSJ8GbFB+TIVu E3LrltzHOAK3lrK3ZXJABywA= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 4a01da6eccbc7804; Thu, 19 Nov 2026 15:56:20 +0000 X-Mizu-Trace-ID: 4a01da6eccbc7804 X-Migadu-Flow: FLOW_OUT X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Date: Thu, 19 Nov 2026 15:56:19 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: "Kunwu Chan" Message-ID: <6e04aec6ca71cd754ace7ccae8284edb472b6528@linux.dev> TLS-Required: No Subject: Re: [RFC PATCH v4 01/18] mm/swap: remove unused parameter for reading swap header To: "Lian Wang" , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, "Andrew Morton" , "Chris Li" , "Nhat Pham" , "Baoquan He" , "Barry Song" , "Youngjun Park" , "Kemeng Shi" , "Kairui Song" , "Jihan LIN" , "Kees Cook" , "Gustavo A. R. Silva" , "Thomas Gleixner" , linux-hardening@vger.kernel.org In-Reply-To: References: >=20 >=20From: Kairui Song >=20 >=20The swap_info_struct argument to read_swap_header() is unused. Remove= it > and update the swapon() call site. >=20 >=20No functional change. >=20 >=20Signed-off-by: Kairui Song > Signed-off-by: Lian Wang > --- > mm/swapfile.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) >=20 >=20diff --git a/mm/swapfile.c b/mm/swapfile.c > index fcda5eba1714..c41c4d26a7e6 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -3630,9 +3630,8 @@ __weak unsigned long arch_max_swapfile_size(void) > return generic_max_swapfile_size(); > } >=20=20 >=20-static unsigned long read_swap_header(struct swap_info_struct *si, > - union swap_header *swap_header, > - struct inode *inode) > +static unsigned long read_swap_header(union swap_header *swap_header, > + struct inode *inode) > { > int i; > unsigned long maxpages; > @@ -3863,7 +3862,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, spec= ialfile, int, swap_flags) > } > swap_header =3D kmap_local_folio(folio, 0); >=20=20 >=20- maxpages =3D read_swap_header(si, swap_header, inode); > + maxpages =3D read_swap_header(swap_header, inode); > if (unlikely(!maxpages)) { > error =3D -EINVAL; > goto bad_swap_unlock_inode; > Looks good, thanks! Reviewed-by: Kunwu Chan